Skip to content

Commit e8750ee

Browse files
Fixed tests
1 parent dbde2b4 commit e8750ee

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

tpu/src/test/java/tpu/QueuedResourceIT.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@
1919
import static com.google.common.truth.Truth.assertThat;
2020
import static com.google.common.truth.Truth.assertWithMessage;
2121

22-
import com.google.api.gax.rpc.NotFoundException;
2322
import com.google.cloud.tpu.v2alpha1.QueuedResource;
2423
import java.util.UUID;
2524
import java.util.concurrent.TimeUnit;
2625
import org.junit.Test;
2726
import org.junit.jupiter.api.AfterAll;
28-
import org.junit.jupiter.api.Assertions;
2927
import org.junit.jupiter.api.BeforeAll;
3028
import org.junit.jupiter.api.Timeout;
3129
import org.junit.runner.RunWith;
@@ -34,7 +32,6 @@
3432
@RunWith(JUnit4.class)
3533
@Timeout(value = 6, unit = TimeUnit.MINUTES)
3634
public class QueuedResourceIT {
37-
3835
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
3936
private static final String ZONE = "europe-west4-a";
4037
private static final String NODE_NAME = "test-tpu-queued-resource-network-" + UUID.randomUUID();
@@ -57,11 +54,6 @@ public static void setUp() {
5754
@AfterAll
5855
public static void cleanup() {
5956
DeleteForceQueuedResource.deleteForceQueuedResource(PROJECT_ID, ZONE, QUEUED_RESOURCE_NAME);
60-
61-
// Test that resource is deleted
62-
Assertions.assertThrows(
63-
NotFoundException.class,
64-
() -> GetQueuedResource.getQueuedResource(PROJECT_ID, ZONE, QUEUED_RESOURCE_NAME));
6557
}
6658

6759
@Test

tpu/src/test/java/tpu/TpuVmIT.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,11 @@
3939

4040
@RunWith(JUnit4.class)
4141
@Timeout(value = 15, unit = TimeUnit.MINUTES)
42-
@TestMethodOrder(MethodOrderer. OrderAnnotation. class)
42+
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
4343
public class TpuVmIT {
4444
private static final String PROJECT_ID = System.getenv("GOOGLE_CLOUD_PROJECT");
4545
private static final String ZONE = "asia-east1-c";
46-
static String javaVersion = System.getProperty("java.version").substring(0, 2);
47-
private static final String NODE_NAME = "test-tpu-" + javaVersion + "-"
48-
+ UUID.randomUUID().toString().substring(0, 8);
46+
private static final String NODE_NAME = "test-tpu-" + UUID.randomUUID();
4947
private static final String TPU_TYPE = "v2-8";
5048
private static final String TPU_SOFTWARE_VERSION = "tpu-vm-tf-2.12.1";
5149
private static final String NODE_PATH_NAME =

0 commit comments

Comments
 (0)