Remove immutable property from MulticastDomain.yaml (#15900)

Author: jgforsberg

mmv1/products/networkservices/MulticastDomain.yaml

@@ -14,12 +14,17 @@
 ---
 name: MulticastDomain
 description: Create a multicast domain in the current project.
+references:
+  guides:
+    'Create Multicast Domain': 'https://docs.cloud.google.com/vpc/docs/multicast/create-domains#create-domain'
+  api: 'https://docs.cloud.google.com/vpc/docs/multicast/reference/rest/v1/projects.locations.multicastDomains'
 base_url: projects/{{project}}/locations/{{location}}/multicastDomains
 update_mask: true
 self_link:
   projects/{{project}}/locations/{{location}}/multicastDomains/{{multicast_domain_id}}
 create_url:
   projects/{{project}}/locations/{{location}}/multicastDomains?multicastDomainId={{multicast_domain_id}}
+update_verb: PATCH
 import_format:
   - projects/{{project}}/locations/{{location}}/multicastDomains/{{multicast_domain_id}}
 examples:
@@ -29,7 +34,6 @@ examples:
       network_name: test-md-network
       domain_name: test-md-domain
 autogen_async: true
-immutable: true
 async:
   operation:
     timeouts:
@@ -100,7 +104,7 @@ properties:
         immutable: true
   - name: createTime
     type: String
-    description: '[Output only] The timestamp when the multicast domain was created.'
+    description: 'The timestamp when the multicast domain was created.'
     output: true
   - name: description
     type: String
@@ -125,14 +129,32 @@ properties:
   - name: uniqueId
     type: String
     description: |-
-      [Output only] The Google-generated UUID for the resource. This value is
+      The Google-generated UUID for the resource. This value is
       unique across all multicast domain resources. If a domain is deleted and
       another with the same name is created, the new domain is assigned a
       different unique_id.
     output: true
+  - name: state
+    type: NestedObject
+    description: The multicast resource's state.
+    output: true
+    properties:
+      - name: state
+        type: String
+        description: |-
+          The state of the multicast resource.
+          Possible values:
+          CREATING
+          ACTIVE
+          DELETING
+          DELETE_FAILED
+          UPDATING
+          UPDATE_FAILED
+          INACTIVE
+        output: true
   - name: updateTime
     type: String
     description: |-
-      [Output only] The timestamp when the multicast domain was most recently
+      The timestamp when the multicast domain was most recently
       updated.
     output: true

mmv1/third_party/terraform/services/networkservices/resource_network_services_multicast_domain_test.go

@@ -0,0 +1,87 @@
+package networkservices_test
+
+import (
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-plugin-testing/plancheck"
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+	"testing"
+)
+
+func TestAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckNetworkServicesMulticastDomainDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample_full(context),
+			},
+			{
+				ResourceName:            "google_network_services_multicast_domain.md_test",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "location", "multicast_domain_id", "terraform_labels"},
+			},
+			{
+				Config: testAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample_diff(context),
+				ConfigPlanChecks: resource.ConfigPlanChecks{
+					PreApply: []plancheck.PlanCheck{
+						plancheck.ExpectResourceAction("google_network_services_multicast_domain.md_test", plancheck.ResourceActionUpdate),
+					},
+				},
+			},
+			{
+				ResourceName:            "google_network_services_multicast_domain.md_test",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"labels", "location", "multicast_domain_id", "terraform_labels"},
+			},
+		},
+	})
+}
+
+func testAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample_full(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_compute_network" "network" {
+  name                    = "tf-test-test-md-network%{random_suffix}"
+  auto_create_subnetworks = false
+}
+resource "google_network_services_multicast_domain" md_test {
+  multicast_domain_id = "tf-test-test-md-domain%{random_suffix}"
+  location = "global"
+  admin_network = google_compute_network.network.id
+  connection_config  {
+    connection_type="SAME_VPC"
+  }
+  depends_on = [google_compute_network.network]
+}
+`, context)
+}
+
+func testAccNetworkServicesMulticastDomain_networkServicesMulticastDomainUpdateExample_diff(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_compute_network" "network" {
+  name                    = "tf-test-test-md-network%{random_suffix}"
+  auto_create_subnetworks = false
+}
+resource "google_network_services_multicast_domain" md_test {
+  multicast_domain_id = "tf-test-test-md-domain%{random_suffix}"
+  location = "global"
+  description = "A sample domain"
+  labels = {
+    label-one = "value-one"
+  }
+  admin_network = google_compute_network.network.id
+  connection_config  {
+    connection_type="SAME_VPC"
+  }
+  depends_on = [google_compute_network.network]
+}
+`, context)
+}