Added validationConfig to healthcare FHIR store. (#15057)

Author: canuck3141

mmv1/products/healthcare/FhirStore.yaml

@@ -76,6 +76,12 @@ examples:
       dataset_name: 'example-dataset'
       fhir_store_name: 'example-fhir-store'
       pubsub_topic: 'fhir-notifications'
+  - name: 'healthcare_fhir_store_validation_config'
+    primary_resource_id: 'default'
+    vars:
+      dataset_name: 'example-dataset'
+      fhir_store_name: 'example-fhir-store'
+      pubsub_topic: 'fhir-notifications'
 parameters:
   - name: 'dataset'
     type: ResourceRef
@@ -174,6 +180,47 @@ properties:
         output: true
         item_type:
           type: String
+  - name: 'validationConfig'
+    type: NestedObject
+    description: |
+      Configuration for how to validate incoming FHIR resources against configured profiles.
+    properties:
+      - name: 'disableProfileValidation'
+        type: Boolean
+        default_value: false
+        description: |
+          Whether to disable profile validation for this FHIR store. The default value is false. Set this to true to disable checking incoming resources for conformance against structure definitions in this FHIR store.
+      - name: 'enabledImplementationGuides'
+        type: Array
+        description: |
+          A list of implementation guide URLs in this FHIR store that are used to configure the profiles to use for validation.
+          When a URL cannot be resolved (for example, in a type assertion), the server does not return an error.
+          For example, to use the US Core profiles for validation, set enabledImplementationGuides to ["http://hl7.org/fhir/us/core/ImplementationGuide/ig"]. If enabledImplementationGuides is empty or omitted, then incoming resources are only required to conform to the base FHIR profiles. Otherwise, a resource must conform to at least one profile listed in the global property of one of the enabled ImplementationGuides.
+          The Cloud Healthcare API does not currently enforce all of the rules in a StructureDefinition. The following rules are supported:
+          - min/max
+          - minValue/maxValue
+          - maxLength
+          - type
+          - fixed[x]
+          - pattern[x] on simple types
+          - slicing, when using "value" as the discriminator type
+        item_type:
+          type: String
+      - name: 'disableRequiredFieldValidation'
+        type: Boolean
+        default_value: false
+        description: |
+          Whether to disable required fields validation for incoming resources. The default value is false. Set this to true to disable checking incoming resources for conformance against required fields requirement defined in the FHIR specification. This property only affects resource types that do not have profiles configured for them, any rules in enabled implementation guides will still be enforced.
+      - name: 'disableReferenceTypeValidation'
+        type: Boolean
+        default_value: false
+        description: |
+          Whether to disable reference type validation for incoming resources. The default value is false. Set this to true to disable checking incoming resources for conformance against reference type requirement defined in the FHIR specification. This property only affects resource types that do not have profiles configured for them, any rules in enabled implementation guides will still be enforced.
+      - name: 'disableFhirpathValidation'
+        type: Boolean
+        default_value: false
+        description: |
+          Whether to disable FHIRPath validation for incoming resources. The default value is false. Set this to true to disable checking incoming resources for conformance against FHIRPath requirement defined in the FHIR specification. This property only affects resource types that do not have profiles configured for them, any rules in enabled implementation guides will still be enforced.
   - name: 'complexDataTypeReferenceParsing'
     type: Enum
     description: |

mmv1/templates/terraform/examples/healthcare_fhir_store_validation_config.tf.tmpl

@@ -0,0 +1,37 @@
+resource "google_healthcare_fhir_store" "default" {
+  name    = "{{index $.Vars "fhir_store_name"}}"
+  dataset = google_healthcare_dataset.dataset.id
+  version = "R4"
+  complex_data_type_reference_parsing = "DISABLED"
+
+  enable_update_create           = false
+  disable_referential_integrity  = false
+  disable_resource_versioning    = false
+  enable_history_import          = false
+  default_search_handling_strict = false
+
+  notification_configs {
+    pubsub_topic = google_pubsub_topic.topic.id
+  }
+
+  labels = {
+    label1 = "labelvalue1"
+  }
+
+  validation_config {
+    disable_profile_validation = true
+    enabled_implementation_guides = []
+    disable_required_field_validation = true
+    disable_reference_type_validation = true
+    disable_fhirpath_validation = true
+  }
+}
+
+resource "google_pubsub_topic" "topic" {
+  name     = "{{index $.Vars "pubsub_topic"}}"
+}
+
+resource "google_healthcare_dataset" "dataset" {
+  name     = "{{index $.Vars "dataset_name"}}"
+  location = "us-central1"
+}

mmv1/third_party/terraform/services/healthcare/resource_healthcare_fhir_store_test.go.tmpl

@@ -189,6 +189,14 @@ resource "google_healthcare_fhir_store" "default" {
   }
 {{- end }}
 
+  validation_config {
+    disable_profile_validation = true
+    enabled_implementation_guides = ["http://hl7.org/fhir/us/core/ImplementationGuide/ig", "http://example.com/SomeCustomIG"]
+    disable_required_field_validation = true
+    disable_reference_type_validation = true
+    disable_fhirpath_validation = true
+  }
+
   labels = {
     label1 = "labelvalue1"
   }
@@ -247,6 +255,29 @@ func testAccCheckGoogleHealthcareFhirStoreUpdate(t *testing.T, pubsubTopic strin
 			}
 			{{- end }}
 
+			if response.ValidationConfig == nil {
+				return fmt.Errorf("fhirStore 'ValidationConfig' missing: %s", gcpResourceUri)
+			}
+			if !response.ValidationConfig.DisableProfileValidation {
+				return fmt.Errorf("fhirStore 'ValidationConfig.DisableProfileValidation' not updated: %s", gcpResourceUri)
+			}
+			if response.ValidationConfig.EnabledImplementationGuides == nil {
+				return fmt.Errorf("fhirStore 'ValidationConfig.EnabledImplementationGuides' missing: %s", gcpResourceUri)
+			}
+			expectedEnabledImplementationGuides := []string{"http://hl7.org/fhir/us/core/ImplementationGuide/ig", "http://example.com/SomeCustomIG"}
+			if !checkEnabledImplementationGuidesArraysAreEqual(expectedEnabledImplementationGuides, response.ValidationConfig.EnabledImplementationGuides) {
+				return fmt.Errorf("fhirStore 'ValidationConfig.EnabledImplementationGuides' not updated: %s", gcpResourceUri)
+			}
+			if !response.ValidationConfig.DisableRequiredFieldValidation {
+				return fmt.Errorf("fhirStore 'ValidationConfig.DisableRequiredFieldValidation' not updated: %s", gcpResourceUri)
+			}
+			if !response.ValidationConfig.DisableReferenceTypeValidation {
+				return fmt.Errorf("fhirStore 'ValidationConfig.DisableReferenceTypeValidation' not updated: %s", gcpResourceUri)
+			}
+			if !response.ValidationConfig.DisableFhirpathValidation {
+				return fmt.Errorf("fhirStore 'ValidationConfig.DisableFhirpathValidation' not updated: %s", gcpResourceUri)
+			}
+
 			if !response.EnableUpdateCreate {
 				return fmt.Errorf("fhirStore 'EnableUpdateCreate' not updated: %s", gcpResourceUri)
 			}
@@ -277,3 +308,21 @@ func testAccCheckGoogleHealthcareFhirStoreUpdate(t *testing.T, pubsubTopic strin
 		return nil
 	}
 }
+
+// Returns true if the size and contents (order dependent) of enabledImplementationGuides1 and enabledImplementationGuides2 are identical,
+// else false.
+func checkEnabledImplementationGuidesArraysAreEqual(enabledImplementationGuides1 []string, enabledImplementationGuides2 []string) bool {
+	// Same length?
+	if len(enabledImplementationGuides1) != len(enabledImplementationGuides2) {
+		return false
+	}
+
+	// Same contents - do NOT sort to ensure order is identical and avoid permadiff risk
+	for i1, v1 := range enabledImplementationGuides1 {
+		if v1 != enabledImplementationGuides2[i1] {
+			return false
+		}
+	}
+
+	return true
+}