tgc-revival: add google_compute_region_health_check (#15234)

Author: zli82016

mmv1/api/resource.go

@@ -1992,9 +1992,8 @@ func (r Resource) DefineAssetTypeForResourceInProduct() bool {
 	return true
 }
 
-// Gets the Cai asset name template, which could include version
-// For example: //monitoring.googleapis.com/v3/projects/{{project}}/services/{{service_id}}
-func (r Resource) rawCaiAssetNameTemplate(productBackendName string) string {
+// Gets the Cai asset name format
+func (r Resource) GetCaiAssetNameFormat() string {
 	caiBaseUrl := ""
 	caiId := ""
 	if r.CaiIdentity != "" {
@@ -2020,7 +2019,13 @@ func (r Resource) rawCaiAssetNameTemplate(productBackendName string) string {
 			caiBaseUrl = fmt.Sprintf("%s/%s", r.BaseUrl, caiIdTemplate)
 		}
 	}
-	return fmt.Sprintf("//%s.googleapis.com/%s", productBackendName, caiBaseUrl)
+	return caiBaseUrl
+}
+
+// Gets the Cai asset name template, which could include version
+// For example: //monitoring.googleapis.com/v3/projects/{{project}}/services/{{service_id}}
+func (r Resource) rawCaiAssetNameTemplate(productBackendName string) string {
+	return fmt.Sprintf("//%s.googleapis.com/%s", productBackendName, r.GetCaiAssetNameFormat())
 }
 
 // Guesses the identifier of the resource, as "name" is not always the identifier

mmv1/products/compute/RegionHealthCheck.yaml

@@ -52,6 +52,7 @@ custom_code:
   encoder: 'templates/terraform/encoders/health_check_type.tmpl'
 custom_diff:
   - 'healthCheckCustomizeDiff'
+include_in_tgc_next_DO_NOT_USE: true
 sweeper:
   url_substitutions:
     - region: "us-central1"
@@ -117,11 +118,13 @@ examples:
     min_version: 'beta'
     vars:
       health_check_name: 'grpc-with-tls-region-health-check'
+    tgc_skip_test: 'grpcTlsHealthCheck is not in CAI asset, but is required in this test.'
   - name: 'region_health_check_grpc_with_tls_full'
     primary_resource_id: 'grpc-with-tls-region-health-check'
     min_version: 'beta'
     vars:
       health_check_name: 'grpc-with-tls-region-health-check'
+    tgc_skip_test: 'grpcTlsHealthCheck is not in CAI asset, but is required in this test.'
 parameters:
   - name: 'region'
     type: ResourceRef
@@ -878,6 +881,7 @@ properties:
       - 'grpc_health_check'
       - 'grpc_tls_health_check'
     diff_suppress_func: 'portDiffSuppress'
+    is_missing_in_cai: true
     properties:
       - name: 'port'
         type: Integer

mmv1/provider/terraform_tgc_next.go

@@ -23,6 +23,7 @@ import (
 	"os"
 	"path"
 	"path/filepath"
+	"regexp"
 	"strings"
 	"time"
 
@@ -53,10 +54,12 @@ type TerraformGoogleConversionNext struct {
 }
 
 type ResourceIdentifier struct {
-	ServiceName   string
-	TerraformName string
-	ResourceName  string
-	AliasName     string // It can be "Default" or the same with ResourceName
+	ServiceName        string
+	TerraformName      string
+	ResourceName       string
+	AliasName          string // It can be "Default" or the same with ResourceName
+	CaiAssetNameFormat string
+	IdentityParam      string
 }
 
 func NewTerraformGoogleConversionNext(product *api.Product, versionName string, startTime time.Time) TerraformGoogleConversionNext {
@@ -170,6 +173,7 @@ func (tgc TerraformGoogleConversionNext) CompileCommonFiles(outputFolder string,
 
 		// cai2hcl
 		"pkg/cai2hcl/converters/resource_converters.go": "templates/tgc_next/cai2hcl/resource_converters.go.tmpl",
+		"pkg/cai2hcl/converters/convert_resource.go":    "templates/tgc_next/cai2hcl/convert_resource.go.tmpl",
 	}
 
 	templateData := NewTemplateData(outputFolder, tgc.TargetVersionName)
@@ -337,10 +341,11 @@ func (tgc *TerraformGoogleConversionNext) generateResourcesForVersion(products [
 			tgc.ResourceCount++
 
 			resourceIdentifier := ResourceIdentifier{
-				ServiceName:   service,
-				TerraformName: object.TerraformName(),
-				ResourceName:  object.ResourceName(),
-				AliasName:     object.ResourceName(),
+				ServiceName:        service,
+				TerraformName:      object.TerraformName(),
+				ResourceName:       object.ResourceName(),
+				AliasName:          object.ResourceName(),
+				CaiAssetNameFormat: object.GetCaiAssetNameFormat(),
 			}
 			tgc.ResourcesForVersion = append(tgc.ResourcesForVersion, resourceIdentifier)
 
@@ -360,11 +365,77 @@ func (tgc *TerraformGoogleConversionNext) generateResourcesForVersion(products [
 				tgc.ResourcesByCaiResourceType[caiResourceType] = []ResourceIdentifier{resourceIdentifier}
 			}
 		} else {
-			tgc.ResourcesByCaiResourceType[caiResourceType] = resources
+			tgc.ResourcesByCaiResourceType[caiResourceType] = FindIdentityParams(resources)
 		}
 	}
 }
 
+// Analyzes a list of CAI asset names and finds the single path segment
+// (by index) that contains different values across all names.
+// Example:
+// "folders/{{folder}}/feeds/{{feed_id}}" -> folders
+// "organizations/{{org_id}}/feeds/{{feed_id}} -> organizations
+// "projects/{{project}}/feeds/{{feed_id}}" -> projects
+func FindIdentityParams(rids []ResourceIdentifier) []ResourceIdentifier {
+	segmentsList := make([][]string, len(rids))
+	for i, rid := range rids {
+		urlPath := rid.CaiAssetNameFormat
+		urlPath = strings.Trim(urlPath, "/")
+
+		processedURL := regexp.MustCompile(`\{\{%?(\w+)\}\}`).ReplaceAllString(urlPath, "")
+		segments := strings.Split(processedURL, "/")
+		var cleanSegments []string
+		for _, seg := range segments {
+			if seg != "" {
+				cleanSegments = append(cleanSegments, seg)
+			}
+		}
+
+		segmentsList[i] = cleanSegments
+	}
+
+	if len(segmentsList[0]) == 0 {
+		return rids
+	}
+	expectedLength := len(segmentsList[0])
+
+	for i := 1; i < len(segmentsList); i++ {
+		if len(segmentsList[i]) != expectedLength {
+			return rids
+		}
+	}
+
+	varyingIndex := -1
+
+	for i := 0; i < expectedLength; i++ {
+		referenceSegment := segmentsList[0][i]
+		isVarying := false
+
+		for j := 1; j < len(segmentsList); j++ {
+			if segmentsList[j][i] != referenceSegment {
+				isVarying = true
+				break
+			}
+		}
+
+		if isVarying {
+			if varyingIndex != -1 {
+				return rids
+			}
+			varyingIndex = i
+		}
+	}
+
+	if varyingIndex != -1 {
+		for i, segments := range segmentsList {
+			rids[i].IdentityParam = segments[varyingIndex]
+		}
+		return rids
+	}
+
+	return rids
+}
+
 type TgcWithProducts struct {
 	TerraformGoogleConversionNext
 	Compiler string

mmv1/templates/tgc_next/cai2hcl/convert_resource.go.tmpl

@@ -0,0 +1,66 @@
+{{/* The license inside this block applies to this file
+  Copyright 2025 Google LLC. All Rights Reserved.
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License. */ -}}
+package converters
+
+import (
+	"strings"
+
+{{- range $resourceType, $resources := $.ResourcesByCaiResourceType}}
+	{{- if gt (len $resources) 1 }}
+	  "github.com/hashicorp/terraform-provider-google/google/services/{{ (index $resources 0).ServiceName }}"
+	{{- end }}
+{{- end }}
+	"github.com/GoogleCloudPlatform/terraform-google-conversion/v7/pkg/cai2hcl/models"
+	"github.com/GoogleCloudPlatform/terraform-google-conversion/v7/pkg/caiasset"
+)
+
+func ConvertResource(asset caiasset.Asset) ([]*models.TerraformResourceBlock, error) {
+	converters, ok := ConverterMap[asset.Type]
+	if !ok || len(converters) == 0 {
+		return nil, nil
+	}
+
+	var converter models.Cai2hclConverter
+	// Normally, one asset type has only one converter.
+	if len(converters) == 1 {
+		converter = converters["Default"]
+	} else {
+		// Edge cases
+		// Handle the edge case that multiple Terraform resources share the same CAI asset type
+		switch asset.Type {
+{{- range $resourceType, $resources := $.ResourcesByCaiResourceType}}
+	{{- if gt (len $resources) 1 }}
+		case {{ $resourceType }}AssetType:
+		{{- range $i, $object := $resources }}
+			{{- if eq $i 0 }}
+			if strings.Contains(asset.Name, "{{$object.IdentityParam}}") {
+			{{- else }}
+			} else if strings.Contains(asset.Name, "{{$object.IdentityParam}}") {
+			{{- end }}
+				converter = ConverterMap[asset.Type]["{{ $object.AliasName }}"]
+			{{- if eq $i (sub (len $resources) 1)}}
+			}
+			{{- end }}
+		{{- end }}
+	{{- end }}
+{{- end }}
+		}
+	}
+
+	if converter == nil {
+		return nil, nil
+	}
+	return converter.Convert(asset)
+}