Skip to content

Commit 2c2d3ac

Browse files
Fixed instructions for testing docker image changes (#15871)
Co-authored-by: Scott Suarez <[email protected]>
1 parent 632403a commit 2c2d3ac

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

.ci/containers/README.md

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,14 @@ The images are named according to their use. We have a small number of images th
1414
Before you begin, set up Docker (including configuring it to [authenticate with gcloud](https://cloud.google.com/container-registry/docs/advanced-authentication#gcloud-helper)).
1515

1616
1. Make changes to the Dockerfile
17-
2. Build the image with the `testing` tag:
17+
2. Build & push the image with the `testing` tag:
1818
```bash
19-
sudo docker build . --tag gcr.io/graphite-docker-images/bash-plus:testing
19+
gcloud builds submit . \
20+
--tag gcr.io/graphite-docker-images/<target-image>:testing \
21+
--project graphite-docker-images
2022
```
21-
3. Push the image:
22-
```bash
23-
sudo docker push gcr.io/graphite-docker-images/bash-plus:testing
24-
```
25-
4. Update cloudbuild yaml files to reference the image you just pushed by adding the `:testing` suffix
26-
5. Update files that will cause the cloudbuild yaml changes (and therefore your changes) to be exercised
23+
3. Update cloudbuild yaml files to reference the image you just pushed by adding the `:testing` suffix
24+
4. Update files that will cause the cloudbuild yaml changes (and therefore your changes) to be exercised
2725
- Tip: Modifying `mmv1/third_party/terraform/services/compute/metadata.go.tmpl` will trigger builds for TPG, TPGB, and TGC.
28-
6. Create a PR with these changes.
29-
7. Verify that the cloudbuild steps that should use your testing image _are_ using your testing image (in the Execution Details tab for the step.)
26+
5. Create a PR with these changes.
27+
6. Verify that the cloudbuild steps that should use your testing image _are_ using your testing image (in the Execution Details tab for the step.)

0 commit comments

Comments
 (0)