fix: set parameters on correct fields + revoked custom acceptance tests

Author: ramonvermeulen

mmv1/products/iamworkforcepool/WorkforcePool.yaml

@@ -55,16 +55,12 @@ examples:
       workforce_pool_id: 'example-pool'
     test_env_vars:
       org_id: 'ORG_ID'
-    # generated iam_policy tests are bugged because IamImportQualifiersForTest()
-    # does not support 'workforce_pool_id' (see big if/else/break branching)
-    exclude_test: true
   - name: 'iam_workforce_pool_full'
     primary_resource_id: 'example'
     vars:
       workforce_pool_id: 'example-pool'
     test_env_vars:
       org_id: 'ORG_ID'
-    exclude_test: true
 iam_policy:
   parent_resource_attribute: 'workforce_pool_id'
   method_name_separator: ':'
@@ -73,7 +69,6 @@ iam_policy:
     - 'locations/{{location}}/workforcePools/{{workforce_pool_id}}'
     - '{{workforce_pool_id}}'
 parameters:
-properties:
   - name: 'location'
     type: String
     description: The location for the resource.
@@ -91,6 +86,7 @@ properties:
     immutable: true
     validation:
       function: 'ValidateWorkforcePoolId'
+properties:
   - name: 'name'
     type: String
     description: |

mmv1/third_party/terraform/services/iamworkforcepool/iam_iam_workforce_pool_test.go

@@ -1,17 +1,10 @@
 package iamworkforcepool_test
 
 import (
-	"fmt"
-	"strings"
+    "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"testing"
-
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
-	"github.com/hashicorp/terraform-plugin-testing/terraform"
-
 	"github.com/hashicorp/terraform-provider-google/google/acctest"
 	"github.com/hashicorp/terraform-provider-google/google/envvar"
-	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
-	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
 )
 
 func TestAccIAMWorkforcePoolWorkforcePool_full(t *testing.T) {
@@ -80,44 +73,6 @@ func TestAccIAMWorkforcePoolWorkforcePool_minimal(t *testing.T) {
 	})
 }
 
-func testAccCheckIAMWorkforcePoolWorkforcePoolDestroyProducer(t *testing.T) func(s *terraform.State) error {
-	return func(s *terraform.State) error {
-		for name, rs := range s.RootModule().Resources {
-			if rs.Type != "google_iam_workforce_pool" {
-				continue
-			}
-			if strings.HasPrefix(name, "data.") {
-				continue
-			}
-
-			config := acctest.GoogleProviderConfig(t)
-
-			url, err := tpgresource.ReplaceVarsForTest(config, rs, "{{"{{"}}IAMWorkforcePoolBasePath{{"}}"}}locations/{{"{{"}}location{{"}}"}}/workforcePools/{{"{{"}}workforce_pool_id{{"}}"}}")
-			if err != nil {
-				return err
-			}
-
-			res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
-				Config:    config,
-				Method:    "GET",
-				RawURL:    url,
-				UserAgent: config.UserAgent,
-			})
-			if err != nil {
-				return nil
-			}
-
-			if v := res["state"]; v == "DELETED" {
-				return nil
-			}
-
-			return fmt.Errorf("IAMWorkforcePool still exists at %s", url)
-		}
-
-		return nil
-	}
-}
-
 func testAccIAMWorkforcePoolWorkforcePool_full(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_iam_workforce_pool" "my_pool" {