tgc-revival: add monitoring resources (#15507)

Author: zli82016

mmv1/api/resource.go

@@ -2195,6 +2195,28 @@ func (r Resource) GetCaiAssetNameTemplate() string {
 	return fmt.Sprintf("//%s.googleapis.com/%s", r.CaiProductBackendName(r.CaiProductBaseUrl()), r.IdFormat)
 }
 
+// Ignores verifying CAI asset name if it is one computed field
+// For example, the CAI asset name format is //monitoring.googleapis.com/{{name}}
+// for google_monitoring_notification_channel
+func (r Resource) IgnoreCaiAssetName() bool {
+	nameTemplate := r.GetCaiAssetNameTemplate()
+	parts := strings.Split(nameTemplate, "/")
+	if len(parts) > 4 {
+		return false
+	}
+
+	params := r.ExtractIdentifiers(nameTemplate)
+	if len(params) == 1 {
+		param := params[0]
+		for _, p := range r.GettableProperties() {
+			if google.Underscore(p.Name) == param {
+				return p.Output
+			}
+		}
+	}
+	return false
+}
+
 // Gets the Cai API version
 func (r Resource) CaiApiVersion(productBackendName, caiProductBaseUrl string) string {
 	template := r.rawCaiAssetNameTemplate(productBackendName)
@@ -2413,6 +2435,10 @@ func (r Resource) TGCTestIgnorePropertiesToStrings() []string {
 		}
 	}
 
+	if r.IgnoreCaiAssetName() {
+		props = append(props, "ASSETNAME")
+	}
+
 	slices.Sort(props)
 	return props
 }

mmv1/products/monitoring/NotificationChannel.yaml

@@ -48,6 +48,7 @@ timeouts:
   insert_minutes: 20
   update_minutes: 20
   delete_minutes: 20
+include_in_tgc_next_DO_NOT_USE: true
 custom_code:
   constants: 'templates/terraform/constants/monitoring_notification_channel.go.tmpl'
   encoder: 'templates/terraform/encoders/monitoring_notification_channel.go.tmpl'
@@ -56,7 +57,6 @@ custom_code:
 custom_diff:
   - 'sensitiveLabelCustomizeDiff'
 error_retry_predicates:
-
   - 'transport_tpg.IsMonitoringConcurrentEditError'
 examples:
   - name: 'notification_channel_basic'

mmv1/products/monitoring/UptimeCheckConfig.yaml

@@ -34,13 +34,13 @@ timeouts:
   insert_minutes: 20
   update_minutes: 20
   delete_minutes: 20
+include_in_tgc_next_DO_NOT_USE: true
 custom_code:
   encoder: 'templates/terraform/encoders/uptime_check_config.go.tmpl'
   constants: 'templates/terraform/constants/monitoring_uptime_check_config.go.tmpl'
   custom_delete: 'templates/terraform/custom_delete/monitoring_uptime_check_config.go.tmpl'
   custom_import: 'templates/terraform/custom_import/self_link_as_name.tmpl'
 error_retry_predicates:
-
   - 'transport_tpg.IsMonitoringConcurrentEditError'
 examples:
   - name: 'uptime_check_config_http'
@@ -377,6 +377,7 @@ properties:
           all bytes fields JSON representations are base64 encoded. e.g.
           `foo=bar` in URL-encoded form is `foo%3Dbar` and in base64 encoding is
           `Zm9vJTI1M0RiYXI=`.
+        is_missing_in_cai: true
       - name: 'acceptedResponseStatusCodes'
         type: Array
         description:

mmv1/third_party/tgc_next/test/assert_test_files.go

@@ -251,8 +251,10 @@ func testSingleResource(t *testing.T, testName string, testData ResourceTestData
 		if roundtripAsset, ok := roundtripAssetMap[assetType]; !ok {
 			return fmt.Errorf("roundtrip asset for type %s is missing", assetType)
 		} else {
-			if err := compareAssetName(asset.Name, roundtripAsset.Name); err != nil {
-				return err
+			if _, ok := ignoredFieldSet["ASSETNAME"]; !ok {
+				if err := compareAssetName(asset.Name, roundtripAsset.Name); err != nil {
+					return err
+				}
 			}
 			if diff := cmp.Diff(
 				asset.Resource,
@@ -435,7 +437,7 @@ func getRoundtripConfig(t *testing.T, testName string, tfDir string, ancestryCac
 // Converts tf file to CAI assets
 func tfplan2caiConvert(t *testing.T, tfFileName, jsonFileName string, tfDir string, ancestryCache map[string]string, defaultProject string, logger *zap.Logger) ([]caiasset.Asset, error) {
 	// Run terraform init and terraform apply to generate tfplan.json files
-	terraformWorkflow(t, tfDir, tfFileName)
+	terraformWorkflow(t, tfDir, tfFileName, defaultProject)
 
 	planFile := fmt.Sprintf("%s.tfplan.json", tfFileName)
 	planfilePath := filepath.Join(tfDir, planFile)

mmv1/third_party/tgc_next/test/utils.go

@@ -30,30 +30,33 @@ const (
 	defaultProject      = "ci-test-project-nightly-beta"
 )
 
-func terraformWorkflow(t *testing.T, dir, name string) {
-	terraformInit(t, "terraform", dir)
-	terraformPlan(t, "terraform", dir, name+".tfplan")
-	payload := terraformShow(t, "terraform", dir, name+".tfplan")
+func terraformWorkflow(t *testing.T, dir, name, project string) {
+	terraformInit(t, "terraform", dir, project)
+	terraformPlan(t, "terraform", dir, project, name+".tfplan")
+	payload := terraformShow(t, "terraform", dir, project, name+".tfplan")
 	saveFile(t, dir, name+".tfplan.json", payload)
 }
 
-func terraformInit(t *testing.T, executable, dir string) {
-	terraformExec(t, executable, dir, "init", "-input=false")
+func terraformInit(t *testing.T, executable, dir, project string) {
+	terraformExec(t, executable, dir, project, "init", "-input=false")
 }
 
-func terraformPlan(t *testing.T, executable, dir, tfplan string) {
-	terraformExec(t, executable, dir, "plan", "-input=false", "-refresh=false", "-out", tfplan)
+func terraformPlan(t *testing.T, executable, dir, project, tfplan string) {
+	terraformExec(t, executable, dir, project, "plan", "-input=false", "-refresh=false", "-out", tfplan)
 }
 
-func terraformShow(t *testing.T, executable, dir, tfplan string) []byte {
-	return terraformExec(t, executable, dir, "show", "--json", tfplan)
+func terraformShow(t *testing.T, executable, dir, project, tfplan string) []byte {
+	return terraformExec(t, executable, dir, project, "show", "--json", tfplan)
 }
 
-func terraformExec(t *testing.T, executable, dir string, args ...string) []byte {
+func terraformExec(t *testing.T, executable, dir, project string, args ...string) []byte {
+	if project == "" {
+		project = defaultProject
+	}
 	cmd := exec.Command(executable, args...)
 	cmd.Env = []string{
 		"HOME=" + filepath.Join(dir, "fakehome"),
-		"GOOGLE_PROJECT=" + defaultProject,
+		"GOOGLE_PROJECT=" + project,
 		"GOOGLE_FOLDER=" + "",
 		"GOOGLE_ORG=" + defaultOrganization,
 		"GOOGLE_OAUTH_ACCESS_TOKEN=fake-token", // GOOGLE_OAUTH_ACCESS_TOKEN is required so terraform plan does not require the google authentication cert