Add periodic export configuration to Instance.yaml (#15759)

Co-authored-by: Scott Suarez <[email protected]>

Author: efeelaiho

mmv1/products/looker/Instance.yaml

@@ -426,6 +426,58 @@ properties:
           The client secret for the Oauth config.
         required: true
   # Oauth Object - End
+  # Periodic Export Config Object
+  - name: 'periodicExportConfig'
+    type: NestedObject
+    description: |
+      Configuration for periodic export.
+    update_mask_fields:
+      - 'periodic_export_config'
+    properties:
+      - name: 'kmsKey'
+        type: String
+        description: |
+          Name of the CMEK key in KMS.
+          Format:
+          projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}
+        required: true
+      - name: 'gcsUri'
+        type: String
+        description: |
+          Cloud Storage bucket URI for periodic export.
+          Format: gs://{bucket_name}
+        required: true
+      - name: 'startTime'
+        type: NestedObject
+        description: |
+          Time in UTC to start the periodic export job.
+        required: true
+        properties:
+          - name: 'hours'
+            type: Integer
+            description: |
+              Hours of day in 24 hour format. Should be from 0 to 23.
+            validation:
+              function: 'validation.IntBetween(0,23)'
+          - name: 'minutes'
+            type: Integer
+            description: |
+              Minutes of hour of day. Must be from 0 to 59.
+            validation:
+              function: 'validation.IntBetween(0,60)'
+          - name: 'seconds'
+            type: Integer
+            description: |
+              Seconds of minutes of the time. Must normally be from 0 to 59.
+            validation:
+              function: 'validation.IntBetween(0,60)'
+          - name: 'nanos'
+            type: Integer
+            description: |
+              Fractions of seconds in nanoseconds. Must be from 0 to 999,999,999.
+            validation:
+              function: 'validation.IntBetween(0,999999999)'
+  # Periodic Export Config Object - End
   - name: 'platformEdition'
     type: Enum
     description: |

mmv1/third_party/terraform/services/looker/resource_looker_instance_test.go

@@ -127,3 +127,98 @@ resource "google_looker_instance" "test" {
 }
 `, context["random_suffix"])
 }
+
+func TestAccLookerInstance_updatePeriodicExport(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.BootstrapIamMembers(t, []acctest.IamMember{
+		{
+			// For writing/managing the export files in GCS
+			Member: "serviceAccount:service-{project_number}@gcp-sa-looker.iam.gserviceaccount.com",
+			Role:   "roles/storage.objectAdmin",
+		},
+		{
+			// For using the KMS key to encrypt the export (Required for periodic_export_config)
+			Member: "serviceAccount:service-{project_number}@gcp-sa-looker.iam.gserviceaccount.com",
+			Role:   "roles/cloudkms.cryptoKeyEncrypterDecrypter",
+		},
+	})
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccLookerInstance_basic(context),
+			},
+			{
+				ResourceName:            "google_looker_instance.test",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"oauth_config", "region"},
+			},
+			{
+				Config: testAccLookerInstance_periodicExport(context),
+			},
+			{
+				ResourceName:            "google_looker_instance.test",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"oauth_config", "region"},
+			},
+		},
+	})
+}
+
+func testAccLookerInstance_periodicExport(context map[string]interface{}) string {
+	return fmt.Sprintf(`
+resource "google_storage_bucket" "export" {
+  name          = "tf-test-looker-export-%s"
+  location      = "US"
+  force_destroy = true
+}
+
+resource "google_kms_key_ring" "keyring" {
+  name     = "tf-test-looker-keyring-%s"
+  location = "us-west1"
+}
+
+resource "google_kms_crypto_key" "key" {
+  name     = "tf-test-looker-key-%s"
+  key_ring = google_kms_key_ring.keyring.id
+}
+
+resource "google_looker_instance" "test" {
+  name              = "tf-test-looker-%s"
+  platform_edition  = "LOOKER_CORE_ENTERPRISE_ANNUAL"
+  region            = "us-central1"
+  public_ip_enabled = true
+  psc_enabled       = true
+
+  psc_config {
+    allowed_vpcs = []
+  }
+
+  periodic_export_config {
+    gcs_uri = "gs://${google_storage_bucket.export.name}"
+    kms_key = google_kms_crypto_key.key.id
+    
+    start_time {
+      hours   = 12
+      minutes = 30
+      seconds = 0
+      nanos   = 0
+    }
+  }
+
+  oauth_config {
+    client_id     = "my-client-id"
+    client_secret = "my-client-secret"
+  }
+}
+`, context["random_suffix"], context["random_suffix"], context["random_suffix"], context["random_suffix"])
+}