Skip to content

Commit 69880d9

Browse files
authored
Update provider generation to use generic naming for imports (#15008)
1 parent 085498d commit 69880d9

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

mmv1/provider/provider.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ type Provider interface {
1818
const TERRAFORM_PROVIDER_GA = "github.com/hashicorp/terraform-provider-google"
1919
const TERRAFORM_PROVIDER_BETA = "github.com/hashicorp/terraform-provider-google-beta"
2020
const TGC_PROVIDER = "github.com/GoogleCloudPlatform/terraform-google-conversion/v6"
21-
const TERRAFORM_PROVIDER_PRIVATE = "internal/terraform-next"
2221
const RESOURCE_DIRECTORY_GA = "google"
2322
const RESOURCE_DIRECTORY_BETA = "google-beta"
24-
const RESOURCE_DIRECTORY_PRIVATE = "google-private"
2523
const RESOURCE_DIRECTORY_TGC = "pkg"
2624

2725
// # TODO: Review all object interfaces and move to private methods
@@ -40,8 +38,8 @@ func ImportPathFromVersion(v string) string {
4038
tpg = TERRAFORM_PROVIDER_BETA
4139
dir = RESOURCE_DIRECTORY_BETA
4240
default:
43-
tpg = TERRAFORM_PROVIDER_PRIVATE
44-
dir = RESOURCE_DIRECTORY_PRIVATE
41+
tpg = "github.com/hashicorp/terraform-provider-google-" + v
42+
dir = "google-" + v
4543
}
4644
return fmt.Sprintf("%s/%s", tpg, dir)
4745
}

mmv1/provider/terraform.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,8 @@ func (t *Terraform) GenerateIamDocumentation(object api.Resource, templateData T
302302
func (t *Terraform) FolderName() string {
303303
if t.TargetVersionName == "ga" {
304304
return "google"
305-
} else if t.TargetVersionName == "beta" {
306-
return "google-beta"
307305
}
308-
return "google-private"
306+
return "google-" + t.TargetVersionName
309307
}
310308

311309
// Similar to FullResourceName, but override-aware to prevent things like ending in _test.
@@ -732,9 +730,8 @@ func (t Terraform) replaceImportPath(outputFolder, target string) {
732730
tpg = TERRAFORM_PROVIDER_BETA
733731
dir = RESOURCE_DIRECTORY_BETA
734732
default:
735-
tpg = TERRAFORM_PROVIDER_PRIVATE
736-
dir = RESOURCE_DIRECTORY_PRIVATE
737-
733+
tpg = "github.com/hashicorp/terraform-provider-google-" + t.TargetVersionName
734+
dir = "google-" + t.TargetVersionName
738735
}
739736

740737
sourceByte = bytes.Replace(sourceByte, []byte(gaImportPath), []byte(tpg+"/"+dir), -1)
@@ -764,7 +761,7 @@ func (t Terraform) ProviderFromVersion() string {
764761
case "beta":
765762
dir = RESOURCE_DIRECTORY_BETA
766763
default:
767-
dir = RESOURCE_DIRECTORY_PRIVATE
764+
dir = "google-" + t.TargetVersionName
768765
}
769766
return dir
770767
}

0 commit comments

Comments
 (0)