fix the failing TestAccBigqueryDataTransferConfig

Author: wj-chen

mmv1/third_party/terraform/services/bigquerydatatransfer/resource_bigquery_data_transfer_config_test.go

@@ -2,16 +2,15 @@ package bigquerydatatransfer_test
 
 import (
 	"fmt"
-	"strings"
-	"testing"
-	"time"
-
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/hashicorp/terraform-provider-google/google/acctest"
 	"github.com/hashicorp/terraform-provider-google/google/services/bigquerydatatransfer"
 	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
 	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
+	"strings"
+	"testing"
+	"time"
 )
 
 func TestBigqueryDataTransferConfig_resourceBigqueryDTCParamsCustomDiffFuncForceNewWhenGoogleCloudStorage(t *testing.T) {
@@ -641,6 +640,19 @@ resource "google_pubsub_topic" "my_topic" {
   name = "tf-test-my-topic-%s"
 }
 
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.my_dataset.dataset_id
+  table_id   = "my_table"
+  schema     = <<EOF
+  [
+    { "name": "name", "type": "STRING" },
+    { "name": "x", "type": "INTEGER" }
+  ]
+  EOF
+}
+
 resource "google_bigquery_data_transfer_config" "query_config" {
   depends_on = [google_project_iam_member.permissions]
 
@@ -659,7 +671,7 @@ resource "google_bigquery_data_transfer_config" "query_config" {
     enable_failure_email = true
   }
   params = {
-    destination_table_name_template = "my_table"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     write_disposition               = "WRITE_APPEND"
     query                           = "SELECT name FROM tabl WHERE x = '%s'"
   }
@@ -689,6 +701,13 @@ resource "google_bigquery_dataset" "my_dataset" {
   location      = "asia-northeast1"
 }
 
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.my_dataset.dataset_id
+  table_id   = "my_table"
+}
+
 resource "google_bigquery_data_transfer_config" "query_config" {
   depends_on = [google_project_iam_member.data_editor]
 
@@ -699,7 +718,7 @@ resource "google_bigquery_data_transfer_config" "query_config" {
   destination_dataset_id = google_bigquery_dataset.my_dataset.dataset_id
   service_account_name   = google_service_account.bqwriter.email
   params = {
-    destination_table_name_template = "my_table"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     write_disposition               = "WRITE_APPEND"
     query                           = "SELECT 1 AS a"
   }
@@ -721,6 +740,26 @@ resource "google_pubsub_topic" "my_topic" {
   name = "tf-test-my-topic-%s"
 }
 
+resource "google_bigquery_dataset" "my_dataset" {
+  dataset_id    = "my_dataset%s"
+  friendly_name = "foo"
+  description   = "bar"
+  location      = "asia-northeast1"
+}
+
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.my_dataset.dataset_id
+  table_id   = "my_table"
+  schema     = <<EOF
+  [
+    { "name": "name", "type": "STRING" },
+    { "name": "x", "type": "INTEGER" }
+  ]
+  EOF
+}
+
 resource "google_bigquery_data_transfer_config" "query_config" {
   depends_on = [google_project_iam_member.permissions]
 
@@ -738,12 +777,12 @@ resource "google_bigquery_data_transfer_config" "query_config" {
     enable_failure_email = true
   }
   params = {
-    destination_table_name_template = "my_table"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     write_disposition               = "WRITE_APPEND"
     query                           = "SELECT name FROM tabl WHERE x = '%s'"
   }
 }
-`, random_suffix, random_suffix, schedule, start_time, end_time, letter)
+`, random_suffix, random_suffix, random_suffix, schedule, start_time, end_time, letter)
 }
 
 func testAccBigqueryDataTransferConfig_booleanParam(random_suffix string) string {
@@ -844,7 +883,7 @@ resource "google_bigquery_data_transfer_config" "query_config" {
   schedule               = "first sunday of quarter 00:00"
   destination_dataset_id = google_bigquery_dataset.my_dataset.dataset_id
   params = {
-    destination_table_name_template = "my_table"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     write_disposition               = "WRITE_APPEND"
     query                           = "SELECT name FROM table WHERE x = 'y'"
   }
@@ -856,6 +895,19 @@ resource "google_bigquery_dataset" "my_dataset" {
   description   = "bar"
   location      = "us-central1"
 }
+
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.my_dataset.dataset_id
+  table_id   = "my_table"
+  schema     = <<EOF
+  [
+    { "name": "name", "type": "STRING" },
+    { "name": "x", "type": "INTEGER" }
+  ]
+  EOF
+}
 `, random_suffix, random_suffix, random_suffix, random_suffix, random_suffix, random_suffix, random_suffix, random_suffix)
 }
 
@@ -868,6 +920,19 @@ resource "google_bigquery_dataset" "dataset" {
   location         = "US"
 }
 
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.dataset.dataset_id
+  table_id   = "the-table-%s-%s"
+  schema     = <<EOF
+  [
+    { "name": "name", "type": "STRING" },
+    { "name": "x", "type": "INTEGER" }
+  ]
+  EOF
+}
+
 resource "google_bigquery_data_transfer_config" "update_config" {
   display_name           = "tf-test-%s"
   data_source_id         = "google_cloud_storage"
@@ -876,13 +941,13 @@ resource "google_bigquery_data_transfer_config" "update_config" {
 
   params = {
     data_path_template              = "gs://bq-bucket-%s-%s/*.json"
-    destination_table_name_template = "the-table-%s-%s"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     file_format                     = "JSON"
     max_bad_records                 = 0
     write_disposition               = "APPEND"
   }
 }
-`, random_suffix, random_suffix, random_suffix, path, random_suffix, table)
+`, random_suffix, random_suffix, table, random_suffix, random_suffix, path)
 }
 
 func testAccBigqueryDataTransferConfig_scheduledQuery_updateServiceAccount(random_suffix string, service_account string) string {
@@ -907,6 +972,19 @@ resource "google_bigquery_dataset" "my_dataset" {
   location      = "asia-northeast1"
 }
 
+resource "google_bigquery_table" "my_table" {
+  deletion_protection = false
+
+  dataset_id = google_bigquery_dataset.my_dataset.dataset_id
+  table_id   = "my_table"
+  schema     = <<EOF
+  [
+    { "name": "name", "type": "STRING" },
+    { "name": "x", "type": "INTEGER" }
+  ]
+  EOF
+}
+
 resource "google_bigquery_data_transfer_config" "query_config" {
   depends_on = [google_project_iam_member.data_editor]
 
@@ -917,7 +995,7 @@ resource "google_bigquery_data_transfer_config" "query_config" {
   destination_dataset_id = google_bigquery_dataset.my_dataset.dataset_id
   service_account_name   = google_service_account.bqwriter%s.email
   params = {
-    destination_table_name_template = "my_table"
+    destination_table_name_template = google_bigquery_table.my_table.table_id
     write_disposition               = "WRITE_APPEND"
     query                           = "SELECT 1 AS a"
   }