tgc-revival: Add tgc ha vpn gateway, storage pool and privateca resources (#15951)

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: zli82016

mmv1/products/compute/HaVpnGateway.yaml

@@ -41,6 +41,8 @@ async:
     resource_inside_response: false
 collection_url_key: 'items'
 custom_code:
+include_in_tgc_next: true
+tgc_include_handwritten_tests: true
 schema_version: 1
 state_upgraders: true
 examples:

mmv1/products/compute/StoragePool.yaml

@@ -292,3 +292,5 @@ virtual_fields:
       When the field is set to false, deleting the StoragePool is allowed.
 custom_code:
   pre_delete: templates/terraform/pre_delete/compute_storage_pool.go.tmpl
+include_in_tgc_next: true
+tgc_include_handwritten_tests: true

mmv1/products/privateca/CaPool.yaml

@@ -48,6 +48,7 @@ iam_policy:
   iam_conditions_request_type: 'QUERY_PARAM_NESTED'
   example_config_body: 'templates/terraform/iam/example_config_body/privateca_ca_pool.tf.tmpl'
 custom_code:
+  tgc_decoder: 'templates/tgc_next/decoders/privateca_capool.go.tmpl'
 examples:
   - name: 'privateca_capool_basic'
     primary_resource_id: 'default'
@@ -70,6 +71,8 @@ examples:
       my_certificate: 'my-certificate'
     exclude_test: true
     exclude_docs: true
+include_in_tgc_next: true
+tgc_include_handwritten_tests: true
 parameters:
   - name: 'location'
     type: String

mmv1/provider/terraform_tgc_next.go

@@ -245,9 +245,10 @@ func (tgc TerraformGoogleConversionNext) CopyCommonFiles(outputFolder string, ge
 		"pkg/version/version.go":                   "third_party/terraform/version/version.go",
 
 		// services
-		"pkg/services/compute/image.go":     "third_party/terraform/services/compute/image.go",
-		"pkg/services/compute/disk_type.go": "third_party/terraform/services/compute/disk_type.go",
-		"pkg/services/kms/kms_utils.go":     "third_party/terraform/services/kms/kms_utils.go",
+		"pkg/services/compute/image.go":             "third_party/terraform/services/compute/image.go",
+		"pkg/services/compute/disk_type.go":         "third_party/terraform/services/compute/disk_type.go",
+		"pkg/services/kms/kms_utils.go":             "third_party/terraform/services/kms/kms_utils.go",
+		"pkg/services/privateca/privateca_utils.go": "third_party/terraform/services/privateca/privateca_utils.go",
 	}
 	tgc.CopyFileList(outputFolder, resourceConverters)
 }

mmv1/templates/tgc_next/decoders/privateca_capool.go.tmpl

@@ -0,0 +1,20 @@
+	if ip, ok := res["issuancePolicy"]; ok && ip != nil {
+		if ipMap, ok := ip.(map[string]interface{}); ok {
+			if bv, ok := ipMap["baselineValues"]; ok && bv != nil {
+				if bvMap, ok := bv.(map[string]interface{}); ok {
+					if ae, ok := bvMap["additionalExtensions"]; ok && ae != nil {
+						if aeList, ok := ae.([]interface{}); ok {
+							for _, item := range aeList {
+								if itemMap, ok := item.(map[string]interface{}); ok {
+									if _, ok := itemMap["critical"]; !ok {
+										itemMap["critical"] = false
+									}
+								}
+							}
+						}
+					}
+				}
+			}
+		}
+	}
+	return res, hclData, nil

mmv1/third_party/tgc_next/Makefile

@@ -18,7 +18,7 @@ test-integration:
 	go version
 	terraform --version
 	./config-tf-dev-override.sh
-	TF_CLI_CONFIG_FILE="$${PWD}/${TF_CONFIG_FILE}" GO111MODULE=on go test -run=TestAcc $(TESTPATH) $(TESTARGS) -timeout 30m -v ./...
+	TF_CLI_CONFIG_FILE="$${PWD}/${TF_CONFIG_FILE}" GO111MODULE=on go test -run=TestAcc $(TESTPATH) $(TESTARGS) -parallel 8 -timeout 30m -v ./...
 
 mod-clean:
 	git restore go.mod