Vertexai feature online store bigtable (#15963)

Co-authored-by: gomu18 <[email protected]>

Author: piyush123

.gitignore

@@ -65,4 +65,5 @@ tpgtools/serialization.go
 /.ijwb/
 MODULE.bazel.lock
 go.work
-go.work.sum
+go.work.sum
+terraform-provider-google/

mmv1/products/vertexai/FeatureOnlineStore.yaml

@@ -119,6 +119,9 @@ properties:
       - 'bigtable'
       - 'optimized'
     properties:
+      - name: 'enableDirectBigtableAccess'
+        type: Boolean
+        description: 'Optional. If true, enable direct access to the Bigtable instance.'
       - name: 'autoScaling'
         type: NestedObject
         description: Autoscaling config applied to Bigtable Instance.
@@ -139,6 +142,10 @@ properties:
               When a cluster's CPU utilization exceeds the target that you have set,
               Bigtable immediately adds nodes to the cluster. When CPU utilization is substantially lower than the target, Bigtable removes nodes. If not set will default to 50%.
             default_from_api: true
+      - name: 'zone'
+        type: String
+        description: The zone where the Bigtable instance will be created.
+        default_from_api: true
   - name: 'optimized'
     type: NestedObject
     description:
@@ -152,7 +159,7 @@ properties:
       - 'bigtable'
       - 'optimized'
     properties:
- # Meant to be an empty object with no properties - see here : https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/projects.locations.featureOnlineStores#Optimized
+  # Meant to be an empty object with no properties - see here : https://cloud.google.com/vertex-ai/docs/reference/rest/v1beta1/projects.locations.featureOnlineStores#Optimized
       []
   - name: 'dedicatedServingEndpoint'
     type: NestedObject
@@ -201,3 +208,13 @@ properties:
         description: |
           Enable embedding management.
         immutable: true
+  - name: 'encryptionSpec'
+    type: NestedObject
+    description: |
+      If set, both of the online and offline data storage will be secured by this key.
+    properties:
+      - name: 'kmsKeyName'
+        type: String
+        description: |
+          The Cloud KMS resource identifier of the customer managed encryption key used to protect a resource. Has the form: projects/my-project/locations/my-region/keyRings/my-kr/cryptoKeys/my-key. The key needs to be in the same region as where the compute resource is created.
+        required: true

mmv1/third_party/terraform/services/vertexai/resource_vertex_ai_feature_online_store_test.go

@@ -83,3 +83,97 @@ resource google_vertex_ai_feature_online_store "feature_online_store" {
 }
 `, context)
 }
+
+func TestAccVertexAIFeatureOnlineStore_bigtable_full(t *testing.T) {
+	t.Parallel()
+
+	kms := acctest.BootstrapKMSKeyInLocation(t, "us-central1")
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+		"kms_key_name":  kms.CryptoKey.Name,
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckVertexAIFeatureOnlineStoreDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccVertexAIFeatureOnlineStore_bigtable_full(context),
+			},
+			{
+				ResourceName:            "google_vertex_ai_feature_online_store.feature_online_store",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"name", "etag", "region", "force_destroy", "labels", "terraform_labels"},
+			},
+		},
+	})
+}
+
+func testAccVertexAIFeatureOnlineStore_bigtable_full(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource google_vertex_ai_feature_online_store "feature_online_store" {
+    name = "tf_test_feature_online_store%{random_suffix}"
+    region = "us-central1"
+
+    bigtable {
+        auto_scaling {
+            min_node_count = 1
+            max_node_count = 2
+        }
+        enable_direct_bigtable_access = true
+        zone = "us-central1-a"
+    }
+    encryption_spec {
+        kms_key_name = "%{kms_key_name}"
+    }
+    force_destroy = true
+}
+`, context)
+}
+
+func TestAccVertexAIFeatureOnlineStore_bigtable_with_zone(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckVertexAIFeatureOnlineStoreDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccVertexAIFeatureOnlineStore_bigtable_with_zone(context),
+			},
+			{
+				ResourceName:            "google_vertex_ai_feature_online_store.feature_online_store",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"name", "etag", "region", "force_destroy", "labels", "terraform_labels"},
+			},
+		},
+	})
+}
+
+func testAccVertexAIFeatureOnlineStore_bigtable_with_zone(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource google_vertex_ai_feature_online_store "feature_online_store" {
+    name = "tf_test_feature_online_store%{random_suffix}"
+    region = "us-central1"
+
+    bigtable {
+        auto_scaling {
+            min_node_count = 1
+            max_node_count = 2
+            cpu_utilization_target = 60
+        }
+        zone = "us-central1-a"
+    }
+  force_destroy = true
+}
+`, context)
+}