Skip to content

Commit 82fa989

Browse files
authored
Add the Resourcemanager Capability Service to the google provider. (#15148)
1 parent ee4d5e0 commit 82fa989

File tree

4 files changed

+8
-18
lines changed

4 files changed

+8
-18
lines changed

mmv1/products/resourcemanager3/Capability.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ references:
2121
guides:
2222
'Official Documentation': 'https://cloud.google.com/resource-manager/docs/manage-applications'
2323
api: 'https://cloud.google.com/resource-manager/reference/rest'
24-
min_version: beta
2524

2625
import_format:
2726
- '{{parent}}/capabilities/{{capability_name}}'
@@ -54,7 +53,6 @@ examples:
5453
display_name: 'my-folder'
5554
test_env_vars:
5655
org_id: "ORG_ID"
57-
min_version: beta
5856
external_providers: ["time"]
5957

6058
parameters:

mmv1/products/resourcemanager3/product.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ name: 'ResourceManager3'
1616
legacy_name: 'resource_manager'
1717
display_name: 'Resource Manager'
1818
versions:
19-
- name: 'beta'
19+
- name: 'ga'
2020
base_url: 'https://cloudresourcemanager.googleapis.com/v3/'
2121
scopes:
2222
- 'https://www.googleapis.com/auth/cloud-platform'

mmv1/templates/terraform/examples/resource_manager_capability.tf.tmpl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
resource "google_folder" "folder" {
2-
provider = google-beta
32
display_name = "{{index $.Vars "display_name"}}"
43
parent = "organizations/{{index $.TestEnvVars "org_id"}}"
54
deletion_protection = false
@@ -9,7 +8,6 @@ resource "time_sleep" "wait_60s" {
98
create_duration = "60s"
109
}
1110
resource "google_resource_manager_capability" "{{$.PrimaryResourceId}}" {
12-
provider = google-beta
1311
value = true
1412
parent = "${google_folder.folder.name}"
1513
capability_name = "app-management"

mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go.tmpl renamed to mmv1/third_party/terraform/services/resourcemanager3/resource_resource_manager_capability_test.go

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
package resourcemanager3_test
2-
{{- if ne $.TargetVersionName "ga" }}
32

43
import (
5-
"testing"
64
"regexp"
5+
"testing"
76

87
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
98

@@ -15,14 +14,14 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t *
1514
t.Parallel()
1615

1716
context := map[string]interface{}{
18-
"org_id": envvar.GetTestOrgFromEnv(t),
17+
"org_id": envvar.GetTestOrgFromEnv(t),
1918
"random_suffix": acctest.RandString(t, 10),
2019
}
2120
folderTFResourceName := "google_folder.folder"
2221

2322
acctest.VcrTest(t, resource.TestCase{
2423
PreCheck: func() { acctest.AccTestPreCheck(t) },
25-
ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
24+
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
2625
ExternalProviders: map[string]resource.ExternalProvider{
2726
"time": {},
2827
},
@@ -41,9 +40,9 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t *
4140
),
4241
},
4342
{
44-
ResourceName: "google_resource_manager_capability.capability",
45-
ImportState: true,
46-
ImportStateVerify: true,
43+
ResourceName: "google_resource_manager_capability.capability",
44+
ImportState: true,
45+
ImportStateVerify: true,
4746
ImportStateVerifyIgnore: []string{"capability_name", "parent"},
4847
},
4948
},
@@ -53,7 +52,6 @@ func TestAccResourceManagerCapability_resourceManagerCapabilityExample_basic(t *
5352
func testAccResourceManagerCapability_resourceManagerCapabilityExample_basic(context map[string]interface{}) string {
5453
return acctest.Nprintf(`
5554
resource "google_folder" "folder" {
56-
provider = google-beta
5755
display_name = "my-folder%{random_suffix}"
5856
parent = "organizations/%{org_id}"
5957
deletion_protection = false
@@ -63,14 +61,10 @@ resource "time_sleep" "wait_60s" {
6361
create_duration = "60s"
6462
}
6563
resource "google_resource_manager_capability" "capability" {
66-
provider = google-beta
6764
value = true
6865
parent = "${google_folder.folder.name}"
6966
capability_name = "app-management"
70-
depends_on = [time_sleep.wait_60s]
67+
depends_on = [time_sleep.wait_60s, google_folder.folder]
7168
}
7269
`, context)
7370
}
74-
{{- else }}
75-
// Capability is only in beta version.
76-
{{- end }}

0 commit comments

Comments
 (0)