Skip to content

Commit 84bceb8

Browse files
authored
Fix leaky Cloud SQL test networks (#15424)
1 parent 6530f8b commit 84bceb8

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go.tmpl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1191,9 +1191,9 @@ func TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUri_thenRemo
11911191
instanceName := "tf-test-" + random_suffix
11921192
projectId := envvar.GetTestProjectFromEnv()
11931193
region := "us-central1"
1194-
networkNameStr := "tf-test-cloud-sql-network-" + random_suffix
1195-
subnetworkNameStr := "tf-test-cloud-sql-subnetwork-" + random_suffix
1196-
networkAttachmentNameStr := "tf-test-cloud-sql-update-na-" + random_suffix
1194+
networkNameStr := "tf-test-cloud-sql-network-psc-1"
1195+
subnetworkNameStr := "tf-test-cloud-sql-subnetwork-psc-1"
1196+
networkAttachmentNameStr := "tf-test-cloud-sql-update-na-psc-1"
11971197
networkName := acctest.BootstrapSharedTestNetwork(t, networkNameStr)
11981198
subnetworkName := acctest.BootstrapSubnet(t, subnetworkNameStr, networkName)
11991199
networkAttachmentName := acctest.BootstrapNetworkAttachment(t, networkAttachmentNameStr, subnetworkName)
@@ -1242,9 +1242,9 @@ func TestAccSqlDatabaseInstance_withPscEnabled_withNetworkAttachmentUriOnCreate(
12421242
instanceName := "tf-test-" + random_suffix
12431243
projectId := envvar.GetTestProjectFromEnv()
12441244
region := "us-central1"
1245-
networkNameStr := "tf-test-cloud-sql-network-" + random_suffix
1246-
subnetworkNameStr := "tf-test-cloud-sql-subnetwork-" + random_suffix
1247-
networkAttachmentNameStr := "tf-test-cloud-sql-update-na-" + random_suffix
1245+
networkNameStr := "tf-test-cloud-sql-network-psc-2"
1246+
subnetworkNameStr := "tf-test-cloud-sql-subnetwork-psc-2"
1247+
networkAttachmentNameStr := "tf-test-cloud-sql-update-na-psc-2"
12481248
networkName := acctest.BootstrapSharedTestNetwork(t, networkNameStr)
12491249
subnetworkName := acctest.BootstrapSubnet(t, subnetworkNameStr, networkName)
12501250
networkAttachmentName := acctest.BootstrapNetworkAttachment(t, networkAttachmentNameStr, subnetworkName)

0 commit comments

Comments
 (0)