Remove bad zeroing of SQL DataDiskSizeGb (#15449)

rileykarson · web-flow · commit 8961bed6c2d8 · 2025-10-22T19:16:36.000Z
diff --git a/mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl b/mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.tmpl
@@ -2508,8 +2508,6 @@ func resourceSqlDatabaseInstanceUpdate(d *schema.ResourceData, meta interface{})
 		Settings: expandSqlDatabaseInstanceSettings(desiredSetting.([]interface{}), databaseVersion),
 	}
 
-	// If there is no change detected in disk size, no need to try and update the disk size, send 0 always
-	instance.Settings.DataDiskSizeGb = 0
 	if d.HasChange("settings.0.disk_size") {
 		autoResize := true
 		_, autoResizeI := d.GetChange("settings.0.disk_autoresize")

Original file line number	Diff line number	Diff line change
`@@ -2508,8 +2508,6 @@ func resourceSqlDatabaseInstanceUpdate(d *schema.ResourceData, meta interface{})`
`2508`	`2508`	`Settings: expandSqlDatabaseInstanceSettings(desiredSetting.([]interface{}), databaseVersion),`
`2509`	`2509`	`}`
`2510`	`2510`
`2511`		`- // If there is no change detected in disk size, no need to try and update the disk size, send 0 always`
`2512`		`- instance.Settings.DataDiskSizeGb = 0`
`2513`	`2511`	`if d.HasChange("settings.0.disk_size") {`
`2514`	`2512`	`autoResize := true`
`2515`	`2513`	`_, autoResizeI := d.GetChange("settings.0.disk_autoresize")`