fix TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy in VCR (#15962)

Author: shuyama1

mmv1/third_party/terraform/services/compute/resource_compute_region_backend_service_test.go.tmpl

@@ -2255,64 +2255,64 @@ resource "google_compute_health_check" "zero" {
 func TestAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(t *testing.T) {
 	t.Parallel()
 
-	namePrefix := fmt.Sprintf("tf-test-%s", acctest.RandString(t, 10))
+	randString := acctest.RandString(t, 10)
 
 	acctest.VcrTest(t, resource.TestCase{
 		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
 		ProtoV5ProviderFactories: acctest.ProtoV5ProviderBetaFactories(t),
 		CheckDestroy:             testAccCheckComputeRegionBackendServiceDestroyProducer(t),
 		Steps: []resource.TestStep{
 			{
-				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(namePrefix, "ZONAL_AFFINITY_DISABLED", 0.5),
+				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(randString, "ZONAL_AFFINITY_DISABLED", 0.5),
 			},
 			{
 				ResourceName:      "google_compute_region_backend_service.nptlbtp",
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
 			{
-				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(namePrefix, "ZONAL_AFFINITY_SPILL_CROSS_ZONE", 0.6),
+				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(randString, "ZONAL_AFFINITY_SPILL_CROSS_ZONE", 0.6),
 			},
 			{
 				ResourceName:      "google_compute_region_backend_service.nptlbtp",
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
 			{
-				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(namePrefix, "ZONAL_AFFINITY_STAY_WITHIN_ZONE", 0.2),
+				Config: testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(randString, "ZONAL_AFFINITY_STAY_WITHIN_ZONE", 0.2),
 			},
 			{
 				ResourceName:      "google_compute_region_backend_service.nptlbtp",
 				ImportState:       true,
 				ImportStateVerify: true,
 			},
 			{
-				Config:      testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(namePrefix, "ZONAL_AFFINITY_STAY_WITHIN_ZONE", 1.001),
+				Config:      testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(randString, "ZONAL_AFFINITY_STAY_WITHIN_ZONE", 1.001),
 				ExpectError: regexp.MustCompile("Must be less than or equal to 1.0"),
 			},
 		},
 	})
 }
 
-func testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(namePrefix, spillover string, ratio float64) string {
+func testAccComputeRegionBackendService_withNetworkPassThroughLbTrafficPolicy(randString, spillover string, ratio float64) string {
 	return fmt.Sprintf(`
 resource "google_compute_network" "default" {
   provider                = google-beta
-  name                    = "%s-network"
+  name                    = "tf-test-network-%s"
   auto_create_subnetworks = false
 }
 
 resource "google_compute_subnetwork" "default" {
   provider      = google-beta
-  name          = "%s-subnet"
+  name          = "tf-test-subnet-%s"
   ip_cidr_range = "10.10.0.0/16"
   region        = "us-central1"
   network       = google_compute_network.default.id
 }
 
 resource "google_compute_region_health_check" "default" {
   provider = google-beta
-  name     = "%s-health-check"
+  name     = "tf-test-health-check-%s"
   region   = "us-central1"
   tcp_health_check {
     port         = 80
@@ -2321,7 +2321,7 @@ resource "google_compute_region_health_check" "default" {
 
 resource "google_compute_instance_template" "default" {
   provider     = google-beta
-  name_prefix  = "%s-instance-template"
+  name  = "tf-test-instance-template-%s"
   machine_type = "e2-micro"
 
   disk {
@@ -2337,19 +2337,19 @@ resource "google_compute_instance_template" "default" {
 
 resource "google_compute_instance_group_manager" "default" {
   provider = google-beta
-  name     = "%s-igm"
+  name     = "tf-test-igm-%s"
   zone     = "us-central1-a"
   version {
     instance_template  = google_compute_instance_template.default.id
     name               = "primary"
   }
-  base_instance_name = "%s-instance"
+  base_instance_name = "tf-test-instance-%s"
   target_size        = 1
 }
 
 resource "google_compute_region_backend_service" "nptlbtp" {
   provider              = google-beta
-  name                  = "%s-region-backend-service"
+  name                  = "tf-test-region-backend-service-%s"
   region                = "us-central1"
   load_balancing_scheme = "INTERNAL"
   health_checks         = [google_compute_region_health_check.default.id]
@@ -2367,6 +2367,6 @@ resource "google_compute_region_backend_service" "nptlbtp" {
     }
   }
 }
-`, namePrefix, namePrefix, namePrefix, namePrefix, namePrefix, namePrefix, namePrefix, spillover, ratio)
+`, randString, randString, randString, randString, randString, randString, randString, spillover, ratio)
 }
 {{- end }}