Skip to content

Commit b117259

Browse files
authored
Fix TestAccDataSourceGoogleGkeHubFeature_basic (#15789)
1 parent b446df3 commit b117259

File tree

2 files changed

+135
-177
lines changed

2 files changed

+135
-177
lines changed

mmv1/third_party/terraform/services/gkehub2/data_source_google_gke_hub_feature_test.go

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
99
"github.com/hashicorp/terraform-plugin-testing/terraform"
1010
"github.com/hashicorp/terraform-provider-google/google/acctest"
11+
"github.com/hashicorp/terraform-provider-google/google/envvar"
1112
"github.com/hashicorp/terraform-provider-google/google/tpgresource"
1213
transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
1314
)
@@ -16,13 +17,18 @@ func TestAccDataSourceGoogleGkeHubFeature_basic(t *testing.T) {
1617
t.Parallel()
1718

1819
context := map[string]interface{}{
19-
"random_suffix": acctest.RandString(t, 10),
20+
"random_suffix": acctest.RandString(t, 10),
21+
"org_id": envvar.GetTestOrgFromEnv(t),
22+
"billing_account": envvar.GetTestBillingAccountFromEnv(t),
2023
}
2124

2225
acctest.VcrTest(t, resource.TestCase{
2326
PreCheck: func() { acctest.AccTestPreCheck(t) },
2427
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
25-
CheckDestroy: testAccCheckGoogleGkeHubFeatureDestroyProducer(t),
28+
ExternalProviders: map[string]resource.ExternalProvider{
29+
"time": {},
30+
},
31+
CheckDestroy: testAccCheckGoogleGkeHubFeatureDestroyProducer(t),
2632
Steps: []resource.TestStep{
2733
{
2834
Config: testAccDataSourceGoogleGkeHubFeature_basic(context),
@@ -35,15 +41,18 @@ func TestAccDataSourceGoogleGkeHubFeature_basic(t *testing.T) {
3541
}
3642

3743
func testAccDataSourceGoogleGkeHubFeature_basic(context map[string]interface{}) string {
38-
return acctest.Nprintf(`
44+
return gkeHubFeatureProjectSetupForGA(context) + acctest.Nprintf(`
3945
resource "google_gke_hub_feature" "example" {
40-
location = "global"
41-
name = "servicemesh"
46+
location = "global"
47+
name = "servicemesh"
48+
depends_on = [time_sleep.wait_for_gkehub_enablement]
49+
project = google_project.project.project_id
4250
}
4351
4452
data "google_gke_hub_feature" "example" {
4553
location = google_gke_hub_feature.example.location
4654
name = google_gke_hub_feature.example.name
55+
project = google_project.project.project_id
4756
}
4857
`, context)
4958
}

0 commit comments

Comments
 (0)