Skip to content

Commit c814bf3

Browse files
authored
fix WASM Plugins test config and skip tests (#15245)
1 parent bac5d71 commit c814bf3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

mmv1/products/networkservices/WasmPlugin.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ examples:
4747
wasm_plugin_name: 'my-wasm-plugin'
4848
plugin_package_name: 'my-wasm-plugin-data'
4949
repository_name: 'my-artifact-registry-docker-repository'
50-
skip_vcr: true
50+
skip_test: https://github.com/GoogleCloudPlatform/magic-modules/pull/12275#discussion_r2283175770
5151
- name: 'wasm_plugin_basic_generic_repository'
5252
primary_resource_id: 'wasm_plugin'
5353
vars:
5454
wasm_plugin_name: 'my-wasm-plugin'
5555
plugin_package_name: 'my-wasm-plugin-data'
5656
repository_name: 'my-artifact-registry-generic-repository'
57-
skip_vcr: true
57+
skip_test: https://github.com/GoogleCloudPlatform/magic-modules/pull/12275#discussion_r2283175770
5858
parameters:
5959
- name: 'location'
6060
type: String

mmv1/templates/terraform/examples/wasm_plugin_basic_docker_repository.tf.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ resource "google_network_services_wasm_plugin" "{{$.PrimaryResourceId}}" {
1818
versions {
1919
version_name = "v1"
2020
description = "v1 version of my wasm plugin"
21-
image_uri = "us-central1-docker.pkg.dev/${data.google_project.project.name}/{index $.Vars "repository_name"}/{index $.Vars "plugin_package_name"}:prod"
21+
image_uri = "us-central1-docker.pkg.dev/${data.google_project.project.name}/{{index $.Vars "repository_name"}}/{{index $.Vars "plugin_package_name"}}:prod"
2222

2323
labels = {
2424
test_label = "test_value"

mmv1/templates/terraform/examples/wasm_plugin_basic_generic_repository.tf.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ resource "google_network_services_wasm_plugin" "{{$.PrimaryResourceId}}" {
1818
versions {
1919
version_name = "v1"
2020
description = "v1 version of my wasm plugin"
21-
image_uri = "projects/${data.google_project.project.name}/locations/us-central1/repositories/{index $.Vars "repository_name"}/genericArtifacts/{index $.Vars "plugin_package_name"}:v1"
21+
image_uri = "projects/${data.google_project.project.name}/locations/us-central1/repositories/{{index $.Vars "repository_name"}}/genericArtifacts/{{index $.Vars "plugin_package_name"}}:v1"
2222

2323
labels = {
2424
test_label = "test_value"

0 commit comments

Comments
 (0)