Display nat ip (#15675)

Co-authored-by: Nick Elliot <[email protected]>

Author: chauhankomal

mmv1/products/compute/ServiceAttachment.yaml

@@ -39,6 +39,7 @@ custom_code:
   constants: 'templates/terraform/constants/compute_service_attachment.go.tmpl'
   update_encoder: 'templates/terraform/update_encoder/compute_service_attachment.go.tmpl'
   encoder: 'templates/terraform/encoders/compute_service_attachment.go.tmpl'
+  pre_read: 'templates/terraform/pre_read/service_attachment_show_nat_ips.go.tmpl'
 sweeper:
   url_substitutions:
     - region: "us-west2"
@@ -160,6 +161,11 @@ properties:
         description: |
           The low 64 bits of the PSC service attachment ID.
         output: true
+  - name: 'showNatIps'
+    type: Boolean
+    description: |
+      If true, show NAT IPs of all connected endpoints.
+    url_param_only: true
   - name: 'connectionPreference'
     type: String
     description: |
@@ -201,6 +207,12 @@ properties:
           description: |
             The number of consumer Network Connectivity Center spokes that the connected Private Service Connect endpoint has propagated to.
           output: true
+        - name: 'natIps'
+          type: Array
+          description: 'The nat IPs of the connected endpoint.'
+          output: true
+          item_type:
+            type: String
   - name: 'targetService'
     type: String
     description: |

mmv1/templates/terraform/pre_read/service_attachment_show_nat_ips.go.tmpl

@@ -0,0 +1,4 @@
+if d.Get("show_nat_ips").(bool) {
+  url += "?showNatIps=true"
+}
+

mmv1/third_party/terraform/services/compute/resource_compute_service_attachment_test.go

@@ -513,3 +513,134 @@ resource "google_network_services_gateway" "default" {
 }
 `, context)
 }
+
+func TestAccComputeServiceAttachment_withNatIps(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeServiceAttachmentDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+
+				Config: testAccComputeServiceAttachment_withNatIps(context, false),
+			},
+			{
+				Config: testAccComputeServiceAttachment_withNatIps(context, true),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet(
+						"google_compute_service_attachment.psc_ilb_service_attachment", "connected_endpoints.0.nat_ips.0"),
+				),
+			},
+			{
+				ResourceName:            "google_compute_service_attachment.psc_ilb_service_attachment",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"target_service", "region", "show_nat_ips", "connected_endpoints.0.nat_ips"},
+			},
+			{
+				Config: testAccComputeServiceAttachment_withNatIps(context, false),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("google_compute_service_attachment.psc_ilb_service_attachment", "show_nat_ips", "false"),
+					resource.TestCheckResourceAttr("google_compute_service_attachment.psc_ilb_service_attachment", "connected_endpoints.0.nat_ips.#", "0"),
+				),
+			},
+		},
+	})
+}
+
+func testAccComputeServiceAttachment_withNatIps(context map[string]interface{}, showNatIps bool) string {
+	context["show_nat_ips"] = showNatIps
+	return acctest.Nprintf(`
+resource "google_compute_service_attachment" "psc_ilb_service_attachment" {
+  name                  = "tf-test-my-psc-ilb%{random_suffix}"
+  region                = "us-west2"
+  description           = "A service attachment configured with Terraform"
+  enable_proxy_protocol = false
+  connection_preference = "ACCEPT_AUTOMATIC"
+  show_nat_ips          = %{show_nat_ips}
+  nat_subnets           = [google_compute_subnetwork.psc_ilb_nat.id]
+  target_service        = google_compute_forwarding_rule.psc_ilb_target_service.id
+}
+
+resource "google_compute_address" "psc_ilb_consumer_address" {
+  name         = "tf-test-psc-ilb-consumer-address%{random_suffix}"
+  region       = "us-west2"
+  subnetwork   = google_compute_subnetwork.psc_ilb_consumer_subnetwork.id
+  address_type = "INTERNAL"
+}
+
+resource "google_compute_forwarding_rule" "psc_ilb_consumer" {
+  name                  = "tf-test-psc-ilb-consumer-forwarding-rule%{random_suffix}"
+  region                = "us-west2"
+  target                = google_compute_service_attachment.psc_ilb_service_attachment.id
+  load_balancing_scheme = ""
+  network               = google_compute_network.consumer_network.name
+  ip_address            = google_compute_address.psc_ilb_consumer_address.id
+}
+
+resource "google_compute_forwarding_rule" "psc_ilb_target_service" {
+  name                  = "tf-test-producer-forwarding-rule%{random_suffix}"
+  region                = "us-west2"
+  load_balancing_scheme = "INTERNAL"
+  backend_service       = google_compute_region_backend_service.producer_service_backend.id
+  all_ports             = true
+  network               = google_compute_network.producer_network.name
+  subnetwork            = google_compute_subnetwork.psc_ilb_producer_subnetwork.name
+}
+
+resource "google_compute_region_backend_service" "producer_service_backend" {
+  name          = "tf-test-producer-service%{random_suffix}"
+  region        = "us-west2"
+  health_checks = [google_compute_health_check.producer_service_health_check.id]
+}
+
+resource "google_compute_health_check" "producer_service_health_check" {
+  name               = "tf-test-producer-service-health-check%{random_suffix}"
+  check_interval_sec = 1
+  timeout_sec        = 1
+  tcp_health_check {
+    port = "80"
+  }
+}
+
+resource "google_compute_network" "producer_network" {
+  name                    = "tf-test-psc-ilb-producer-network%{random_suffix}"
+  auto_create_subnetworks = false
+  delete_default_routes_on_create = true
+}
+
+resource "google_compute_network" "consumer_network" {
+  name                    = "tf-test-psc-ilb-consumer-network%{random_suffix}"
+  auto_create_subnetworks = false
+  delete_default_routes_on_create = true
+}
+
+resource "google_compute_subnetwork" "psc_ilb_producer_subnetwork" {
+  name          = "tf-test-psc-ilb-producer-subnetwork%{random_suffix}"
+  region        = "us-west2"
+  network       = google_compute_network.producer_network.id
+  ip_cidr_range = "10.0.0.0/16"
+}
+
+resource "google_compute_subnetwork" "psc_ilb_consumer_subnetwork" {
+  name          = "tf-test-psc-ilb-consumer-subnetwork%{random_suffix}"
+  region        = "us-west2"
+  network       = google_compute_network.consumer_network.id
+  ip_cidr_range = "10.2.0.0/16"
+}
+
+resource "google_compute_subnetwork" "psc_ilb_nat" {
+  name          = "tf-test-psc-ilb-nat%{random_suffix}"
+  region        = "us-west2"
+  network       = google_compute_network.producer_network.id
+  purpose       = "PRIVATE_SERVICE_CONNECT"
+  ip_cidr_range = "10.1.0.0/16"
+}
+`, context)
+}