osconfig: fix permadiff where patch_config.yum.minimal doesn't send false for empty values (#15046)

Author: ramonvermeulen

mmv1/products/osconfig/PatchDeployment.yaml

@@ -254,6 +254,7 @@ properties:
               - 'patch_config.0.yum.0.excludes'
               - 'patch_config.0.yum.0.exclusive_packages'
           - name: 'minimal'
+            send_empty_value: true
             type: Boolean
             description: |
               Will cause patch to run yum update-minimal instead.

mmv1/templates/terraform/decoders/os_config_patch_deployment.go.tmpl

@@ -4,6 +4,14 @@ if  res["patchConfig"] != nil {
 		patchConfig["goo"].(map[string]interface{})["enabled"] = true
 		res["patchConfig"] = patchConfig
 	}
+
+    if patchConfig["yum"] != nil {
+        patchConfigYum := patchConfig["yum"].(map[string]interface{})
+        if _, ok := patchConfigYum["minimal"]; !ok {
+            patchConfigYum["minimal"] = false
+        }
+        patchConfig["yum"] = patchConfigYum
+    }
 }
 
 return res, nil

mmv1/third_party/terraform/services/osconfig/resource_os_config_patch_deployment_test.go

@@ -0,0 +1,58 @@
+package osconfig_test
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+)
+
+func TestAccOSConfigPatchDeployment_osConfigPatchDeployment_yum_basic(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckOSConfigPatchDeploymentDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccOSConfigPatchDeployment_osConfigPatchDeployment_yum_basic(context),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("google_os_config_patch_deployment.patch", "patch_config.0.yum.0.minimal", "false"),
+				),
+			},
+			{
+				ResourceName:            "google_os_config_patch_deployment.patch",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"patch_deployment_id"},
+			},
+		},
+	})
+}
+
+func testAccOSConfigPatchDeployment_osConfigPatchDeployment_yum_basic(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_os_config_patch_deployment" "patch" {
+  patch_deployment_id = "tf-test-patch-deploy%{random_suffix}"
+
+  instance_filter {
+    all = true
+  }
+
+  patch_config {
+    yum {
+      minimal = false
+    }
+  }
+
+  one_time_schedule {
+    execute_time = "2999-10-10T10:10:10.045123456Z"
+  }
+}
+`, context)
+}