tgc-revival: ignore tags and sensitive properties in tests (#15236)

zli82016 · web-flow · commit d03cc1979870 · 2025-09-25T21:05:42.000Z
diff --git a/mmv1/api/resource.go b/mmv1/api/resource.go
@@ -2202,6 +2202,11 @@ func (r Resource) TGCTestIgnorePropertiesToStrings(e resource.Examples) []string
 			props = append(props, google.Underscore(tp.Name))
 		} else if tp.IsMissingInCai {
 			props = append(props, tp.MetadataLineage())
+		} else if tp.IgnoreRead {
+			if tp.Sensitive || tp.Name == "tags" {
+				// TODO: handle tags conversion, which are separate Cai assets with resources.
+				props = append(props, tp.MetadataLineage())
+			}
 		}
 	}
 	props = append(props, e.TGCTestIgnoreExtra...)

Original file line number	Diff line number	Diff line change
`@@ -2202,6 +2202,11 @@ func (r Resource) TGCTestIgnorePropertiesToStrings(e resource.Examples) []string`
`2202`	`2202`	`props = append(props, google.Underscore(tp.Name))`
`2203`	`2203`	`} else if tp.IsMissingInCai {`
`2204`	`2204`	`props = append(props, tp.MetadataLineage())`
	`2205`	`+ } else if tp.IgnoreRead {`
	`2206`	`+ if tp.Sensitive \|\| tp.Name == "tags" {`
	`2207`	`+ // TODO: handle tags conversion, which are separate Cai assets with resources.`
	`2208`	`+ props = append(props, tp.MetadataLineage())`
	`2209`	`+ }`
`2205`	`2210`	`}`
`2206`	`2211`	`}`
`2207`	`2212`	`props = append(props, e.TGCTestIgnoreExtra...)`