GO: Upgrade Go version from 1.23 -> 1.24 (#15293)

BBBmau · melinath · web-flow · commit d2e1e4a59ab8 · 2025-10-03T10:09:15.000-07:00
Co-authored-by: Stephen Lewis (Burrows) &lt;stephen.r.burrows@gmail.com&gt;
diff --git a/.ci/magician/go.mod b/.ci/magician/go.mod
@@ -1,6 +1,6 @@
 module magician
 
-go 1.23
+go 1.24
 
 replace github.com/GoogleCloudPlatform/magic-modules/tools/issue-labeler => ../../tools/issue-labeler
 
diff --git a/.ci/unit-tests/gcb-membership-checker-test.yml b/.ci/unit-tests/gcb-membership-checker-test.yml
@@ -1,6 +1,6 @@
 ---
 steps:
-    - name: 'golang:1.23'
+    - name: 'golang:1.24'
       args:
         - '-c'
         - |
diff --git a/.github/workflows/build-downstream.yml b/.github/workflows/build-downstream.yml
@@ -24,7 +24,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
 
       # Cache Go modules
       - name: Cache Go modules
diff --git a/.github/workflows/changelog-checker.yml b/.github/workflows/changelog-checker.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build
         run: |
diff --git a/.github/workflows/ensure-service-team-labels.yml b/.github/workflows/ensure-service-team-labels.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
       - name: Build issue-labeler
         run: |
           cd tools/issue-labeler
diff --git a/.github/workflows/gofmt.yml b/.github/workflows/gofmt.yml
@@ -27,7 +27,7 @@ jobs:
         uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
         with:
           cache: false
-          go-version: '^1.23'
+          go-version: '^1.24'
       - name: gofmt
         run: |
           GOFMT_OUTPUT="$(gofmt -l .)"
diff --git a/.github/workflows/request-reviewer.yml b/.github/workflows/request-reviewer.yml
@@ -29,7 +29,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
           # Disable caching for now due to issues with large provider dependency caches
           cache: false
       - name: Build magician
diff --git a/.github/workflows/scheduled-pr-reminders.yml b/.github/workflows/scheduled-pr-reminders.yml
@@ -20,7 +20,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
           # Disable caching for now due to issues with large provider dependency caches
           cache: false
       - name: Build magician
diff --git a/.github/workflows/test-tgc.yml b/.github/workflows/test-tgc.yml
@@ -77,7 +77,7 @@ jobs:
       if: ${{ !failure() && steps.pull_request.outputs.has_changes == 'true' }}
       uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
       with:
-        go-version: '^1.23'
+        go-version: '^1.24'
     - name: Build Terraform Google Conversion
       if: ${{ !failure() && steps.pull_request.outputs.has_changes == 'true' }}
       run: |
diff --git a/.github/workflows/test-tpg.yml b/.github/workflows/test-tpg.yml
@@ -73,7 +73,7 @@ jobs:
       if: ${{ !failure() && steps.pull_request.outputs.has_changes == 'true' }}
       uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
       with:
-        go-version: '^1.23'
+        go-version: '^1.24'
     - name: Build Provider
       if: ${{ !failure() && steps.pull_request.outputs.has_changes == 'true' }}
       run: |
diff --git a/.github/workflows/unit-test-magician.yml b/.github/workflows/unit-test-magician.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
       - name: Run magician unit tests
         run: |
           cd .ci/magician
diff --git a/.github/workflows/unit-test-mmv1.yml b/.github/workflows/unit-test-mmv1.yml
@@ -129,7 +129,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
       - name: Run mmv1 unit tests
         run: |
           cd repo
diff --git a/.github/workflows/unit-test-tgc.yml b/.github/workflows/unit-test-tgc.yml
@@ -30,7 +30,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
 
       - name: Build Terraform Google Conversion
         run: |
diff --git a/.github/workflows/unit-test-tools.yml b/.github/workflows/unit-test-tools.yml
@@ -18,7 +18,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build diff-processor with TPG
         run: |
@@ -54,7 +54,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build go-changelog
         run: |
@@ -74,7 +74,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build issue-labeler
         run: |
@@ -94,7 +94,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build template-check
         run: |
@@ -114,7 +114,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23.0'
+          go-version: '^1.24.0'
 
       - name: Build test-reader
         run: |
diff --git a/.github/workflows/unit-test-tpg.yml b/.github/workflows/unit-test-tpg.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
         with:
-          go-version: '^1.23'
+          go-version: '^1.24'
 
       - name: Build Provider
         run: |
diff --git a/docs/go.mod b/docs/go.mod
@@ -1,7 +1,7 @@
 module github.com/GoogleCloudPlatform/magic-modules/docs
 
-go 1.23
+go 1.24
 
 require (
 	github.com/alex-shpak/hugo-book/v12 v12.0.1-0.20250927134827-c58c73a59c10 // indirect
-)
+)
diff --git a/docs/go.sum b/docs/go.sum
@@ -1,2 +1,2 @@
 github.com/alex-shpak/hugo-book/v12 v12.0.1-0.20250927134827-c58c73a59c10 h1:ESQ1sPFWUz1kce3x+PlQSz8Vf/SEgCcnwLTXur9s3DI=
-github.com/alex-shpak/hugo-book/v12 v12.0.1-0.20250927134827-c58c73a59c10/go.mod h1:f6/H1eOdaReIR+EHPkZGEvmgdRzKLjZek/CaTqBOyho=
+github.com/alex-shpak/hugo-book/v12 v12.0.1-0.20250927134827-c58c73a59c10/go.mod h1:f6/H1eOdaReIR+EHPkZGEvmgdRzKLjZek/CaTqBOyho=
diff --git a/mmv1/go.mod b/mmv1/go.mod
@@ -1,6 +1,6 @@
 module github.com/GoogleCloudPlatform/magic-modules/mmv1
 
-go 1.23.0
+go 1.24.0
 
 require (
 	golang.org/x/exp v0.0.0-20240222234643-814bf88cf225
diff --git a/mmv1/openapi_generate/parser.go b/mmv1/openapi_generate/parser.go
@@ -45,7 +45,7 @@ type Parser struct {
 func NewOpenapiParser(folder, output string) Parser {
 	wd, err := os.Getwd()
 	if err != nil {
-		log.Fatalf(err.Error())
+		log.Fatalf("%v", err)
 	}
 
 	parser := Parser{
@@ -59,13 +59,13 @@ func NewOpenapiParser(folder, output string) Parser {
 func (parser Parser) Run() {
 	f, err := os.Open(parser.Folder)
 	if err != nil {
-		log.Fatalf(err.Error())
+		log.Fatalf("%v", err)
 		return
 	}
 	defer f.Close()
 	files, err := f.Readdirnames(0)
 	if err != nil {
-		log.Fatalf(err.Error())
+		log.Fatalf("%v", err)
 	}
 
 	// check if folder is empty
diff --git a/mmv1/third_party/terraform/.go-version b/mmv1/third_party/terraform/.go-version
@@ -1 +1 @@
-1.23
+1.24
diff --git a/mmv1/third_party/terraform/acctest/diff_utils.go b/mmv1/third_party/terraform/acctest/diff_utils.go
@@ -197,7 +197,7 @@ func writeOutputFileDeferFunction(tempOutputFile *os.File, failed bool) {
 			fmt.Fprintf(os.Stdout, "%s Breaking Change Detected] \n", diffTag)
 			fmt.Fprintf(diffFailureFile, "%s %s\n", diffTag, testOutput)
 		} else {
-			fmt.Fprintf(regularFailureFile, testOutput)
+			fmt.Fprintf(regularFailureFile, "%s", testOutput)
 			fmt.Fprintf(regularFailureFile, "FAILED --- %s\n", testOutput)
 		}
 	}
diff --git a/mmv1/third_party/terraform/go.mod b/mmv1/third_party/terraform/go.mod
@@ -1,6 +1,6 @@
 module github.com/hashicorp/terraform-provider-google
 
-go 1.23.0
+go 1.24.0
 
 require (
 	cloud.google.com/go/auth v0.16.5
diff --git a/mmv1/third_party/terraform/scripts/go.mod b/mmv1/third_party/terraform/scripts/go.mod
@@ -1,3 +1,3 @@
 module github.com/hashicorp/terraform-provider-google/scripts
 
-go 1.23
+go 1.24
diff --git a/mmv1/third_party/terraform/services/container/container_operation.go.tmpl b/mmv1/third_party/terraform/services/container/container_operation.go.tmpl
@@ -48,7 +48,7 @@ func (w *ContainerOperationWaiter) Error() error {
 	}
 
 	if w.Op.StatusMessage != "" {
-		return fmt.Errorf(w.Op.StatusMessage)
+		return fmt.Errorf("%s", w.Op.StatusMessage)
 	}
 
 	return nil
diff --git a/mmv1/third_party/terraform/services/dataproc/resource_dataproc_job_test.go.tmpl b/mmv1/third_party/terraform/services/dataproc/resource_dataproc_job_test.go.tmpl
@@ -545,7 +545,7 @@ func testAccCheckDataprocJobAttrMatch(n, jobType string, job *dataproc.Job) reso
 
 		for _, attrs := range jobTests {
 			if c := checkMatch(attributes, attrs.tf_attr, attrs.gcp_attr); c != "" {
-				return fmt.Errorf(c)
+				return fmt.Errorf("%s", c)
 			}
 		}
 
diff --git a/mmv1/third_party/terraform/services/kms/kms_utils.go b/mmv1/third_party/terraform/services/kms/kms_utils.go
@@ -112,7 +112,7 @@ type kmsCryptoKeyVersionId struct {
 }
 
 func (s *kmsCryptoKeyVersionId) cryptoKeyVersionId() string {
-	return fmt.Sprintf(s.Name)
+	return s.Name
 }
 
 func (s *kmsCryptoKeyVersionId) TerraformId() string {
diff --git a/mmv1/third_party/terraform/services/resourcemanager/data_source_google_service_accounts_test.go b/mmv1/third_party/terraform/services/resourcemanager/data_source_google_service_accounts_test.go
@@ -56,7 +56,7 @@ func TestAccDataSourceGoogleServiceAccounts_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("data.google_service_accounts.with_regex", "accounts.0.email", fmt.Sprintf("%s@%s.iam.gserviceaccount.com", sa_1, project)),
 
 					// Check if the account_id matches the prefix
-					resource.TestCheckResourceAttr("data.google_service_accounts.with_prefix_and_regex", "accounts.0.account_id", fmt.Sprintf(sa_1)),
+					resource.TestCheckResourceAttr("data.google_service_accounts.with_prefix_and_regex", "accounts.0.account_id", sa_1),
 
 					// Check if the email matches the regex
 					resource.TestCheckResourceAttr("data.google_service_accounts.with_prefix_and_regex", "accounts.0.email", fmt.Sprintf("%s@%s.iam.gserviceaccount.com", sa_1, project)),
@@ -102,17 +102,19 @@ data "google_service_accounts" "with_prefix" {
 
 data "google_service_accounts" "with_regex" {
   project = local.project_id
-  regex   = ".*${google_service_account.sa_one.account_id}.*@.*\\.gserviceaccount\\.com"
+  regex   = ".*%s.*@.*\\.gserviceaccount\\.com"
 }
 
 data "google_service_accounts" "with_prefix_and_regex" {
   prefix  = google_service_account.sa_one.account_id
   project = local.project_id
-  regex   = ".*${google_service_account.sa_one.account_id}.*@.*\\.gserviceaccount\\.com"
+  regex   = ".*%s.*@.*\\.gserviceaccount\\.com"
 }
 `,
 		context["project"].(string),
 		context["sa_1"].(string),
 		context["sa_2"].(string),
+		context["sa_1"].(string),
+		context["sa_1"].(string),
 	)
 }
diff --git a/mmv1/third_party/terraform/services/storage/storage_operation.go b/mmv1/third_party/terraform/services/storage/storage_operation.go
@@ -34,7 +34,7 @@ func (w *StorageOperationWaiter) QueryOp() (interface{}, error) {
 	}
 
 	// Returns the proper get.
-	url := fmt.Sprintf(w.SelfLink)
+	url := w.SelfLink
 
 	return transport_tpg.SendRequest(transport_tpg.SendRequestOptions{
 		Config:    w.Config,
diff --git a/mmv1/third_party/terraform/sweeper/hashi_sweeper_fork.go b/mmv1/third_party/terraform/sweeper/hashi_sweeper_fork.go
@@ -467,7 +467,7 @@ func validateParentSweepers(sweepers map[string]*Sweeper) error {
 	// If any validation errors were found, return them
 	if len(validationErrors) > 0 {
 		if len(validationErrors) == 1 {
-			return fmt.Errorf(validationErrors[0])
+			return fmt.Errorf("%s", validationErrors[0])
 		}
 		return fmt.Errorf("multiple parent validation issues: %s", strings.Join(validationErrors, "; "))
 	}
diff --git a/mmv1/third_party/terraform/transport/batcher_test.go b/mmv1/third_party/terraform/transport/batcher_test.go
@@ -153,7 +153,7 @@ func TestRequestBatcher_errInSend(t *testing.T) {
 		log.Printf("[DEBUG] sendBatch body: %+v", body)
 		for _, v := range body.([]int) {
 			if v == failIdx {
-				return nil, fmt.Errorf(expectedErrMsg)
+				return nil, fmt.Errorf("%s", expectedErrMsg)
 			}
 		}
 		return nil, nil
diff --git a/mmv1/third_party/terraform/transport/retry_transport_test.go b/mmv1/third_party/terraform/transport/retry_transport_test.go
@@ -291,7 +291,7 @@ func testRetryTransport_checkBody(t *testing.T, resp *http.Response, expectedMsg
 
 	expectedBody := fmt.Sprintf("Request Body: %s", expectedMsg)
 	if !strings.HasSuffix(string(actualBody), expectedBody) {
-		t.Fatalf(expectedBody)
+		t.Fatalf("%s", expectedBody)
 	}
 }
 
diff --git a/mmv1/third_party/tgc_next/go.mod b/mmv1/third_party/tgc_next/go.mod
diff --git a/mmv1/third_party/tgc_next/go.sum b/mmv1/third_party/tgc_next/go.sum
diff --git a/scripts/doctor b/scripts/doctor
diff --git a/tools/diff-processor/go.mod b/tools/diff-processor/go.mod
diff --git a/tools/issue-labeler/go.mod b/tools/issue-labeler/go.mod
diff --git a/tools/teamcity-diff-check/go.mod b/tools/teamcity-diff-check/go.mod
diff --git a/tools/teamcity-generator/go.mod b/tools/teamcity-generator/go.mod
diff --git a/tools/template-check/go.mod b/tools/template-check/go.mod
diff --git a/tools/test-reader/go.mod b/tools/test-reader/go.mod
diff --git a/tpgtools/go.mod b/tpgtools/go.mod

-Original file line number
+Diff line change
@@ @@ -1,6 +1,6 @@ @@
 module magician
 -go 1.23
 +go 1.24
 replace github.com/GoogleCloudPlatform/magic-modules/tools/issue-labeler => ../../tools/issue-labeler