Adding in Datasource for google_compute_storage_pool (#15737)

Author: NA2047

mmv1/third_party/terraform/provider/provider_mmv1_resources.go.tmpl

@@ -140,6 +140,7 @@ var handwrittenDatasources = map[string]*schema.Resource{
 	"google_compute_snapshot":                          compute.DataSourceGoogleComputeSnapshot(),
 	"google_compute_ssl_certificate":                   compute.DataSourceGoogleComputeSslCertificate(),
 	"google_compute_ssl_policy":                        compute.DataSourceGoogleComputeSslPolicy(),
+	"google_compute_storage_pool":                      compute.DataSourceGoogleComputeStoragePool(),
 	"google_compute_storage_pool_types":                compute.DataSourceGoogleComputeStoragePoolTypes(),
 	"google_compute_subnetwork":                        compute.DataSourceGoogleComputeSubnetwork(),
 	"google_compute_subnetworks":                       compute.DataSourceGoogleComputeSubnetworks(),

mmv1/third_party/terraform/services/compute/data_source_google_compute_storage_pool.go

@@ -0,0 +1,52 @@
+package compute
+
+import (
+	"fmt"
+
+	"github.com/hashicorp/terraform-provider-google/google/tpgresource"
+	transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func DataSourceGoogleComputeStoragePool() *schema.Resource {
+	// Generate datasource schema from resource
+	dsSchema := tpgresource.DatasourceSchemaFromResourceSchema(ResourceComputeStoragePool().Schema)
+
+	// Set 'Required' schema elements
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "name")
+	tpgresource.AddRequiredFieldsToSchema(dsSchema, "zone")
+
+	tpgresource.AddOptionalFieldsToSchema(dsSchema, "project")
+
+	return &schema.Resource{
+		Read:   dataSourceGoogleComputeStoragePoolRead,
+		Schema: dsSchema,
+	}
+}
+
+func dataSourceGoogleComputeStoragePoolRead(d *schema.ResourceData, meta interface{}) error {
+	config := meta.(*transport_tpg.Config)
+	err := resourceComputeStoragePoolRead(d, meta)
+	if err != nil {
+		return err
+	}
+
+	project, err := tpgresource.GetProject(d, config)
+	if err != nil {
+		return err
+	}
+	zone, err := tpgresource.GetZone(d, config)
+	if err != nil {
+		return err
+	}
+	name := d.Get("name").(string)
+
+	d.SetId(fmt.Sprintf("projects/%s/zones/%s/storagePools/%s", project, zone, name))
+
+	if err := d.Set("deletion_protection", false); err != nil {
+		return fmt.Errorf("Error setting deletion_protection: %s", err)
+	}
+
+	return nil
+}

mmv1/third_party/terraform/services/compute/data_source_google_compute_storage_pool_test.go

@@ -0,0 +1,52 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: MPL-2.0
+package compute_test
+
+import (
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+	"github.com/hashicorp/terraform-provider-google/google/acctest"
+)
+
+func TestAccDataSourceComputeStoragePool_basic(t *testing.T) {
+	t.Parallel()
+
+	context := map[string]interface{}{
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputeStoragePoolDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDataSourceComputeStoragePool_basic(context),
+				Check: resource.ComposeTestCheckFunc(
+					acctest.CheckDataSourceStateMatchesResourceState("data.google_compute_storage_pool.my-storage-pool-data", "google_compute_storage_pool.test-storage-pool"),
+				),
+			},
+		},
+	})
+}
+func testAccDataSourceComputeStoragePool_basic(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+resource "google_compute_storage_pool" "test-storage-pool" {
+  name                          = "tf-test-storage-pool-%{random_suffix}"
+  zone                          = "us-central1-a"
+  capacity_provisioning_type    = "STANDARD"
+  pool_provisioned_capacity_gb  = "11264"
+  pool_provisioned_iops         = "20000"
+  pool_provisioned_throughput   = "2048"
+  storage_pool_type 			= "hyperdisk-balanced"
+  deletion_protection           = false
+ }
+
+
+data "google_compute_storage_pool" "my-storage-pool-data" {
+  name 							= google_compute_storage_pool.test-storage-pool.name
+  zone 							= "us-central1-a"
+}
+`, context)
+}

mmv1/third_party/terraform/website/docs/d/compute_storage_pool.html.markdown

@@ -0,0 +1,42 @@
+---
+subcategory: "Compute Engine"
+description: |-
+  Provide access to a Storage Pool's attributes
+---
+
+# google_compute_storage_pool
+
+Provides access to available Google Compute Storage Pool resources for a given project and zone.
+See more about [Hyperdisk Storage Pools](https://cloud.google.com/compute/docs/disks/storage-pools) in the upstream docs.
+
+## Example Usage
+
+```hcl
+data "google_compute_storage_pool" "my_pool" {
+  name = "my-storage-pool"
+  zone = "us-central1-a"
+}
+
+output "pool_capacity" {
+  value = data.google_compute_storage_pool.my_pool.pool_provisioned_capacity_gb
+}
+
+output "pool_type" {
+  value = data.google_compute_storage_pool.my_pool.storage_pool_type
+}
+```
+
+## Argument Reference
+
+The following arguments are supported:
+
+* `name` (Required) - The name of the Storage Pool.
+* `zone` (Required) - The zone where the Storage Pool resides.
+* `project` (Optional) - The project in which the Storage Pool exists. If it is not provided, the provider project is used.
+
+## Note
+* `deletion_protection` is always set to false on the data source and will not be represetative of the actual value on `google_compute_storage_pool` reaosure being read 
+
+## Attributes Reference
+
+See [google_compute_storage_pool](https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_storage_pool) resource for details of the available attributes.