Compute public delagated sub prefix list support (#14264)

Author: malhotrasagar2212

mmv1/products/compute/PublicDelegatedPrefix.yaml

@@ -122,3 +122,58 @@ properties:
       The IP address range, in CIDR format, represented by this public
       delegated prefix.
     required: true
+  - name: 'publicDelegatedSubPrefixs'
+    type: Array
+    output: true
+    description: |
+      List of sub public delegated fixes for BYO IP functionality.
+      Each item in this array represents a sub prefix that can be
+      used to create addresses or further allocations.
+    item_type:
+      type: NestedObject
+      properties:
+        - name: 'name'
+          type: String
+          description: |
+            The name of the sub public delegated prefix.
+        - name: 'description'
+          type: String
+          description: |
+            An optional description of this sub public delegated prefix.
+        - name: 'region'
+          type: String
+          description: |
+            Output-only. The region of the sub public delegated prefix if it is regional. If absent, the sub prefix is global.
+        - name: 'status'
+          type: Enum
+          description: |
+            The status of the sub public delegated prefix.
+          enum_values:
+            - 'INITIALIZING'
+            - 'READY_TO_ANNOUNCE'
+            - 'ANNOUNCED'
+            - 'DELETING'
+        - name: 'ipCidrRange'
+          type: String
+          description: |
+            The IP address range in the CIDR format represented by this sub prefix.
+        - name: 'isAddress'
+          type: Boolean
+          description: |
+            Whether the sub prefix is delegated for address creation.
+        - name: 'mode'
+          type: Enum
+          description: |
+            The PublicDelegatedSubPrefix mode for IPv6 only.
+          enum_values:
+            - 'DELEGATION'
+            - 'EXTERNAL_IPV6_FORWARDING_RULE_CREATION'
+            - 'EXTERNAL_IPV6_SUBNETWORK_CREATION'
+        - name: 'allocatablePrefixLength'
+          type: Integer
+          description: |
+            The allocatable prefix length supported by this PublicDelegatedSubPrefix.
+        - name: 'delegatee_project'
+          type: String
+          description: |
+            Name of the project scoping this PublicDelegatedSubPrefix.

mmv1/third_party/terraform/services/compute/resource_compute_public_advertised_prefix_test.go

@@ -21,6 +21,7 @@ func TestAccComputePublicPrefixes(t *testing.T) {
 		"public_delegated_prefixes_ipv6":           testAccComputePublicDelegatedPrefix_publicDelegatedPrefixesIpv6Test,
 		"public_advertised_prefixes_pdp_scope":     testAccComputePublicAdvertisedPrefix_publicAdvertisedPrefixesPdpScopeTest,
 		"public_delegated_prefix_ipv6_subnet_mode": testAccComputePublicDelegatedPrefix_publicDelegatedPrefixIpv6SubnetModeTest,
+		"public_delgated_prefix_with_sub_prefix":   TestAccComputePublicDelegatedPrefix_computePublicDelegatedPrefixWithSubPrefixExample,
 	}
 
 	for name, tc := range testCases {
@@ -35,6 +36,84 @@ func TestAccComputePublicPrefixes(t *testing.T) {
 	}
 }
 
+func TestAccComputePublicDelegatedPrefix_computePublicDelegatedPrefixWithSubPrefixExample(t *testing.T) {
+	t.Parallel()
+	subPrefixResourceName := "google_compute_public_delegated_prefix.subprefix"
+	parentProject := "tf-static-byoip"
+	parentRegion := "us-central1"
+	parentName := "tf-test-delegation-mode-sub-pdp"
+
+	context := map[string]interface{}{
+		"parent_pdp_id": "projects/tf-static-byoip/regions/us-central1/publicDelegatedPrefixes/tf-test-delegation-mode-sub-pdp",
+		"project":       "tf-static-byoip",
+		"random_suffix": acctest.RandString(t, 10),
+	}
+
+	acctest.VcrTest(t, resource.TestCase{
+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		CheckDestroy:             testAccCheckComputePublicDelegatedPrefixDestroyProducer(t),
+		Steps: []resource.TestStep{
+			{
+				Config: testAccComputePublicDelegatedPrefix_computePublicDelegatedPrefixWithSubPrefixExample(context),
+				Check: resource.ComposeTestCheckFunc(
+					// First, a basic check that the sub-prefix was created
+					resource.TestCheckResourceAttrSet(subPrefixResourceName, "id"),
+
+					// Now, the custom check function
+					testAccCheckParentHasSubPrefix(t, parentProject, parentRegion, parentName, subPrefixResourceName),
+				),
+			},
+			{
+				ResourceName:            "google_compute_public_delegated_prefix.subprefix",
+				ImportState:             true,
+				ImportStateVerify:       true,
+				ImportStateVerifyIgnore: []string{"region"},
+			},
+		},
+	})
+}
+
+func testAccComputePublicDelegatedPrefix_computePublicDelegatedPrefixWithSubPrefixExample(context map[string]interface{}) string {
+	return acctest.Nprintf(`
+
+resource "google_compute_public_delegated_prefix" "subprefix" {
+  name = "tf-test-sub-prefix-1%{random_suffix}"
+  description = "A nested address"
+  region = "us-central1"
+  ip_cidr_range = "2600:1901:4500:2::/64"
+  parent_prefix = "%{parent_pdp_id}"
+  mode = "DELEGATION"
+}
+`, context)
+}
+
+func testAccCheckParentHasSubPrefix(t *testing.T, project, region, parentName, subPrefixResourceName string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, ok := s.RootModule().Resources[subPrefixResourceName]
+		if !ok {
+			return fmt.Errorf("Not found: %s", subPrefixResourceName)
+		}
+		newSubPrefixName := rs.Primary.Attributes["name"]
+
+		config := acctest.GoogleProviderConfig(t)
+		computeService := config.NewComputeClient(config.UserAgent)
+
+		parent, err := computeService.PublicDelegatedPrefixes.Get(project, region, parentName).Do()
+		if err != nil {
+			return err
+		}
+
+		for _, sub := range parent.PublicDelegatedSubPrefixs {
+			if sub.Name == newSubPrefixName {
+				return nil
+			}
+		}
+
+		return fmt.Errorf("Sub-Prefix %q not found in parent %q's sub-prefix list", newSubPrefixName, parentName)
+	}
+}
+
 func testAccComputePublicAdvertisedPrefix_publicAdvertisedPrefixesPdpScopeTest(t *testing.T) {
 	context := map[string]interface{}{
 		"description":   envvar.GetTestPublicAdvertisedPrefixDescriptionFromEnv(t),