adding source_instance_deletion_time

[tambalo-lgtm]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

sql: added `source_instance_deletion_time` field to `google_sql_database_instance` resource

sql: added `source_instance_deletion_time` field to `google_sql_database_instance_latest_recovery_time` data source

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

Manual non-VCR test run (you won't be able to access this link): https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_GoogleCloud_GOOGLE_BETA_MMUPSTREAMTESTS_GOOGLEBETA_PACKAGE_SQL/487986

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 44 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 44 insertions(+), 10 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (203 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  clone {
    source_instance_deletion_time = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [clone.source_instance_deletion_time]

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 44 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 44 insertions(+), 10 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (203 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  clone {
    source_instance_deletion_time = # value needed
  }
}

Missing doc report (experimental)

The following resources have fields missing in documents.

• google_sql_database_instance
  • Expected Document Path: /website/docs/r/sql_database_instance.html.markdown
  • Fields: [clone.source_instance_deletion_time]

[tambalo-lgtm]

Recapping that the plan is to write a follow-up pr with the happy case integration tested, and to increase the helpfulness of the customer visible error logs which are currently opaque

Manual testing done to ensure feature works:
https://paste.googleplex.com/6008867393765376

[modular-magician]

Tests analytics

Total tests: 129
Passed tests: 102
Skipped tests: 26
Affected tests: 1

Click here to see the affected service packages

• sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

The failure for TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess happens in nightlies as well - unrelated to these changes.

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_MysqlReadPoolEnableDisableSuccess [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

LGTM. This feature is a little tricky to write an automated test for, so I'm approving it based on the manual tests linked above. The previous tests for error message were removed because they were testing API behavior, not provider behavior (and the API message doesn't have the level of detail we'd need anyway).