feat: added support for ssl_config for postgresql_profile

[pete-layerhealth]

Added support for ssl_config for postgresql_profile

shamelessly copied #12771 and incorporated feedback from @roaks3

Fixes hashicorp/terraform-provider-google#20929

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

datastream: added `postgresql_profile.ssl_config` to `google_datastream_connection_profile`

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 372 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 170 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  postgresql_profile {
    ssl_config {
      server_verification {
        ca_certificate = # value needed
      }
    }
  }
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample

Tests analytics

Total tests: 19
Passed tests: 9
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[pete-layerhealth]

@slevenick would you be able to take a look? the previous PR was nearly approved but the author went MIA so it ended up staling

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

It looks like there's a commit from the old PR in here:
❌ 7bf332e Author: <aru******el​@coop.no>

It's failing the CLA check. I can't merge this without that user signing the CLA

[slevenick]

It still sees the commit as belonging to another contributor

[pete-layerhealth]

should be good now! sorry bout that

[pete-layerhealth]

@slevenick would love another check when you get a chance 🙏

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 372 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 170 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  postgresql_profile {
    ssl_config {
      server_verification {
        ca_certificate = # value needed
      }
    }
  }
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample

Tests analytics

Total tests: 19
Passed tests: 9
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[pete-layerhealth]

@slevenick any chance youd have a moment to take a look today? im hoping itll be quick given the previous attempt was already reviewed

[slevenick]

I'm seeing the following error when running the test:
~ postgresql_profile {
- secret_manager_stored_password = "" -> null
# (5 unchanged attributes hidden)

              ~ ssl_config {
                  + server_and_client_verification {
                      + ca_certificate     = (sensitive value) # forces replacement
                      + client_certificate = (sensitive value) # forces replacement
                      + client_key         = (sensitive value) # forces replacement
                    }
                }
            }

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 486 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 371 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 170 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  postgresql_profile {
    ssl_config {
      server_verification {
        ca_certificate = # value needed
      }
    }
  }
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample

Tests analytics

Total tests: 19
Passed tests: 9
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

This entire block may need ignore_read. I'm still seeing a diff when running the test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 472 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 472 insertions(+), 5 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 372 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 170 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_datastream_connection_profile (19 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_datastream_connection_profile" "primary" {
  postgresql_profile {
    ssl_config {
      server_verification {
        ca_certificate = # value needed
      }
    }
  }
}

[modular-magician]

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample

Tests analytics

Total tests: 19
Passed tests: 9
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• datastream

🟢 All tests passed!

View the build log

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[slevenick]

Still getting errors on testing:

=== CONT TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample
resource_datastream_connection_profile_generated_test.go:319: Step 2/2 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.

      map[string]string{
    - 	"postgresql_profile.0.password": "ukJ0WUxF1FKiMi9n",
    + 	"postgresql_profile.0.password": "",
      }

[pete-layerhealth]

Still getting errors on testing

ok, ignoring the password got it passing for me locally:

❯ TF_ACC=1 go test -v ./google/services/datastream -run '^TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample$' -timeout 120m
=== RUN   TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample
=== PAUSE TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample
=== CONT  TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample
--- PASS: TestAccDatastreamConnectionProfile_datastreamStreamPostgresqlSslconfigServerAndClientVerificationExample (921.34s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/datastream       923.484s

ready for another review @slevenick 🙏