Skip to content

Conversation

@Chi-Pin
Copy link
Contributor

@Chi-Pin Chi-Pin commented Dec 26, 2025

Enables send_empty_value and allow_empty_object for the following properties:

  • serviceDiscovery in SecurityGateway.yaml
  • userInfo, groupInfo, and deviceInfo in SecurityGatewayApplication.yaml

Release Note Template for Downstream PRs (will be copied)

securitygateway: fixed `service_discovery` in `google_beyondcorp_security_gateway`
securitygateway: fixed `user_info`, `group_info` and `device_info` in `google_beyondcorp_security_gateway`

@github-actions github-actions bot requested a review from trodge December 26, 2025 18:59
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 2 files changed, 29 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 28 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 19
Skipped tests: 4
Affected tests: 21

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 21 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaApiExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaProxyExample
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated
  • TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated
  • TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated
  • TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition
  • TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample
  • TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update
  • TestAccDataSourceGoogleBeyondcorpSecurityGateway_basic
  • TestAccDataSourceGoogleBeyondcorpSecurityGateway_full

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayApplicationIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample_update [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaApiExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationSpaProxyExample [Debug log]
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationVpcExample [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamBindingGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamMemberGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated [Debug log]
TestAccBeyondcorpSecurityGatewayIamPolicyGenerated_withCondition [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample [Debug log]
TestAccBeyondcorpSecurityGateway_beyondcorpSecurityGatewayBasicExample_update [Debug log]
TestAccDataSourceGoogleBeyondcorpSecurityGateway_basic [Debug log]
TestAccDataSourceGoogleBeyondcorpSecurityGateway_full [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@Chi-Pin Chi-Pin closed this Dec 27, 2025
@Chi-Pin Chi-Pin reopened this Dec 27, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 29 insertions(+), 21 deletions(-))
google-beta provider: Diff ( 2 files changed, 29 insertions(+), 21 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 28 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 44
Passed tests: 39
Skipped tests: 4
Affected tests: 1

Click here to see the affected service packages
  • beyondcorp

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBeyondcorpSecurityGatewayApplication_beyondcorpSecurityGatewayApplicationBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants