Skip to content

Commit 3f3d68a

Browse files
Merge branch 'main' into hivanalejandro/bigquery/create-sample/view-dataset-access-policy
2 parents b013b3c + 31f4616 commit 3f3d68a

File tree

7 files changed

+37
-18
lines changed

7 files changed

+37
-18
lines changed

.github/config/nodejs-prod.jsonc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
".kokoro/",
4343
".prettierignore",
4444
".prettierrc.js",
45-
"cloud-samples-tools", // checked out by GH action in ci-*.yml
45+
"cloud-samples-tools", // checked out by GH action in ci-*.yml
4646
"CODEOWNERS",
4747
"CODE_OF_CONDUCT.md",
4848
"CONTRIBUTING.md",
@@ -70,7 +70,6 @@
7070
"ai-platform/snippets", // PERMISSION_DENIED: Permission denied: Consumer 'projects/undefined' has been suspended.
7171
"appengine/analytics", // [ERR_REQUIRE_ESM]: require() of ES Module
7272
"appengine/metadata/flexible", // [ERR_REQUIRE_ESM]: require() of ES Module
73-
"appengine/metadata/standard", // [ERR_REQUIRE_ESM]: require() of ES Module
7473
"automl", // (untested) FAILED_PRECONDITION: Google Cloud AutoML Natural Language was retired on March 15, 2024. Please migrate to Vertex AI instead
7574
"cloud-sql/mysql/mysql", // (untested) Error: expected 200 "OK", got 500 "Internal Server Error"
7675
"cloud-sql/mysql/mysql2", // (untested) Error: Cannot find module './connect-connector-with-iam-authn.js'

.github/workflows/ci-dev.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,25 @@ jobs:
4040
- uses: actions/checkout@v4
4141
with:
4242
repository: GoogleCloudPlatform/cloud-samples-tools
43-
ref: v0.1.0
43+
ref: v0.2.1
4444
path: cloud-samples-tools
4545
- name: Create `bin` directory for cloud-samples-tools binaries
4646
run: mkdir bin
4747
working-directory: cloud-samples-tools
4848
- uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
4949
with:
5050
go-version: ${{ env.GO_VERSION }}
51-
- name: Build Ariwete (from cloud-samples-tools)
51+
- name: Build Custard (from cloud-samples-tools)
5252
run: go build -o ../bin -v ./...
53-
working-directory: cloud-samples-tools/ariwete
53+
working-directory: cloud-samples-tools/custard
5454
- name: Get diffs
5555
run: git --no-pager diff --name-only HEAD origin/main | tee diffs.txt
5656
- name: Find Node.js affected packages
5757
id: nodejs
5858
run: |
59-
echo "paths=$(./cloud-samples-tools/bin/ariwete affected .github/config/nodejs-dev.jsonc diffs.txt paths.txt)" >> $GITHUB_OUTPUT
59+
echo "paths=$(./cloud-samples-tools/bin/custard affected .github/config/nodejs-dev.jsonc diffs.txt paths.txt)" >> $GITHUB_OUTPUT
6060
cat paths.txt
61-
echo "setups=$(./cloud-samples-tools/bin/ariwete setup-files .github/config/nodejs-dev.jsonc paths.txt)" >> $GITHUB_OUTPUT
61+
echo "setups=$(./cloud-samples-tools/bin/custard setup-files .github/config/nodejs-dev.jsonc paths.txt)" >> $GITHUB_OUTPUT
6262
6363
nodejs-test:
6464
name: Node.js test

.github/workflows/ci-prod.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,25 +40,25 @@ jobs:
4040
- uses: actions/checkout@v4
4141
with:
4242
repository: GoogleCloudPlatform/cloud-samples-tools
43-
ref: v0.1.0
43+
ref: v0.2.1
4444
path: cloud-samples-tools
4545
- name: Create `bin` directory for cloud-samples-tools binaries
4646
run: mkdir bin
4747
working-directory: cloud-samples-tools
4848
- uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
4949
with:
5050
go-version: ${{ env.GO_VERSION }}
51-
- name: Build Ariwete (from cloud-samples-tools)
51+
- name: Build Custard (from cloud-samples-tools)
5252
run: go build -o ../bin -v ./...
53-
working-directory: cloud-samples-tools/ariwete
53+
working-directory: cloud-samples-tools/custard
5454
- name: Get diffs
5555
run: git --no-pager diff --name-only HEAD origin/main | tee diffs.txt
5656
- name: Find Node.js affected packages
5757
id: nodejs
5858
run: |
59-
echo "paths=$(./cloud-samples-tools/bin/ariwete affected .github/config/nodejs-prod.jsonc diffs.txt paths.txt)" >> $GITHUB_OUTPUT
59+
echo "paths=$(./cloud-samples-tools/bin/custard affected .github/config/nodejs-prod.jsonc diffs.txt paths.txt)" >> $GITHUB_OUTPUT
6060
cat paths.txt
61-
echo "setups=$(./cloud-samples-tools/bin/ariwete setup-files .github/config/nodejs-prod.jsonc paths.txt)" >> $GITHUB_OUTPUT
61+
echo "setups=$(./cloud-samples-tools/bin/custard setup-files .github/config/nodejs-prod.jsonc paths.txt)" >> $GITHUB_OUTPUT
6262
6363
nodejs-lint:
6464
name: Node.js lint

appengine/metadata/standard/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"type": "git",
1010
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git"
1111
},
12+
"type": "module",
1213
"engines": {
1314
"node": "20.x"
1415
},

appengine/metadata/standard/server.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414

1515
'use strict';
1616

17-
const express = require('express');
18-
const fetch = require('node-fetch');
17+
import express from 'express';
18+
import fetch from 'node-fetch';
1919

2020
const app = express();
2121
app.enable('trust proxy');
@@ -57,4 +57,5 @@ app.listen(PORT, () => {
5757
console.log(`App listening on port ${PORT}`);
5858
console.log('Press Ctrl+C to quit.');
5959
});
60-
module.exports = app;
60+
61+
export default app;

appengine/metadata/standard/test/server.test.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,19 @@
1-
const path = require('path');
2-
const supertest = require('supertest');
3-
const app = require(path.join(__dirname, '../', 'server.js'));
1+
// Copyright 2020 Google LLC
2+
//
3+
// Licensed under the Apache License, Version 2.0 (the "License");
4+
// you may not use this file except in compliance with the License.
5+
// You may obtain a copy of the License at
6+
//
7+
// http://www.apache.org/licenses/LICENSE-2.0
8+
//
9+
// Unless required by applicable law or agreed to in writing, software
10+
// distributed under the License is distributed on an "AS IS" BASIS,
11+
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
// See the License for the specific language governing permissions and
13+
// limitations under the License.
14+
15+
import supertest from 'supertest';
16+
import app from '../server.js';
417

518
it('should be listening', async () => {
619
await supertest(app).get('/').expect(200);

datacatalog/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
**Data Catalog API deprecation**
2+
3+
Data Catalog is deprecated and will be discontinued on January 30, 2026. For steps to transition your Data Catalog users, workloads, and content to Dataplex Catalog, see [Transition from Data Catalog to Dataplex Catalog](https://cloud.google.com/dataplex/docs/transition-to-dataplex-catalog).
4+
5+
All API code samples under this folder are subject to decommissioning and will be removed after January 30, 2026.

0 commit comments

Comments
 (0)