Skip to content

Commit 4512af6

Browse files
committed
feat(secretmanager): Add secret version
1 parent 4afb60e commit 4512af6

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

secret-manager/test/secretmanager.test.js

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -833,23 +833,39 @@ describe('Secret Manager samples', () => {
833833
});
834834

835835
it('list secret versions with filter', async () => {
836+
const [versionForFilter] = await client.addSecretVersion({
837+
parent: secret.name,
838+
payload: {
839+
data: Buffer.from(payload),
840+
},
841+
});
842+
836843
await client.disableSecretVersion({
837-
name: version.name,
844+
name: versionForFilter.name,
838845
});
839846
const output = execSync(
840847
`node listSecretVersionsWithFilter.js ${secret.name}`
841848
);
842-
assert.match(output, new RegExp(`Found version: ${version.name}`));
849+
assert.match(output, new RegExp(`Found version: ${versionForFilter.name}`));
843850
});
844851

845852
it('list regional secret versions with filter', async () => {
853+
const [regionalVersionForFilter] = await regionalClient.addSecretVersion({
854+
parent: regionalSecret.name,
855+
payload: {
856+
data: Buffer.from(payload),
857+
},
858+
});
846859
await regionalClient.disableSecretVersion({
847-
name: regionalVersion.name,
860+
name: regionalVersionForFilter.name,
848861
});
849862
const output = execSync(
850863
`node regional_samples/listRegionalSecretVersionsWithFilter.js ${projectId} ${locationId} ${secretId}`
851864
);
852-
assert.match(output, new RegExp(`Found version: ${regionalVersion.name}`));
865+
assert.match(
866+
output,
867+
new RegExp(`Found version: ${regionalVersionForFilter.name}`)
868+
);
853869
});
854870

855871
it('lists tag bindings', async () => {

0 commit comments

Comments
 (0)