Skip to content

Commit 5989107

Browse files
authored
chore: test-isolation remove old tests (#3998)
Removing old tests that are already consistently passing in our prod workflow with the new "custard" tooling. Also made some small cleanups: * Remove "Node.js" prefix for jobs since it's redundant * Split region tags job from lint (like the previous ci.yaml) * Documented some other tests that were not previously tested
1 parent 5a1e566 commit 5989107

File tree

93 files changed

+26
-4851
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

93 files changed

+26
-4851
lines changed

.github/config/nodejs-dev.jsonc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,12 @@
6666
"functions/firebase", // parent directory
6767
"functions/helloworld", // parent directory
6868
"functions/http", // parent directory
69+
"functions/http/uploadFile", // no tests exist
6970
"functions/log", // parent directory
7071
"functions/pubsub", // parent directory
7172
"memorystore/redis", // parent directory
7273
"recaptcha_enterprise/demosite/app", // no tests exist
74+
7375
// These tests are already passing in prod, so skip them in dev.
7476
"appengine/building-an-app/build",
7577
"appengine/building-an-app/update",
@@ -80,6 +82,7 @@
8082
"appengine/hello-world/standard",
8183
"appengine/memcached",
8284
"appengine/metadata/flexible_nodejs16_and_earlier",
85+
"appengine/metadata/standard",
8386
"appengine/pubsub",
8487
"appengine/static-files",
8588
"appengine/storage/flexible",
@@ -196,6 +199,7 @@
196199
"security-center/snippets",
197200
"service-directory/snippets",
198201
"storage-control",
202+
"talent",
199203
"texttospeech",
200204
"tpu",
201205
"workflows/invoke-private-endpoint"

.github/config/nodejs-prod.jsonc

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@
6464
"functions/firebase", // parent directory
6565
"functions/helloworld", // parent directory
6666
"functions/http", // parent directory
67+
"functions/http/uploadFile", // no tests exist
6768
"functions/log", // parent directory
6869
"functions/pubsub", // parent directory
6970
"memorystore/redis", // parent directory
@@ -86,21 +87,19 @@
8687
"dlp", // [ERR_REQUIRE_ESM]: require() of ES Module
8788
"document-ai", // [ERR_REQUIRE_ESM]: require() of ES Module
8889
"eventarc/audit-storage", // (untested) Environment Variable 'SERVICE_NAME' not found
89-
"functions/billing", // Error: Request failed with status code 500
90-
"functions/http/uploadFile", // npm error Missing script: "test"
91-
"functions/imagemagick", // Error: A bucket name is needed to use Cloud Storage
92-
"functions/ocr/app", // Error: Bucket not provided. Make sure you have a "bucket" property in your request
90+
"functions/billing", // (untested) Error: Request failed with status code 500
91+
"functions/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage
92+
"functions/ocr/app", // (untested) Error: Bucket not provided. Make sure you have a "bucket" property in your request
9393
"functions/slack", // TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type ... Received undefined
94-
"functions/v2/imagemagick", // Error: A bucket name is needed to use Cloud Storage.
94+
"functions/v2/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage.
9595
"healthcare/fhir", // Error: Cannot find module 'whatwg-url'
9696
"iam/deny", // PERMISSION_DENIED: Permission iam.googleapis.com/denypolicies.create denied on resource cloudresourcemanager.googleapis.com/projects/long-door-651
9797
"recaptcha_enterprise/snippets", // Cannot use import statement outside a module
98-
"run/idp-sql", // Error: Invalid contents in the credentials file
99-
"run/markdown-preview/editor", // Error: could not create an identity token: Cannot fetch ID token in this environment, use GCE or set the GOOGLE_APPLICATION_CREDENTIALS environment variable to a service account credentials JSON file
98+
"run/idp-sql", // (untested) Error: Invalid contents in the credentials file
99+
"run/markdown-preview/editor", // (untested) Error: could not create an identity token: Cannot fetch ID token in this environment, use GCE or set the GOOGLE_APPLICATION_CREDENTIALS environment variable to a service account credentials JSON file
100100
"scheduler", // SyntaxError: Cannot use import statement outside a module
101101
"speech", // AssertionError: expected 'Transcription: Okay, I\'m here.\n Hi…' to match /Terrific. It's on the way./
102102
"storagetransfer", // CredentialsError: Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1
103-
"talent", // AssertionError: expected '' to match /Job summary/
104103
"translate", // AssertionError: expected 'Languages:\n{ code: \'ab\', name: \'A…' to match /{ code: 'af', name: 'afrikáans' }/
105104
"video-intelligence", // PERMISSION_DENIED: The caller does not have permission
106105
"vision", // REDIS: Error: connect ECONNREFUSED 127.0.0.1:6379

.github/workflows/appengine-building-an-app-build.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/appengine-building-an-app-update.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/appengine-datastore.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/appengine-endpoints.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/appengine-hello-world-flexible.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

.github/workflows/appengine-hello-world-standard.yaml

Lines changed: 0 additions & 52 deletions
This file was deleted.

0 commit comments

Comments
 (0)