Skip to content

Commit 898ac9a

Browse files
authored
chore(ci): migrate sqlserver/mssql sample to new ci (#4066)
* chore(ci): migrate sqlserver/mssql sample to new ci * remove unneeded envvars * another * used by proxy (other samples use this)
1 parent 74b288f commit 898ac9a

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

.github/config/nodejs-dev.jsonc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@
103103
"cloud-sql/mysql/mysql",
104104
"cloud-sql/mysql/mysql2",
105105
"cloud-sql/postgres/knex",
106+
"cloud-sql/sqlserver/mssql",
106107
"cloud-tasks/snippets",
107108
"cloud-tasks/tutorial-gcf/app",
108109
"cloud-tasks/tutorial-gcf/function",

.github/config/nodejs.jsonc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@
7777
// TODO: fix these
7878
"ai-platform/snippets", // PERMISSION_DENIED: Permission denied: Consumer 'projects/undefined' has been suspended.
7979
"automl", // (untested) FAILED_PRECONDITION: Google Cloud AutoML Natural Language was retired on March 15, 2024. Please migrate to Vertex AI instead
80-
"cloud-sql/sqlserver/mssql", // (untested) TypeError: The "config.server" property is required and must be of type string.
8180
"cloud-sql/sqlserver/tedious", // (untested) TypeError: The "config.server" property is required and must be of type string.
8281
"compute", // GoogleError: The resource 'projects/long-door-651/zones/us-central1-a/disks/disk-from-pool-name' was not found
8382
"dataproc", // GoogleError: Error submitting create cluster request: Multiple validation errors
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"env": {
3+
"INSTANCE_HOST": "127.0.0.1",
4+
"INSTANCE_CONNECTION_NAME": "nodejs-docs-samples-tests:us-central1:sql-server-ci",
5+
"CLOUD_SQL_CONNECTION_NAME": "$INSTANCE_CONNECTION_NAME",
6+
"DB_NAME": "kokoro_ci",
7+
"DB_USER": "kokoro_ci"
8+
},
9+
"secrets": {
10+
"DB_PASS": "nodejs-docs-samples-tests/nodejs-docs-samples-sql-password"
11+
}
12+
}

cloud-sql/sqlserver/mssql/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
},
1414
"scripts": {
1515
"start": "node server/server.js",
16-
"system-test": "c8 mocha -p -j 2 test/*.test.js --timeout=60000 --exit",
16+
"proxy": "$GITHUB_WORKSPACE/.github/workflows/utils/sql-proxy.sh",
17+
"system-test": "npm run proxy -- c8 mocha -p -j 2 test/*.test.js --timeout=60000 --exit",
1718
"test": "npm run system-test"
1819
},
1920
"dependencies": {

0 commit comments

Comments
 (0)