Skip to content

Commit a1b33bf

Browse files
author
Joanna Grycz
committed
Fix samples and tests
1 parent bf5bab3 commit a1b33bf

File tree

3 files changed

+2
-40
lines changed

3 files changed

+2
-40
lines changed

tpu/queuedResource/createQueuedResource.js

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -111,24 +111,6 @@ async function main(
111111
await operation.promise();
112112

113113
console.log(`Queued resource ${queuedResourceName} created.`);
114-
115-
const getNodeRequest = {
116-
name: `projects/${projectId}/locations/${zone}/nodes/${nodeName}`,
117-
};
118-
119-
console.log(`Waiting for TPU node ${nodeName} to become ready...`);
120-
121-
// Poll for TPU node state every 30 seconds
122-
const intervalId = setInterval(async () => {
123-
const [node] = await tpuClient.getNode(getNodeRequest);
124-
125-
if (node.state === 'READY') {
126-
clearInterval(intervalId);
127-
console.log(`TPU node ${nodeName} is ready.`);
128-
} else {
129-
console.log(`TPU node ${nodeName} is in state: ${node.state}`);
130-
}
131-
}, 30000);
132114
}
133115
await callCreateQueuedResource();
134116
// [END tpu_queued_resources_create]

tpu/queuedResource/deleteQueuedResource.js

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -36,31 +36,11 @@ async function main(queuedResourceName, zone) {
3636
// The zone of your queued resource.
3737
// zone = 'europe-west4-a';
3838

39-
async function callDeleteTpuVM(nodeName) {
40-
const request = {
41-
name: `projects/${projectId}/locations/${zone}/nodes/${nodeName}`,
42-
};
43-
44-
const [operation] = await tpuClient.deleteNode(request);
45-
46-
// Wait for the delete operation to complete.
47-
await operation.promise();
48-
49-
console.log(`Node: ${nodeName} deleted.`);
50-
}
51-
5239
async function callDeleteQueuedResource() {
5340
const request = {
5441
name: `projects/${projectId}/locations/${zone}/queuedResources/${queuedResourceName}`,
5542
};
5643

57-
// Retrive node name
58-
const [response] = await tpuClient.getQueuedResource(request);
59-
const nodeName = response.tpu.nodeSpec[0].nodeId;
60-
61-
// Before deleting the queued resource it is required to delete the TPU VM.
62-
await callDeleteTpuVM(nodeName);
63-
6444
const [operation] = await tpuClient.deleteQueuedResource(request);
6545

6646
// Wait for the delete operation to complete.

tpu/test/queuedResource.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ const cp = require('child_process');
2424
const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'});
2525
const cwd = path.join(__dirname, '..');
2626

27-
describe('TPU queued resource', async () => {
27+
describe('TPU queued resource', () => {
2828
const queuedResourceName = `queued-resource-name-1a2sdf${Math.floor(Math.random() * 1000 + 1)}`;
2929
const nodePrefix = 'node-name-2a2b3c';
3030
const nodeName = `${nodePrefix}${Math.floor(Math.random() * 1000 + 1)}`;
3131
const zone = 'europe-west4-a';
3232
const tpuType = 'v2-8';
3333
const tpuSoftwareVersion = 'tpu-vm-tf-2.14.1';
3434

35-
it('should create a new queued resource', () => {
35+
it('should create a new queued resource', async () => {
3636
const response = execSync(
3737
`node ./queuedResource/createQueuedResource.js ${nodeName} ${queuedResourceName} ${zone} ${tpuType} ${tpuSoftwareVersion}`,
3838
{

0 commit comments

Comments
 (0)