Skip to content

Commit b948c99

Browse files
committed
cleanup
1 parent 509198e commit b948c99

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

run/system-package/test/e2e_test_cleanup.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@ steps:
2525
#./test/retry.sh "gcloud container images describe gcr.io/${PROJECT_ID}/${_SERVICE}:${_VERSION}" \
2626
# "gcloud container images delete gcr.io/${PROJECT_ID}/${_SERVICE}:${_VERSION} --quiet"
2727
28-
#./test/retry.sh "gcloud run services describe ${_SERVICE} --region ${_REGION} --platform ${_PLATFORM}" \
29-
# "gcloud run services delete ${_SERVICE} --region ${_REGION} --platform ${_PLATFORM} --quiet"
28+
#./test/retry.sh "gcloud run services describe ${_SERVICE} --region ${_REGION} \
29+
# "gcloud run services delete ${_SERVICE} --region ${_REGION} --quiet"
3030
3131
substitutions:
3232
_SERVICE: system-package
3333
_VERSION: manual
3434
_REGION: us-central1
35-
_PLATFORM: managed
3635
_SERVICE_ACCOUNT: ${PROJECT_NUMBER}@cloudbuild.gserviceaccount.com
3736

3837
serviceAccount: 'projects/${PROJECT_ID}/serviceAccounts/${_SERVICE_ACCOUNT}'

run/system-package/test/e2e_test_setup.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ steps:
4242
--no-allow-unauthenticated \
4343
--add-custom-audiences 'https://action.test/' \
4444
--region ${_REGION} \
45-
--service-account ${_SERVICE_ACCOUNT} \
46-
--platform ${_PLATFORM}"
45+
--service-account ${_SERVICE_ACCOUNT}"
4746
4847
4948
images:
@@ -53,7 +52,6 @@ substitutions:
5352
_SERVICE: system-package
5453
_VERSION: manual
5554
_REGION: us-central1
56-
_PLATFORM: managed
5755
_SERVICE_ACCOUNT: ${PROJECT_NUMBER}@cloudbuild.gserviceaccount.com
5856

5957
serviceAccount: 'projects/${PROJECT_ID}/serviceAccounts/${_SERVICE_ACCOUNT}'

run/system-package/test/system.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ describe('End-to-End Tests', () => {
5353
let buildCmd =
5454
`gcloud builds submit --project ${GOOGLE_CLOUD_PROJECT} ` +
5555
'--config ./test/e2e_test_setup.yaml ' +
56-
`--substitutions _SERVICE=${SERVICE_NAME},_PLATFORM=${PLATFORM},_REGION=${REGION}`;
56+
`--substitutions _SERVICE=${SERVICE_NAME},_REGION=${REGION}`;
5757
if (SAMPLE_VERSION) buildCmd += `,_VERSION=${SAMPLE_VERSION}`;
5858
if (SERVICE_ACCOUNT) buildCmd += `,_SERVICE_ACCOUNT=${SERVICE_ACCOUNT}`;
5959

@@ -75,7 +75,7 @@ describe('End-to-End Tests', () => {
7575
let cleanUpCmd =
7676
`gcloud builds submit --project ${GOOGLE_CLOUD_PROJECT} ` +
7777
'--config ./test/e2e_test_cleanup.yaml ' +
78-
`--substitutions _SERVICE=${SERVICE_NAME},_PLATFORM=${PLATFORM},_REGION=${REGION}`;
78+
`--substitutions _SERVICE=${SERVICE_NAME},_REGION=${REGION}`;
7979
if (SAMPLE_VERSION) cleanUpCmd += `,_VERSION=${SAMPLE_VERSION}`;
8080
if (SERVICE_ACCOUNT) cleanUpCmd += `,_SERVICE_ACCOUNT=${SERVICE_ACCOUNT}`;
8181

0 commit comments

Comments
 (0)