Merge branch 'main' into tpu_queued_resources_startup_script

Author: glasnt

.github/blunderbuss.yml

@@ -40,6 +40,10 @@ assign_issues_by:
   - "api: routeoptimization"
   to:
   - GoogleCloudPlatform/geo-routeoptimization
+- labels:
+  - "api: parametermanager"
+  to:
+  - GoogleCloudPlatform/cloud-parameters-team
 
 assign_prs_by:
 - labels:
@@ -69,3 +73,7 @@ assign_prs_by:
   - "api: routeoptimization"
   to:
   - GoogleCloudPlatform/geo-routeoptimization
+- labels:
+  - "api: parametermanager"
+  to:
+  - GoogleCloudPlatform/cloud-parameters-team

.github/config/nodejs-dev.jsonc

@@ -146,9 +146,11 @@
     "functions/http/httpContent",
     "functions/http/httpMethods",
     "functions/http/parseXML",
+    "functions/imagemagick",
     "functions/log/helloWorld",
     "functions/log/processEntry",
     "functions/memorystore/redis",
+    "functions/ocr/app",
     "functions/pubsub/publish",
     "functions/pubsub/subscribe",
     "functions/scheduleinstance",
@@ -172,6 +174,7 @@
     "functions/v2/helloGCS",
     "functions/v2/helloPubSub",
     "functions/v2/httpLogging",
+    "functions/v2/imagemagick",
     "functions/v2/log/processEntry",
     "functions/v2/ocr/app",
     "functions/v2/responseStreaming",
@@ -214,6 +217,7 @@
     "texttospeech",
     "tpu",
     "translate",
+    "vision",
     "workflows/invoke-private-endpoint"
   ]
 }

.github/config/nodejs-prod.jsonc

@@ -89,16 +89,12 @@
     "dlp", // [ERR_REQUIRE_ESM]: require() of ES Module
     "document-ai", // [ERR_REQUIRE_ESM]: require() of ES Module
     "functions/billing", // (untested) Error: Request failed with status code 500
-    "functions/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage
-    "functions/ocr/app", // (untested) Error: Bucket not provided. Make sure you have a "bucket" property in your request
     "functions/slack", // TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type ... Received undefined
-    "functions/v2/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage.
     "healthcare/fhir", // Error: Cannot find module 'whatwg-url'
     "iam/deny", // PERMISSION_DENIED: Permission iam.googleapis.com/denypolicies.create denied on resource cloudresourcemanager.googleapis.com/projects/long-door-651
     "run/idp-sql", // (untested) Error: Invalid contents in the credentials file
     "storagetransfer", // CredentialsError: Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1
     "video-intelligence", // PERMISSION_DENIED: The caller does not have permission
-    "vision", // REDIS: Error: connect ECONNREFUSED 127.0.0.1:6379
     "workflows", // SyntaxError: Cannot use import statement outside a module
     "workflows/quickstart" // [ERR_MODULE_NOT_FOUND]: Cannot find package 'ts-node' imported from ...
   ]

.github/workflows/ai-platform-snippets.yaml

@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -82,7 +82,7 @@ jobs:
         CAIP_PROJECT_ID: ${{ steps.secrets.outputs.caip_id }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:

.github/workflows/appengine-analytics.yaml

@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: GoogleCloudPlatform/cloud-samples-tools
           ref: v0.2.1

.github/workflows/appengine-metadata-flexible.yaml

@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: GoogleCloudPlatform/cloud-samples-tools
           ref: v0.2.1
@@ -60,16 +60,51 @@ jobs:
           cat paths.txt
           echo "setups=$(./cloud-samples-tools/bin/custard setup-files .github/config/nodejs-prod.jsonc paths.txt)" >> $GITHUB_OUTPUT
 
-  nodejs-lint:
-    name: lint
+  lint:
+    needs: affected
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-      - uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
+      - name: Checkout
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
+      - name: Setup Node
+        uses: actions/setup-node@1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4
         with:
           node-version: 20
-      - run: make lint
+      - run: npm install
+      - name: Run lint
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7
+        with:
+          script: |
+            const { execSync } = await import("node:child_process");
+
+            const cmd = 'npx gts lint';
+            const affected = ${{ needs.affected.outputs.nodejs-paths }};
+            if (affected.length === 0) {
+              console.log("No packages were affected, nothing to lint.")
+            }
+
+            let failed = [];
+            for (const path of affected) {
+              try {
+                execSync(cmd, {cwd: path});
+                console.log(`✅ [${path}]: ${cmd}`);
+              } catch (e) {
+                failed.push(path)
+                console.log(`❌ [${path}]: ${cmd} (exit code ${e.status})`);
+                core.error(e.message);
+                console.log('--- stdout ---');
+                console.log(e.stdout.toString("utf8"));
+                console.log('--- stderr ---');
+                console.log(e.stderr.toString("utf8"));
+              }
+            }
+            console.log("=== Summary ===")
+            console.log(`  Passed: ${affected.length - failed.length}`)
+            console.log(`  Failed: ${failed.length}`)
+            if (failed.length > 0) {
+              core.setFailed(`Failed '${cmd}' on: ${failed.join(', ')}`)
+            }
 
   region-tags:
     name: region tags
@@ -82,8 +117,7 @@ jobs:
           node-version: 20
       - run: ./.github/workflows/utils/region-tags-tests.sh
 
-  nodejs-test:
-    name: test
+  test:
     needs: affected
     runs-on: ubuntu-latest
     timeout-minutes: 120 # 2 hours hard limit

.github/workflows/ci-dev.yaml renamed to .github/workflows/custard-ci-dev.yaml

@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -84,7 +84,7 @@ jobs:
         AGENT_PROJECT_ID: nodejs-docs-samples-tests
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:

.github/workflows/ci-prod.yaml renamed to .github/workflows/custard-ci.yaml

@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
           path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -83,7 +83,7 @@ jobs:
           KG_API_KEY: ${{ steps.secrets.outputs.kg_api_key }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
           MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with: