return nil if error

David Cavazos · David Cavazos · commit cc7fd6b040e1 · 2024-10-10T16:42:58.000-07:00
diff --git a/.github/cloud-samples-tools/pkg/config/config.go b/.github/cloud-samples-tools/pkg/config/config.go
@@ -72,12 +72,12 @@ func LoadConfig(path string) (*Config, error) {
 	var config Config
 	err = json.Unmarshal(sourceJson, &config)
 	if err != nil {
-		return &config, err
+		return nil, err
 	}
 
 	// Set default values if they are not set.
 	if config.PackageFile == nil {
-		return &config, errors.New("package-file is required")
+		return nil, errors.New("package-file is required")
 	}
 	if config.Match == nil {
 		config.Match = []string{"*"}

Original file line number	Diff line number	Diff line change
`@@ -72,12 +72,12 @@ func LoadConfig(path string) (*Config, error) {`
`72`	`72`	`var config Config`
`73`	`73`	`err = json.Unmarshal(sourceJson, &config)`
`74`	`74`	`if err != nil {`
`75`		`- return &config, err`
	`75`	`+ return nil, err`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// Set default values if they are not set.`
`79`	`79`	`if config.PackageFile == nil {`
`80`		`- return &config, errors.New("package-file is required")`
	`80`	`+ return nil, errors.New("package-file is required")`
`81`	`81`	`}`
`82`	`82`	`if config.Match == nil {`
`83`	`83`	`config.Match = []string{"*"}`