Skip to content

Commit ea7ffda

Browse files
durgesh-ninave-crestdurgesh-ninave-crest
committed
fix(parametermanager): update code samples and testcases
1 parent bb59279 commit ea7ffda

11 files changed

+258
-140
lines changed

‎parametermanager/deleteParam.js‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,22 @@ async function main(projectId = 'my-project', parameterId = 'my-parameter') {
4444
});
4545

4646
console.log(`Deleted parameter: ${name}`);
47+
return name;
4748
}
4849

49-
await deleteParam();
50+
return await deleteParam();
5051
// [END parametermanager_delete_param]
5152
}
53+
module.exports.main = main;
5254

53-
// The command-line arguments are passed as an array to main()
54-
const args = process.argv.slice(2);
55-
main(...args).catch(console.error);
55+
/* c8 ignore next 10 */
56+
if (require.main === module) {
57+
main(...process.argv.slice(2)).catch(err => {
58+
console.error(err.message);
59+
process.exitCode = 1;
60+
});
61+
process.on('unhandledRejection', err => {
62+
console.error(err.message);
63+
process.exitCode = 1;
64+
});
65+
}

‎parametermanager/deleteParamVersion.js‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,23 @@ async function main(
5454
await client.deleteParameterVersion({
5555
name: name,
5656
});
57-
5857
console.log(`Deleted parameter version: ${name}`);
58+
return name;
5959
}
6060

61-
await deleteParamVersion();
61+
return await deleteParamVersion();
6262
// [END parametermanager_delete_param_version]
6363
}
64+
module.exports.main = main;
6465

65-
// The command-line arguments are passed as an array to main()
66-
const args = process.argv.slice(2);
67-
main(...args).catch(console.error);
66+
/* c8 ignore next 10 */
67+
if (require.main === module) {
68+
main(...process.argv.slice(2)).catch(err => {
69+
console.error(err.message);
70+
process.exitCode = 1;
71+
});
72+
process.on('unhandledRejection', err => {
73+
console.error(err.message);
74+
process.exitCode = 1;
75+
});
76+
}

‎parametermanager/disableParamVersion.js‎

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,27 @@ async function main(
6363
};
6464

6565
// Make the API call to update the parameter version
66-
const [response] = await client.updateParameterVersion(request);
66+
const [parameterVersion] = await client.updateParameterVersion(request);
6767

6868
console.log(
69-
`Disabled parameter version ${response.name} for parameter ${parameterId}`
69+
`Disabled parameter version ${parameterVersion.name} for parameter ${parameterId}`
7070
);
71-
return response;
71+
return parameterVersion;
7272
}
7373

74-
await disableParamVersion();
74+
return await disableParamVersion();
7575
// [END parametermanager_disable_param_version]
7676
}
77+
module.exports.main = main;
7778

78-
// The command-line arguments are passed as an array to main().
79-
const args = process.argv.slice(2);
80-
main(...args).catch(console.error);
79+
/* c8 ignore next 10 */
80+
if (require.main === module) {
81+
main(...process.argv.slice(2)).catch(err => {
82+
console.error(err.message);
83+
process.exitCode = 1;
84+
});
85+
process.on('unhandledRejection', err => {
86+
console.error(err.message);
87+
process.exitCode = 1;
88+
});
89+
}

‎parametermanager/enableParamVersion.js‎

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,27 @@ async function main(
6363
};
6464

6565
// Make the API call to update the parameter version
66-
const [response] = await client.updateParameterVersion(request);
66+
const [parameterVersion] = await client.updateParameterVersion(request);
6767

6868
console.log(
69-
`Enabled parameter version ${response.name} for parameter ${parameterId}`
69+
`Enabled parameter version ${parameterVersion.name} for parameter ${parameterId}`
7070
);
71-
return response;
71+
return parameterVersion;
7272
}
7373

74-
await enableParamVersion();
74+
return await enableParamVersion();
7575
// [END parametermanager_enable_param_version]
7676
}
77+
module.exports.main = main;
7778

78-
// The command-line arguments are passed as an array to main().
79-
const args = process.argv.slice(2);
80-
main(...args).catch(console.error);
79+
/* c8 ignore next 10 */
80+
if (require.main === module) {
81+
main(...process.argv.slice(2)).catch(err => {
82+
console.error(err.message);
83+
process.exitCode = 1;
84+
});
85+
process.on('unhandledRejection', err => {
86+
console.error(err.message);
87+
process.exitCode = 1;
88+
});
89+
}

‎parametermanager/quickstart.js‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,17 +81,27 @@ async function main(
8181
console.log(`Created parameter version: ${parameterVersion.name}`);
8282

8383
// Get the parameter version
84-
const [response] = await client.getParameterVersion({
84+
const [paramVersion] = await client.getParameterVersion({
8585
name: parameterVersion.name,
8686
});
87-
console.log(`Retrieved parameter version: ${response.name}`);
88-
console.log('Payload:', response.payload.data.toString('utf8'));
87+
console.log(`Retrieved parameter version: ${paramVersion.name}`);
88+
console.log('Payload:', paramVersion.payload.data.toString('utf8'));
89+
return paramVersion;
8990
}
9091

91-
await quickstart();
92+
return await quickstart();
9293
// [END parametermanager_quickstart]
9394
}
95+
module.exports.main = main;
9496

95-
// The command-line arguments are passed as an array to main()
96-
const args = process.argv.slice(2);
97-
main(...args).catch(console.error);
97+
/* c8 ignore next 10 */
98+
if (require.main === module) {
99+
main(...process.argv.slice(2)).catch(err => {
100+
console.error(err.message);
101+
process.exitCode = 1;
102+
});
103+
process.on('unhandledRejection', err => {
104+
console.error(err.message);
105+
process.exitCode = 1;
106+
});
107+
}

‎parametermanager/regional_samples/deleteRegionalParam.js‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,22 @@ async function main(
5656
});
5757

5858
console.log(`Deleted regional parameter: ${name}`);
59+
return name;
5960
}
6061

61-
await deleteRegionalParam();
62+
return await deleteRegionalParam();
6263
// [END parametermanager_delete_regional_param]
6364
}
65+
module.exports.main = main;
6466

65-
// The command-line arguments are passed as an array to main()
66-
const args = process.argv.slice(2);
67-
main(...args).catch(console.error);
67+
/* c8 ignore next 10 */
68+
if (require.main === module) {
69+
main(...process.argv.slice(2)).catch(err => {
70+
console.error(err.message);
71+
process.exitCode = 1;
72+
});
73+
process.on('unhandledRejection', err => {
74+
console.error(err.message);
75+
process.exitCode = 1;
76+
});
77+
}

‎parametermanager/regional_samples/deleteRegionalParamVersion.js‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,23 @@ async function main(
6262
await client.deleteParameterVersion({
6363
name: name,
6464
});
65-
6665
console.log(`Deleted regional parameter version: ${name}`);
66+
return name;
6767
}
6868

69-
await deleteRegionalParamVersion();
69+
return await deleteRegionalParamVersion();
7070
// [END parametermanager_delete_regional_param_version]
7171
}
72+
module.exports.main = main;
7273

73-
// The command-line arguments are passed as an array to main()
74-
const args = process.argv.slice(2);
75-
main(...args).catch(console.error);
74+
/* c8 ignore next 10 */
75+
if (require.main === module) {
76+
main(...process.argv.slice(2)).catch(err => {
77+
console.error(err.message);
78+
process.exitCode = 1;
79+
});
80+
process.on('unhandledRejection', err => {
81+
console.error(err.message);
82+
process.exitCode = 1;
83+
});
84+
}

‎parametermanager/regional_samples/disableRegionalParamVersion.js‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,17 +73,27 @@ async function main(
7373
};
7474

7575
// Make the API call to update the parameter version
76-
const [response] = await client.updateParameterVersion(request);
76+
const [paramVersion] = await client.updateParameterVersion(request);
7777

7878
console.log(
79-
`Disabled regional parameter version ${response.name} for parameter ${parameterId}`
79+
`Disabled regional parameter version ${paramVersion.name} for parameter ${parameterId}`
8080
);
81-
return response;
81+
return paramVersion;
8282
}
8383

84-
await disableRegionalParamVersion();
84+
return await disableRegionalParamVersion();
8585
// [END parametermanager_disable_regional_param_version]
8686
}
87+
module.exports.main = main;
8788

88-
// The command-line arguments are passed as an array to main().
89-
main(...process.argv.slice(2)).catch(console.error);
89+
/* c8 ignore next 10 */
90+
if (require.main === module) {
91+
main(...process.argv.slice(2)).catch(err => {
92+
console.error(err.message);
93+
process.exitCode = 1;
94+
});
95+
process.on('unhandledRejection', err => {
96+
console.error(err.message);
97+
process.exitCode = 1;
98+
});
99+
}

‎parametermanager/regional_samples/enableRegionalParamVersion.js‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,27 @@ async function main(
7171
};
7272

7373
// Make the API call to update the parameter version
74-
const [response] = await client.updateParameterVersion(request);
74+
const [paramVersion] = await client.updateParameterVersion(request);
7575

7676
console.log(
77-
`Enabled regional parameter version ${response.name} for parameter ${parameterId}`
77+
`Enabled regional parameter version ${paramVersion.name} for parameter ${parameterId}`
7878
);
79-
return response;
79+
return paramVersion;
8080
}
8181

82-
await enableRegionalParamVersion();
82+
return await enableRegionalParamVersion();
8383
// [END parametermanager_enable_regional_param_version]
8484
}
85+
module.exports.main = main;
8586

86-
// The command-line arguments are passed as an array to main().
87-
main(...process.argv.slice(2)).catch(console.error);
87+
/* c8 ignore next 10 */
88+
if (require.main === module) {
89+
main(...process.argv.slice(2)).catch(err => {
90+
console.error(err.message);
91+
process.exitCode = 1;
92+
});
93+
process.on('unhandledRejection', err => {
94+
console.error(err.message);
95+
process.exitCode = 1;
96+
});
97+
}

‎parametermanager/regional_samples/regionalQuickstart.js‎

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,17 +83,27 @@ async function main(
8383
console.log(`Created regional parameter version: ${parameterVersion.name}`);
8484

8585
// Get the parameter version
86-
const [response] = await client.getParameterVersion({
86+
const [paramVersion] = await client.getParameterVersion({
8787
name: parameterVersion.name,
8888
});
89-
console.log(`Retrieved regional parameter version: ${response.name}`);
90-
console.log('Payload:', response.payload.data.toString('utf8'));
89+
console.log(`Retrieved regional parameter version: ${paramVersion.name}`);
90+
console.log('Payload:', paramVersion.payload.data.toString('utf8'));
91+
return paramVersion;
9192
}
9293

93-
await regionalQuickstart();
94+
return await regionalQuickstart();
9495
// [END parametermanager_regional_quickstart]
9596
}
97+
module.exports.main = main;
9698

97-
// The command-line arguments are passed as an array to main()
98-
const args = process.argv.slice(2);
99-
main(...args).catch(console.error);
99+
/* c8 ignore next 10 */
100+
if (require.main === module) {
101+
main(...process.argv.slice(2)).catch(err => {
102+
console.error(err.message);
103+
process.exitCode = 1;
104+
});
105+
process.on('unhandledRejection', err => {
106+
console.error(err.message);
107+
process.exitCode = 1;
108+
});
109+
}

0 commit comments

Comments
 (0)