Skip to content

Commit ece26d6

Browse files
fix(parametermanager): Fixed test cases
1 parent 9bcebd3 commit ece26d6

File tree

5 files changed

+2
-13
lines changed

5 files changed

+2
-13
lines changed

parameter-manager/listParamVersions.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ async function main(projectId = 'my-project', parameterId = 'my-parameter') {
4747
// Use listParameterVersionsAsync to handle pagination automatically
4848
const iterable = await client.listParameterVersionsAsync(request);
4949

50-
console.log(`Parameter versions for ${parameterId}:`);
5150
for await (const version of iterable) {
5251
console.log(
5352
`Found parameter version ${version.name} with state ${version.disabled ? 'disabled' : 'enabled'}`

parameter-manager/listParams.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ async function main(projectId = 'my-project') {
4444
// Use listParametersAsync to handle pagination automatically
4545
const iterable = await client.listParametersAsync(request);
4646

47-
console.log('Parameters:');
4847
for await (const parameter of iterable) {
4948
console.log(
5049
`Found parameter ${parameter.name} with format ${parameter.format}`

parameter-manager/regional_samples/listRegionalParamVersions.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ async function main(
5757
// Use listParameterVersionsAsync to handle pagination automatically
5858
const iterable = await client.listParameterVersionsAsync(request);
5959

60-
console.log(`Parameter versions for ${parameterId} in ${locationId}:`);
6160
for await (const version of iterable) {
6261
console.log(
6362
`Found regional parameter version ${version.name} with state ${version.disabled ? 'disabled' : 'enabled'} `

parameter-manager/regional_samples/listRegionalParams.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ async function main(projectId = 'my-project', locationId = 'us-central1') {
5151
// Use listParametersAsync to handle pagination automatically
5252
const iterable = await client.listParametersAsync(request);
5353

54-
console.log(`Parameters in ${locationId}:`);
5554
for await (const parameter of iterable) {
5655
console.log(
5756
`Found regional parameter ${parameter.name} with format ${parameter.format}`

parameter-manager/test/parametermanager.test.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,6 @@ describe('Parameter Manager samples', () => {
305305

306306
it('should list parameters', async () => {
307307
const output = execSync(`node listParams.js ${projectId}`);
308-
assert.include(output, 'Parameters:');
309308
assert.include(
310309
output,
311310
`Found parameter ${parameter.name} with format ${parameter.format}`
@@ -324,7 +323,6 @@ describe('Parameter Manager samples', () => {
324323
const output = execSync(
325324
`node regional_samples/listRegionalParams.js ${projectId} ${locationId}`
326325
);
327-
assert.include(output, `Parameters in ${locationId}:`);
328326
assert.include(
329327
output,
330328
`Found regional parameter ${regionalParameter.name} with format ${regionalParameter.format}`
@@ -381,7 +379,6 @@ describe('Parameter Manager samples', () => {
381379
const output = execSync(
382380
`node listParamVersions.js ${projectId} ${parameterId}`
383381
);
384-
assert.include(output, `Parameter versions for ${parameterId}:`);
385382
assert.include(
386383
output,
387384
`Found parameter version ${parameterVersion.name} with state disabled`
@@ -396,10 +393,6 @@ describe('Parameter Manager samples', () => {
396393
const output = execSync(
397394
`node regional_samples/listRegionalParamVersions.js ${projectId} ${locationId} ${regionalParameterId}`
398395
);
399-
assert.include(
400-
output,
401-
`Parameter versions for ${regionalParameterId} in ${locationId}:`
402-
);
403396
assert.include(
404397
output,
405398
`Found regional parameter version ${regionalParameterVersion.name} with state disabled`
@@ -428,7 +421,7 @@ describe('Parameter Manager samples', () => {
428421
);
429422
assert.include(
430423
output,
431-
'Payload: {"db_user":"test_user","db_password":"__REF__(//secretmanager.googleapis.com/projects/385768059301/secrets/test-secret-91cd9792-5f13-47c5-85ba-6622682f0035/versions/1)"}'
424+
`Payload: {"db_user":"test_user","db_password":"__REF__(//secretmanager.googleapis.com/${secretVersion.name})"}`
432425
);
433426
});
434427

@@ -450,7 +443,7 @@ describe('Parameter Manager samples', () => {
450443
);
451444
assert.include(
452445
output,
453-
'Payload: {"db_user":"test_user","db_password":"__REF__("//secretmanager.googleapis.com/projects/385768059301/locations/us-central1/secrets/test-secret-91cd9792-5f13-47c5-85ba-6622682f0035/versions/1")"}'
446+
`Payload: {"db_user":"test_user","db_password":"__REF__(\\"//secretmanager.googleapis.com/${regionalSecretVersion.name}\\")"}`
454447
);
455448
});
456449

0 commit comments

Comments
 (0)