Merge branch 'main' into hivanalejandro/bigquery/create-sample/view-dataset-access-policy

hivanalejandro · web-flow · commit f6a685dc51e2 · 2025-03-05T15:46:02.000Z
diff --git a/.github/blunderbuss.yml b/.github/blunderbuss.yml
@@ -40,6 +40,10 @@ assign_issues_by:
   - "api: routeoptimization"
   to:
   - GoogleCloudPlatform/geo-routeoptimization
+- labels:
+  - "api: parametermanager"
+  to:
+  - GoogleCloudPlatform/cloud-parameters-team
 
 assign_prs_by:
 - labels:
@@ -69,3 +73,7 @@ assign_prs_by:
   - "api: routeoptimization"
   to:
   - GoogleCloudPlatform/geo-routeoptimization
+- labels:
+  - "api: parametermanager"
+  to:
+  - GoogleCloudPlatform/cloud-parameters-team
diff --git a/.github/config/nodejs-dev.jsonc b/.github/config/nodejs-dev.jsonc
@@ -191,6 +191,7 @@
     "mediatranslation",
     "monitoring/prometheus",
     "monitoring/snippets",
+    "recaptcha_enterprise/snippets",
     "retail",
     "routeoptimization/snippets",
     "run/hello-broken",
@@ -206,6 +207,7 @@
     "secret-manager",
     "security-center/snippets",
     "service-directory/snippets",
+    "scheduler",
     "storage-control",
     "speech",
     "talent",
diff --git a/.github/config/nodejs-prod.jsonc b/.github/config/nodejs-prod.jsonc
@@ -95,9 +95,7 @@
     "functions/v2/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage.
     "healthcare/fhir", // Error: Cannot find module 'whatwg-url'
     "iam/deny", // PERMISSION_DENIED: Permission iam.googleapis.com/denypolicies.create denied on resource cloudresourcemanager.googleapis.com/projects/long-door-651
-    "recaptcha_enterprise/snippets", // Cannot use import statement outside a module
     "run/idp-sql", // (untested) Error: Invalid contents in the credentials file
-    "scheduler", // SyntaxError: Cannot use import statement outside a module
     "storagetransfer", // CredentialsError: Missing credentials in config, if using AWS_CONFIG_FILE, set AWS_SDK_LOAD_CONFIG=1
     "video-intelligence", // PERMISSION_DENIED: The caller does not have permission
     "vision", // REDIS: Error: connect ECONNREFUSED 127.0.0.1:6379
diff --git a/.github/workflows/ai-platform-snippets.yaml b/.github/workflows/ai-platform-snippets.yaml
@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -82,7 +82,7 @@ jobs:
         CAIP_PROJECT_ID: ${{ steps.secrets.outputs.caip_id }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
diff --git a/.github/workflows/ci-dev.yaml b/.github/workflows/ci-dev.yaml
@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: GoogleCloudPlatform/cloud-samples-tools
           ref: v0.2.1
diff --git a/.github/workflows/ci-prod.yaml b/.github/workflows/ci-prod.yaml
@@ -37,7 +37,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           fetch-depth: 0
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
         with:
           repository: GoogleCloudPlatform/cloud-samples-tools
           ref: v0.2.1
diff --git a/.github/workflows/dialogflow-cx.yaml b/.github/workflows/dialogflow-cx.yaml
@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -84,7 +84,7 @@ jobs:
         AGENT_PROJECT_ID: nodejs-docs-samples-tests
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
diff --git a/.github/workflows/functions-slack.yaml b/.github/workflows/functions-slack.yaml
@@ -62,7 +62,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
           path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -83,7 +83,7 @@ jobs:
           KG_API_KEY: ${{ steps.secrets.outputs.kg_api_key }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
           MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
diff --git a/.github/workflows/iam-deny.yaml b/.github/workflows/iam-deny.yaml
@@ -60,7 +60,7 @@ jobs:
          id: npm-cache-dir
          shell: bash
          run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-       - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+       - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
          id: npm-cache
          with:
           path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -81,7 +81,7 @@ jobs:
        - run: npm test
        - name: upload test results for FlakyBot workflow
          if: github.event.action == 'schedule' && always()
-         uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+         uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
          env:
           MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
          with:
diff --git a/.github/workflows/storagetransfer.yaml b/.github/workflows/storagetransfer.yaml
@@ -65,7 +65,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -92,7 +92,7 @@ jobs:
         AZURE_SAS_TOKEN: ${{ fromJSON(steps.secrets.outputs.sts_azure_secret).SAS }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -47,7 +47,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -67,7 +67,7 @@ jobs:
         GOOGLE_SAMPLES_PROJECT: "long-door-651"
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       with:
         name: test-results
         path: ${{ inputs.path }}/${{ env.MOCHA_REPORTER_OUTPUT }}
diff --git a/.github/workflows/vision.yaml b/.github/workflows/vision.yaml
@@ -64,7 +64,7 @@ jobs:
       id: npm-cache-dir
       shell: bash
       run: echo "dir=$(npm config get cache)" >> ${GITHUB_OUTPUT}
-    - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4
+    - uses: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf # v4
       id: npm-cache
       with:
         path: ${{ steps.npm-cache-dir.outputs.dir }}
@@ -87,7 +87,7 @@ jobs:
         REDIS_HOST: ${{ steps.secrets.outputs.vision.REDIS_HOST }}
     - name: upload test results for FlakyBot workflow
       if: github.event.action == 'schedule' && always()
-      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4
+      uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4
       env:
         MOCHA_REPORTER_OUTPUT: "${{github.run_id}}_sponge_log.xml"
       with:
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -23,6 +23,7 @@ orgpolicy @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-rev
 recaptcha_enterprise @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers
 recaptcha_enterprise/demosite @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/recaptcha-customer-obsession-reviewers @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers
 secret-manager @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers @GoogleCloudPlatform/cloud-secrets-team
+parametermanager @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers @GoogleCloudPlatform/cloud-secrets-team @GoogleCloudPlatform/cloud-parameters-team
 service-directory @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers
 tpu @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers
 webrisk @GoogleCloudPlatform/dee-infra @GoogleCloudPlatform/nodejs-samples-reviewers @GoogleCloudPlatform/cloud-samples-reviewers
diff --git a/parametermanager/README.md b/parametermanager/README.md
@@ -0,0 +1 @@
+### Initial README.md placeholder file.
diff --git a/recaptcha_enterprise/snippets/package.json b/recaptcha_enterprise/snippets/package.json
@@ -4,6 +4,7 @@
   "main": "quickstart.js",
   "license": "Apache-2.0",
   "author": "Google LLC",
+  "type": "module",
   "engines": {
     "node": ">=16.0.0"
   },
diff --git a/recaptcha_enterprise/snippets/passwordLeakAssessment.js b/recaptcha_enterprise/snippets/passwordLeakAssessment.js
@@ -29,10 +29,8 @@ const [projectId, username, password] = args;
 
 // [START recaptcha_enterprise_password_leak_verification]
 
-const {
-  RecaptchaEnterpriseServiceClient,
-} = require('@google-cloud/recaptcha-enterprise');
-const {PasswordCheckVerification} = require('recaptcha-password-check-helpers');
+import {RecaptchaEnterpriseServiceClient} from '@google-cloud/recaptcha-enterprise';
+import {PasswordCheckVerification} from 'recaptcha-password-check-helpers';
 
 // TODO(developer): Uncomment and set the following variables
 // Google Cloud Project ID.
@@ -168,3 +166,4 @@ checkPasswordLeak(projectId, username, password).catch(err => {
   process.exitCode = 1;
 });
 // [END recaptcha_enterprise_password_leak_verification]
+module.exports = checkPasswordLeak
diff --git a/recaptcha_enterprise/snippets/tsconfig.json b/recaptcha_enterprise/snippets/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "noImplicitAny": false,
     "esModuleInterop": true,
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "module": "ESNext"
   }
 }
diff --git a/scheduler/createJob.js b/scheduler/createJob.js
@@ -14,60 +14,50 @@
 
 // This is a generated sample, using the typeless sample bot. Please
 // look for the source TypeScript sample (.ts) for modifications.
-'use strict';
 
 // sample-metadata:
 //   title: Create Job
 //   description: Create a job that posts to /log_payload on an App Engine service.
 //   usage: node createJob.js [project-id] [location-id] [app-engine-service-id]
-
 const args = process.argv.slice(2);
 const [projectId, locationId, serviceId] = args;
-
 // [START cloudscheduler_create_job]
-const {CloudSchedulerClient} = require('@google-cloud/scheduler');
-
+import { CloudSchedulerClient } from '@google-cloud/scheduler';
 // TODO(developer): Uncomment and set the following variables
 // const projectId = "PROJECT_ID"
 // const locationId = "LOCATION_ID"
 // const serviceId = "my-serivce"
-
 // Create a client.
 const client = new CloudSchedulerClient();
-
 /**
  * Create a job with an App Engine target via the Cloud Scheduler API
  */
 async function createJob(projectId, locationId, serviceId) {
-  // Construct the fully qualified location path.
-  const parent = client.locationPath(projectId, locationId);
-
-  // Construct the request body.
-  const job = {
-    appEngineHttpTarget: {
-      appEngineRouting: {
-        service: serviceId,
-      },
-      relativeUri: '/log_payload',
-      httpMethod: 'POST',
-      body: Buffer.from('Hello World'),
-    },
-    schedule: '* * * * *',
-    timeZone: 'America/Los_Angeles',
-  };
-
-  const request = {
-    parent: parent,
-    job: job,
-  };
-
-  // Use the client to send the job creation request.
-  const [response] = await client.createJob(request);
-  console.log(`Created job: ${response.name}`);
+    // Construct the fully qualified location path.
+    const parent = client.locationPath(projectId, locationId);
+    // Construct the request body.
+    const job = {
+        appEngineHttpTarget: {
+            appEngineRouting: {
+                service: serviceId,
+            },
+            relativeUri: '/log_payload',
+            httpMethod: 'POST',
+            body: Buffer.from('Hello World'),
+        },
+        schedule: '* * * * *',
+        timeZone: 'America/Los_Angeles',
+    };
+    const request = {
+        parent: parent,
+        job: job,
+    };
+    // Use the client to send the job creation request.
+    const [response] = await client.createJob(request);
+    console.log(`Created job: ${response.name}`);
 }
-
 createJob(projectId, locationId, serviceId).catch(err => {
-  console.error(err.message);
-  process.exitCode = 1;
+    console.error(err.message);
+    process.exitCode = 1;
 });
 // [END cloudscheduler_create_job]
diff --git a/scheduler/package.json b/scheduler/package.json
@@ -2,6 +2,7 @@
   "name": "nodejs-scheduler-samples",
   "private": true,
   "main": "quickstart.js",
+  "type": "module",
   "engines": {
     "node": ">=16.0.0"
   },
@@ -14,7 +15,7 @@
     "build": "tsc -p .",
     "fix": "gts fix",
     "lint": "gts lint",
-    "test": "c8 mocha -p -j 2 --loader=ts-node/esm --extension ts --timeout 10000 --exit"
+    "test": "c8 mocha -p -j 2 --loader=ts-node/esm --extension ts --timeout 20000 --exit"
   },
   "dependencies": {
     "@google-cloud/scheduler": "^4.0.0"
diff --git a/scheduler/tsconfig.json b/scheduler/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "noImplicitAny": false,
     "esModuleInterop": true,
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "module": "ESNext"
   }
 }
diff --git a/tpu/package.json b/tpu/package.json
@@ -21,4 +21,4 @@
     "c8": "^10.0.0",
     "mocha": "^10.0.0"
   }
-}
+}
diff --git a/tpu/queuedResources/createQueuedResource.js b/tpu/queuedResources/createQueuedResource.js
diff --git a/tpu/queuedResources/deleteQueuedResource.js b/tpu/queuedResources/deleteQueuedResource.js
diff --git a/tpu/queuedResources/forceDeleteQueuedResource.js b/tpu/queuedResources/forceDeleteQueuedResource.js
diff --git a/tpu/queuedResources/getQueuedResource.js b/tpu/queuedResources/getQueuedResource.js
diff --git a/tpu/queuedResources/getQueuedResourcesList.js b/tpu/queuedResources/getQueuedResourcesList.js
diff --git a/tpu/test/forceDeleteQueuedResource.test.js b/tpu/test/forceDeleteQueuedResource.test.js
diff --git a/tpu/test/queuedResource.test.js b/tpu/test/queuedResource.test.js
