Skip to content

Conversation

@agggaurav2024
Copy link
Contributor

…Modules

Description

Fixes # b/347347535, b/347347099, b/347347752, b/347347654, b/347347169
This PR adds SCC Managament API Org Security Health Analytics Custom Module Code Samples for List, ListDescendant, ListEffective, Delete and Simulate.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@agggaurav2024 agggaurav2024 requested review from a team as code owners February 14, 2025 06:55
@snippet-bot
Copy link

snippet-bot bot commented Feb 14, 2025

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: securitycenter Issues related to the Security Command Center API. samples Issues that are directly related to samples. labels Feb 14, 2025
customModuleId: customModuleId,
customModuleName: createResponse.displayName,
};
sharedModuleIds.push(customModuleId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delete SHA sample code will delete the sample, hence this line is no longer required.

@glasnt glasnt self-assigned this Mar 5, 2025
Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from language standards perspective.

Pending review from @GoogleCloudPlatform/gcp-security-command-center as subject matter experts for this new sample

@glasnt glasnt merged commit 39d49d7 into main Mar 11, 2025
12 checks passed
@glasnt glasnt deleted the ssc-management-api-sha-samples branch March 11, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: securitycenter Issues related to the Security Command Center API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants