-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(securitycenter): Add Resource SCC Management API Org SHA Custom … #3978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Here is the summary of changes. You are about to add 5 region tags.
This comment is generated by snippet-bot.
|
| customModuleId: customModuleId, | ||
| customModuleName: createResponse.displayName, | ||
| }; | ||
| sharedModuleIds.push(customModuleId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why this was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The delete SHA sample code will delete the sample, hence this line is no longer required.
glasnt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from language standards perspective.
Pending review from @GoogleCloudPlatform/gcp-security-command-center as subject matter experts for this new sample
…Modules
Description
Fixes # b/347347535, b/347347099, b/347347752, b/347347654, b/347347169
This PR adds SCC Managament API Org Security Health Analytics Custom Module Code Samples for List, ListDescendant, ListEffective, Delete and Simulate.
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.