Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Feb 24, 2025

WIP

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels Feb 24, 2025
@glasnt glasnt changed the title fix(dlp): onboard to testing-isolation ci(dlp): onboard to testing-isolation Feb 25, 2025
@glasnt
Copy link
Contributor Author

glasnt commented Feb 28, 2025

This PR is failing with multiple 'ERR_REQUIRE_ESM' issues, and potentially some missing expected resource issues.

@glasnt
Copy link
Contributor Author

glasnt commented Mar 6, 2025

Tests fail with the use of require(), they also fail because you cannot use import except in the header (not within the function definition as we do for clarity in sample embeddings.

@glasnt glasnt closed this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant