Skip to content

ci(dlp): onboard to testing-isolation #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glasnt wants to merge 24 commits into from
Closed

ci(dlp): onboard to testing-isolation #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
397da16
fix(dlp): onboard to testing-isolation
glasnt Feb 24, 2025
50a1df6
noop: make a change to force the tests to run
glasnt Feb 24, 2025
c4609ea
set Node version in CI
glasnt Feb 24, 2025
a6d5e3e
change node version to 18
glasnt Feb 25, 2025
31d8d6f
debug: bulk update exports
glasnt Feb 25, 2025
a7466cc
debug: bulk update const
glasnt Feb 25, 2025
0aff6bb
Revert "debug: bulk update exports"
glasnt Feb 25, 2025
4035498
Revert "debug: bulk update const"
glasnt Feb 25, 2025
b98e04d
Reapply "debug: bulk update exports"
glasnt Feb 25, 2025
7465416
Reapply "debug: bulk update const"
glasnt Feb 25, 2025
8f8a97b
update type in package.json
glasnt Feb 25, 2025
51d5603
Revert "update type in package.json"
glasnt Feb 25, 2025
5ccdb2b
Revert "Reapply "debug: bulk update const""
glasnt Feb 25, 2025
74a6ba1
Revert "Reapply "debug: bulk update exports""
glasnt Feb 25, 2025
a43a576
add test to dev
glasnt Mar 3, 2025
ce2176a
Merge branch 'main' into ariwete-dlp
glasnt Mar 4, 2025
3d3e63c
migrate to esmodules
glasnt Mar 6, 2025
735e876
Merge branch 'main' into ariwete-dlp
glasnt Mar 6, 2025
a65f43c
bulk import fix
glasnt Mar 6, 2025
6cd98c5
bulk fix
glasnt Mar 6, 2025
fb5b5b2
import update
glasnt Mar 6, 2025
f84eba4
Revert "import update"
glasnt Mar 6, 2025
70351ed
Revert "bulk fix"
glasnt Mar 6, 2025
4a2756c
Revert "bulk import fix"
glasnt Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/config/nodejs-dev.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@
"datalabeling",
"dialogflow",
"discoveryengine",
"dlp",
"document-warehouse",
"endpoints/getting-started",
"endpoints/getting-started-grpc",
Expand Down
1 change: 0 additions & 1 deletion .github/config/nodejs-prod.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
"dataproc", // GoogleError: Error submitting create cluster request: Multiple validation errors
"datastore/functions", // [ERR_REQUIRE_ESM]: require() of ES Module
"dialogflow-cx", // NOT_FOUND: com.google.apps.framework.request.NotFoundException: Agent 'undefined' does not exist
"dlp", // [ERR_REQUIRE_ESM]: require() of ES Module
"document-ai", // [ERR_REQUIRE_ESM]: require() of ES Module
"functions/billing", // (untested) Error: Request failed with status code 500
"functions/imagemagick", // (untested) Error: A bucket name is needed to use Cloud Storage
Expand Down
3 changes: 3 additions & 0 deletions dlp/ci-setup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"node-version": 18
}
1 change: 1 addition & 0 deletions dlp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"files": [
"*.js"
],
"type": "module",
"engines": {
"node": ">=16.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion dlp/resources/harmless.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This file is mostly harmless.
This file is mostly harmless...
Loading
Loading