ci(idp-sql): run idp-sql tests in testing isolation #3985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
This reverts commit 00e8114.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
glasnt
commented
Mar 24, 2025
| "test": "c8 mocha -p -j 2 test/app.test.js --timeout=120000 --exit", | ||
| "system-test": "c8 mocha -p -j 2 test/system.test.js --timeout=1800000 --exit" | ||
| "unit-test": "c8 mocha -p -j 2 test/app.test.js --timeout=120000 --exit", | ||
| "system-test": "test/proxy-setup.sh && c8 mocha -p -j 2 test/system.test.js --timeout=1800000 --exit", |
Contributor
Author
There was a problem hiding this comment.
The test/proxy-setup.sh powers this test; unsure if there's something more more scalable that can be done here.
NimJay
approved these changes
Mar 24, 2025
briandorsey
approved these changes
Mar 24, 2025
Contributor
briandorsey
left a comment
briandorsey
left a comment
There was a problem hiding this comment.
LGTM. Huge thanks for all the behind the scenes work getting these tests to run!
rudrakhsha-crest
pushed a commit
to rudrakhsha-crest/nodejs-docs-samples
that referenced
this pull request
Apr 18, 2025
…orm#3985) * ci(idp-sql): run idp-sql tests in testing isolation * add secret * update tests run, copied from eventarc/audit-storage * debug: swap order * Revert "debug: swap order" This reverts commit 00e8114. * debug: update firebase-admin version * add env, secrets * correct exit code on retry * dynamic service name * wip: pass service account as env, to test * logging: CLOUD_LOGGING_ONLY * correct YAML is useful * dynamicsubtitutions * rename token as not to confuse with new default envvar * use new envvar * update SA usage * add custom audience * cleanup * remove platform, extra SA var * lint * more lint * format * add sample version value * correct audience * lint * disable cleanup for debugging * add test to dev list * attempt proxy powered * lint * attempt: proxy shell * lint * format * try using x-headers * fix: headers * pass db user/name if supplied * revert "try using x-headers" * debugging: where 400 error coming from? * reenable cleanup * try capturing the token error * lint * use explicitly named secret reference * restore: try x-headers (debug) * Revert "restore: try x-headers (debug)" This reverts commit a0bcccf. * revert custom audience (not required if not using ID_TOKEN)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proof of concept migration to Custard CI
Secret
nodejs-docs-samples-idp-keyupdated to store the IDP from that project, but long-door-651-idp-key updated to store the IDP key from that project (unsure if idp-key is used from another test, but making the name explicit).Checklist