Skip to content

Conversation

@m-strzelczyk
Copy link
Contributor

Description

Fixes b/396449050

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: tpu Issues related to the Cloud TPU API. samples Issues that are directly related to samples. labels Mar 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @m-strzelczyk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the TPU samples to use TPUv5e. Specifically, it modifies the tpuType and tpuSoftwareVersion variables in several files to reflect the new TPU version. Additionally, the zone is updated from us-central1-f to us-central1-a in several files related to queued resources.

Highlights

  • TPU Version Update: The samples are updated to use TPUv5e by changing the tpuType from v2-8 to v5litepod-4 and the tpuSoftwareVersion from tpu-vm-tf-2.17.0-pod-pjrt or tpu-vm-tf-2.14.1 to v2-tpuv5-litepod.
  • Zone Update: The zone for queued resources is updated from us-central1-f to us-central1-a.

Changelog

Click here to see the changelog
  • tpu/createStartupScriptVM.js
    • Updated tpuType from v2-8 to v5litepod-4 (line 53).
    • Updated tpuSoftwareVersion from tpu-vm-tf-2.17.0-pod-pjrt to v2-tpuv5-litepod (line 57).
  • tpu/createTopologyVM.js
    • Updated tpuSoftwareVersion from tpu-vm-tf-2.17.0-pod-pjrt to v2-tpuv5-litepod (line 54).
  • tpu/createVM.js
    • Updated tpuType from v2-8 to v5litepod-4 (line 52).
    • Updated tpuSoftwareVersion from tpu-vm-tf-2.14.1 to v2-tpuv5-litepod (line 56).
  • tpu/queuedResources/createQueuedResource.js
    • Updated tpuType from v2-8 to v5litepod-4 (line 57).
    • Updated tpuSoftwareVersion from tpu-vm-tf-2.14.1 to v2-tpuv5-litepod (line 61).
  • tpu/queuedResources/deleteQueuedResource.js
    • Updated zone from us-central1-f to us-central1-a (line 39).
  • tpu/queuedResources/forceDeleteQueuedResource.js
    • Updated zone from us-central1-f to us-central1-a (line 39).
  • tpu/queuedResources/getQueuedResource.js
    • Updated zone from us-central1-f to us-central1-a (line 39).
  • tpu/queuedResources/getQueuedResourcesList.js
    • Updated zone from us-central1-f to us-central1-a (line 36).
  • tpu/test/forceDeleteQueuedResource.test.js
    • Updated zone from us-central1-f to us-central1-a (line 26).
  • tpu/test/queuedResource.test.js
    • Updated zone from us-central1-f to us-central1-a (line 30).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


The TPUs evolve, a faster pace,
From v2 to v5, a hardware race.
New software versions, zones align,
To keep the cloud samples in their prime.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the TPU samples to use TPUv5e. The changes involve updating the tpuType and tpuSoftwareVersion variables in several files, as well as updating the zone in some queued resource files. Overall, the changes seem straightforward and necessary for keeping the samples up-to-date with the latest TPU versions.

Summary of Findings

  • TPU Type and Software Version Updates: The tpuType and tpuSoftwareVersion variables have been updated to reflect the TPUv5e configuration. This is the core change of the pull request and seems to be correctly implemented across the relevant files.
  • Zone Updates: The zone has been updated from us-central1-f to us-central1-a in the queued resource files. It's important to ensure that this change is intentional and that the new zone is appropriate for the TPUv5e configuration.

Merge Readiness

The pull request appears to be in good shape for merging, pending verification that the zone update is intentional and correct. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.

@m-strzelczyk m-strzelczyk marked this pull request as ready for review March 13, 2025 14:00
@m-strzelczyk m-strzelczyk requested review from a team as code owners March 13, 2025 14:00
Copy link
Contributor

@briandorsey briandorsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on similar changes in other repos for the same bug.

@glasnt glasnt dismissed gemini-code-assist[bot]’s stale review March 14, 2025 00:35

Bot can't close it's own reviews when addressed

@glasnt glasnt merged commit 4c03eb2 into main Mar 14, 2025
12 checks passed
@glasnt glasnt deleted the strzelczyk/tpu-update branch March 14, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: tpu Issues related to the Cloud TPU API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants