-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(tpu): Updating TPU samples to use TPUv5e #4028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @m-strzelczyk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the TPU samples to use TPUv5e. Specifically, it modifies the tpuType and tpuSoftwareVersion variables in several files to reflect the new TPU version. Additionally, the zone is updated from us-central1-f to us-central1-a in several files related to queued resources.
Highlights
- TPU Version Update: The samples are updated to use TPUv5e by changing the
tpuTypefromv2-8tov5litepod-4and thetpuSoftwareVersionfromtpu-vm-tf-2.17.0-pod-pjrtortpu-vm-tf-2.14.1tov2-tpuv5-litepod. - Zone Update: The zone for queued resources is updated from
us-central1-ftous-central1-a.
Changelog
Click here to see the changelog
- tpu/createStartupScriptVM.js
- Updated
tpuTypefromv2-8tov5litepod-4(line 53). - Updated
tpuSoftwareVersionfromtpu-vm-tf-2.17.0-pod-pjrttov2-tpuv5-litepod(line 57).
- Updated
- tpu/createTopologyVM.js
- Updated
tpuSoftwareVersionfromtpu-vm-tf-2.17.0-pod-pjrttov2-tpuv5-litepod(line 54).
- Updated
- tpu/createVM.js
- Updated
tpuTypefromv2-8tov5litepod-4(line 52). - Updated
tpuSoftwareVersionfromtpu-vm-tf-2.14.1tov2-tpuv5-litepod(line 56).
- Updated
- tpu/queuedResources/createQueuedResource.js
- Updated
tpuTypefromv2-8tov5litepod-4(line 57). - Updated
tpuSoftwareVersionfromtpu-vm-tf-2.14.1tov2-tpuv5-litepod(line 61).
- Updated
- tpu/queuedResources/deleteQueuedResource.js
- Updated
zonefromus-central1-ftous-central1-a(line 39).
- Updated
- tpu/queuedResources/forceDeleteQueuedResource.js
- Updated
zonefromus-central1-ftous-central1-a(line 39).
- Updated
- tpu/queuedResources/getQueuedResource.js
- Updated
zonefromus-central1-ftous-central1-a(line 39).
- Updated
- tpu/queuedResources/getQueuedResourcesList.js
- Updated
zonefromus-central1-ftous-central1-a(line 36).
- Updated
- tpu/test/forceDeleteQueuedResource.test.js
- Updated
zonefromus-central1-ftous-central1-a(line 26).
- Updated
- tpu/test/queuedResource.test.js
- Updated
zonefromus-central1-ftous-central1-a(line 30).
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The TPUs evolve, a faster pace,
From v2 to v5, a hardware race.
New software versions, zones align,
To keep the cloud samples in their prime.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates the TPU samples to use TPUv5e. The changes involve updating the tpuType and tpuSoftwareVersion variables in several files, as well as updating the zone in some queued resource files. Overall, the changes seem straightforward and necessary for keeping the samples up-to-date with the latest TPU versions.
Summary of Findings
- TPU Type and Software Version Updates: The
tpuTypeandtpuSoftwareVersionvariables have been updated to reflect the TPUv5e configuration. This is the core change of the pull request and seems to be correctly implemented across the relevant files. - Zone Updates: The zone has been updated from
us-central1-ftous-central1-ain the queued resource files. It's important to ensure that this change is intentional and that the new zone is appropriate for the TPUv5e configuration.
Merge Readiness
The pull request appears to be in good shape for merging, pending verification that the zone update is intentional and correct. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
briandorsey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on similar changes in other repos for the same bug.
Bot can't close it's own reviews when addressed
Description
Fixes b/396449050
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.