Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Mar 25, 2025

Description

Updates #3985

The proxy isn't required for this sample, and the proof of concept doesn't completely work anyway. So remove it.

  • Please merge this PR for me once it is approved

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes an unnecessary proxy setup from the run/idp-sql sample. The PR description indicates that the proxy isn't required and the proof of concept implementation was not fully functional. The changes involve removing the proxy-setup.sh script and updating the package.json file to remove the call to that script in the system-test command.

Highlights

  • Proxy Removal: The primary change is the removal of the proxy setup script and its invocation from the system tests.
  • Package.json Update: The package.json file is updated to remove the test/proxy-setup.sh call from the system-test script.

Changelog

  • run/idp-sql/package.json
    • Removed test/proxy-setup.sh from the system-test script.
  • run/idp-sql/test/proxy-setup.sh
    • Deleted the entire proxy-setup.sh file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the purpose of a proxy server?

Click here for the answer
A proxy server acts as an intermediary between a client and a server. It can provide various functions such as security, caching, and anonymity.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Mar 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an unneeded proxy setup for the system tests. The changes look good overall.

Merge Readiness

The pull request removes the unnecessary proxy setup, simplifying the system tests. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. Given the changes are straightforward and the proxy was deemed unnecessary, the pull request appears ready for merging.

@glasnt glasnt marked this pull request as ready for review March 25, 2025 03:32
@glasnt glasnt requested review from a team as code owners March 25, 2025 03:32
@glasnt glasnt merged commit cbfe3c1 into main Mar 26, 2025
12 checks passed
@glasnt glasnt deleted the proxy-no-proxy branch March 26, 2025 01:36
rudrakhsha-crest pushed a commit to rudrakhsha-crest/nodejs-docs-samples that referenced this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants