From 9ee7a1cd0acd96bd1a7fb88d22cebfc93f13319c Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Wed, 26 Mar 2025 15:30:23 +0000 Subject: [PATCH 1/2] chore(gae): Migrate region tags from build-an-app --- appengine/building-an-app/build/app.yaml | 2 ++ appengine/building-an-app/update/app.yaml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/appengine/building-an-app/build/app.yaml b/appengine/building-an-app/build/app.yaml index 7c10aece83..28e0dbefdc 100755 --- a/appengine/building-an-app/build/app.yaml +++ b/appengine/building-an-app/build/app.yaml @@ -11,8 +11,10 @@ # See the License for the specific language governing permissions and # limitations under the License. +# [START gae_build_app_yaml_node] # [START app_yaml] # [START gae_app_yaml] runtime: nodejs20 # [END gae_app_yaml] # [END app_yaml] +# [END gae_build_app_yaml_node] diff --git a/appengine/building-an-app/update/app.yaml b/appengine/building-an-app/update/app.yaml index 9c14502f49..cdc0be90ee 100755 --- a/appengine/building-an-app/update/app.yaml +++ b/appengine/building-an-app/update/app.yaml @@ -11,8 +11,10 @@ # See the License for the specific language governing permissions and # limitations under the License. +# [START gae_update_app_yaml_node] # [START gae_app_yaml] # [START app_yaml] runtime: nodejs20 # [END app_yaml] # [END gae_app_yaml] +# [END gae_update_app_yaml_node] From 5355f5fd9088c6cd693ff995fdc06b9726b60973 Mon Sep 17 00:00:00 2001 From: Ivan Hernandez Date: Wed, 26 Mar 2025 15:44:01 +0000 Subject: [PATCH 2/2] fix(gae): Fix linting issues --- appengine/building-an-app/build/test/server.test.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/appengine/building-an-app/build/test/server.test.js b/appengine/building-an-app/build/test/server.test.js index f5af8ba230..a701e00f68 100644 --- a/appengine/building-an-app/build/test/server.test.js +++ b/appengine/building-an-app/build/test/server.test.js @@ -15,15 +15,14 @@ const supertest = require('supertest'); const path = require('path'); const app = require(path.join(__dirname, '../', 'server.js')); - describe('gae_app', () => { it('should be listening', async () => { await supertest(app).get('/').expect(200); }); -}) +}); describe('gae_build_web_server_app', () => { it('should be listening', async () => { await supertest(app).get('/').expect(200); }); -}) +});