Skip to content

Conversation

@YashSaraf11
Copy link
Contributor

Description

Fixes - N/A

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass - N/A
  • These samples need a new/updated env vars in testing projects set to pass - N/A
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample - N/A
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample - N/A
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample - N/A
  • Please merge this PR for me once it is approved

@YashSaraf11 YashSaraf11 requested review from a team as code owners July 9, 2025 11:42
@snippet-bot
Copy link

snippet-bot bot commented Jul 9, 2025

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @YashSaraf11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a set of new Node.js code samples for the Google Cloud Secret Manager service, specifically focusing on regional secrets and their delayed destruction capabilities. These additions aim to provide developers with clear examples of how to programmatically manage the lifecycle of regional secrets, including setting, modifying, and removing destruction delays.

Highlights

  • New Regional Secret Manager Samples: I've added three new Node.js code samples demonstrating how to manage regional secrets with delayed destruction policies.
  • Delayed Destroy Functionality: The new samples cover creating a regional secret with a specified destruction delay, disabling an existing delay, and updating the delay period for a secret version.
  • Test Coverage: Corresponding integration tests have been added to secretmanager.test.js to validate the functionality of these new regional samples, ensuring their correctness and reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request adds regional code samples for delayed destroy functionality in the Secret Manager. The code introduces three new files: createRegionalSecretWithDelayedDestroy.js, disableRegionalSecretDelayedDestroy.js, and updateRegionalSecretWithDelayedDestroy.js. Additionally, it modifies secretmanager.test.js to include tests for the new regional samples. There are a few typos in the comments that should be addressed.

@YashSaraf11 YashSaraf11 merged commit dbd7b1d into main Jul 9, 2025
17 checks passed
@YashSaraf11 YashSaraf11 deleted the add-regional-sm-samples-delayed-destroy branch July 9, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants