From 51a297c581034b62cd27d40b29fb74eaa8047fab Mon Sep 17 00:00:00 2001 From: Yash Saraf Date: Wed, 9 Jul 2025 11:38:37 +0000 Subject: [PATCH 1/3] chore(secretmanager): add regional code samples for delayed destroy --- .../createRegionalSecretWithDelayedDestroy.js | 57 +++++++++++++++++ .../disableRegionalSecretDelayedDestroy.js | 55 +++++++++++++++++ .../updateRegionalSecretWithDelayedDestroy.js | 61 +++++++++++++++++++ secret-manager/test/secretmanager.test.js | 50 +++++++++++++++ 4 files changed, 223 insertions(+) create mode 100644 secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js create mode 100644 secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js create mode 100644 secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js diff --git a/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js b/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js new file mode 100644 index 0000000000..0a98782d26 --- /dev/null +++ b/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js @@ -0,0 +1,57 @@ +// Copyright 2025 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +async function main(projectId, locationId, secretId, timeToLive) { + // [START secretmanager_create_regional_secret_with_delayed_destroy] + /** + * TODO(developer): Uncomment these variables before running the sample. + */ + // const project = 'my-project'; + // const locationId = 'my-location'; + // const secretId = 'my-secret'; + // const timeToLive = 86400; + const parent = `projects/${projectId}/locations/${locationId}`; + + // Imports the Secret Manager library + const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); + + // Adding the endpoint to call the regional secret manager sever + const options = {}; + options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`; + + // Instantiates a client + const client = new SecretManagerServiceClient(options); + + async function createRegionalSecretWithDelayedDestroy() { + const [secret] = await client.createSecret({ + parent: parent, + secretId: secretId, + secret: { + version_destroy_ttl: { + seconds: timeToLive, + }, + }, + }); + + console.log(`Created regional secret ${secret.name}`); + } + + createRegionalSecretWithDelayedDestroy(); + // [END secretmanager_create_regional_secret_with_delayed_destroy] +} + +const args = process.argv.slice(2); +main(...args).catch(console.error); diff --git a/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js b/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js new file mode 100644 index 0000000000..bc7916e513 --- /dev/null +++ b/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js @@ -0,0 +1,55 @@ +// Copyright 2025 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +async function main(projectId, locationId, secretId) { + // [START secretmanager_disable_regional_secret_delayed_destroy] + /** + * TODO(developer): Uncomment these variables before running the sample. + */ + // const projectId = 'my-project'; + // const locationId = 'my-location'; + // const secretId = 'my-secret'; + const name = `projects/${projectId}/locations/${locationId}/secrets/${secretId}`; + + // Imports the Secret Manager library + const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); + + // Adding the endpoint to call the regional secret manager sever + const options = {}; + options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`; + + // Instantiates a client + const client = new SecretManagerServiceClient(options); + + async function disableRegionalSecretDelayedDestroy() { + const [secret] = await client.updateSecret({ + secret: { + name: name, + }, + updateMask: { + paths: ['version_destroy_ttl'], + }, + }); + + console.info(`Disabled delayed destroy ${secret.name}`); + } + + disableRegionalSecretDelayedDestroy(); + // [END secretmanager_disable_regional_secret_delayed_destroy] +} + +const args = process.argv.slice(2); +main(...args).catch(console.error); diff --git a/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js new file mode 100644 index 0000000000..e0b0660a30 --- /dev/null +++ b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js @@ -0,0 +1,61 @@ +// Copyright 2025 Google LLC +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// https://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +'use strict'; + +async function main( + projectId, locationId, secretId, updatedTimeToLive +) { + // [START secretmanager_update_regional_secret_with_delayed_destroy] + /** + * TODO(developer): Uncomment these variables before running the sample. + */ + // const projectId = 'my-project'; + // const locationId = 'my-location'; + // const secretId = 'my-secret'; + // const updatedTimeToLive = 86400; + const name = `projects/${projectId}/locations/${locationId}/secrets/${secretId}`; + + // Imports the Secret Manager library + const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); + + // Adding the endpoint to call the regional secret manager sever + const options = {}; + options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`; + + // Instantiates a client + const client = new SecretManagerServiceClient(options); + + async function updateRegionalSecret() { + const [secret] = await client.updateSecret({ + secret: { + name: name, + version_destroy_ttl: { + seconds: updatedTimeToLive, + }, + }, + updateMask: { + paths: ['version_destroy_ttl'], + }, + }); + + console.info(`Updated regional secret ${secret.name}`); + } + + updateRegionalSecret(); + // [END secretmanager_update_regional_secret_with_delayed_destroy] +} + +const args = process.argv.slice(2); +main(...args).catch(console.error); diff --git a/secret-manager/test/secretmanager.test.js b/secret-manager/test/secretmanager.test.js index 8d169b59d6..145f27ccb5 100644 --- a/secret-manager/test/secretmanager.test.js +++ b/secret-manager/test/secretmanager.test.js @@ -599,4 +599,54 @@ describe('Secret Manager samples', () => { name: `${secret.name}-delayedDestroy`, }); }); + + it('creates a regional secret with delayed destroy', async () => { + const timeToLive = 24 * 60 * 60; + const output = execSync( + `node regional_samples/createRegionalSecretWithDelayedDestroy.js ${projectId} ${locationId} ${secretId}-2-dd ${timeToLive}` + ); + assert.match(output, new RegExp('Created regional secret')); + }); + + it('disables a regional secret delayed destroy', async () => { + await regionalClient.createSecret({ + parent: `projects/${projectId}/locations/${locationId}`, + secretId: `${secretId}-delayedDestroy`, + secret: { + version_destroy_ttl: { + seconds: 24 * 60 * 60, + }, + }, + }); + + const output = execSync( + `node regional_samples/disableRegionalSecretDelayedDestroy.js ${projectId} ${locationId} ${secretId}-delayedDestroy` + ); + assert.match(output, new RegExp('Disabled delayed destroy')); + + await regionalClient.deleteSecret({ + name: `projects/${projectId}/locations/${locationId}/secrets/${secretId}-delayedDestroy`, + }); + }); + + it('updates a regional secret delayed destroy', async () => { + const updatedTimeToLive = 24 * 60 * 60 * 2; + await regionalClient.createSecret({ + parent: `projects/${projectId}/locations/${locationId}`, + secretId: `${secretId}-delayedDestroy`, + secret: { + version_destroy_ttl: { + seconds: 24 * 60 * 60, + }, + }, + }); + + const output = execSync( + `node regional_samples/updateRegionalSecretWithDelayedDestroy.js ${projectId} ${locationId} ${secretId}-delayedDestroy ${updatedTimeToLive}` + ); + assert.match(output, new RegExp('Updated regional secret')); + await regionalClient.deleteSecret({ + name: `projects/${projectId}/locations/${locationId}/secrets/${secretId}-delayedDestroy`, + }); + }); }); From ce6037cd979411177d950b2d6d3c94458ceae8e3 Mon Sep 17 00:00:00 2001 From: Yash Saraf Date: Wed, 9 Jul 2025 11:44:29 +0000 Subject: [PATCH 2/3] chore(secretmanager): fix linting issue --- .../updateRegionalSecretWithDelayedDestroy.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js index e0b0660a30..9c242f4dd7 100644 --- a/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js +++ b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js @@ -14,9 +14,7 @@ 'use strict'; -async function main( - projectId, locationId, secretId, updatedTimeToLive -) { +async function main(projectId, locationId, secretId, updatedTimeToLive) { // [START secretmanager_update_regional_secret_with_delayed_destroy] /** * TODO(developer): Uncomment these variables before running the sample. From c3395551c093acda8d155803167060e6e2432327 Mon Sep 17 00:00:00 2001 From: Yash Saraf Date: Wed, 9 Jul 2025 11:47:06 +0000 Subject: [PATCH 3/3] chore(secretmanager): fix spell errors in comment --- .../regional_samples/createRegionalSecretWithDelayedDestroy.js | 2 +- .../regional_samples/disableRegionalSecretDelayedDestroy.js | 2 +- .../regional_samples/updateRegionalSecretWithDelayedDestroy.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js b/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js index 0a98782d26..7044f45274 100644 --- a/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js +++ b/secret-manager/regional_samples/createRegionalSecretWithDelayedDestroy.js @@ -28,7 +28,7 @@ async function main(projectId, locationId, secretId, timeToLive) { // Imports the Secret Manager library const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); - // Adding the endpoint to call the regional secret manager sever + // Adding the endpoint to call the regional secret manager server const options = {}; options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`; diff --git a/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js b/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js index bc7916e513..b94fdaa308 100644 --- a/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js +++ b/secret-manager/regional_samples/disableRegionalSecretDelayedDestroy.js @@ -27,7 +27,7 @@ async function main(projectId, locationId, secretId) { // Imports the Secret Manager library const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); - // Adding the endpoint to call the regional secret manager sever + // Adding the endpoint to call the regional secret manager server const options = {}; options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`; diff --git a/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js index 9c242f4dd7..50917293c4 100644 --- a/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js +++ b/secret-manager/regional_samples/updateRegionalSecretWithDelayedDestroy.js @@ -28,7 +28,7 @@ async function main(projectId, locationId, secretId, updatedTimeToLive) { // Imports the Secret Manager library const {SecretManagerServiceClient} = require('@google-cloud/secret-manager'); - // Adding the endpoint to call the regional secret manager sever + // Adding the endpoint to call the regional secret manager server const options = {}; options.apiEndpoint = `secretmanager.${locationId}.rep.googleapis.com`;