Skip to content

Conversation

@durgesh-ninave-crest
Copy link
Contributor

Description

Created samples for Global and Regional Secret Manager API

Samples (Global, Regional)

  1. Create Secret With Tags
  2. Bind Tags to Secret

Ref: https://cloud.google.com/secret-manager/docs/create-and-manage-tags

Additionally, in certain tests, some resources were not properly deleted; therefore, I have updated the tests accordingly.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new code samples for the Google Cloud Secret Manager service, demonstrating how to leverage the new tagging capabilities for secrets. It provides examples for both global and regional Secret Manager APIs, covering scenarios like creating secrets with tags and binding existing tags to secrets. Additionally, the PR includes improvements to the test suite to ensure all created resources, including tags, are properly cleaned up after test execution.

Highlights

  • New Secret Manager Tag Samples (Global): Added two new sample files: createSecretWithTags.js to demonstrate creating a secret with pre-defined tags, and bindTagsToSecret.js to show how to bind existing tags to a secret.
  • New Secret Manager Tag Samples (Regional): Introduced regional versions of the tag samples: regional_samples/createRegionalSecretWithTags.js and regional_samples/bindTagsToRegionalSecret.js, which configure the Secret Manager client to interact with regional endpoints.
  • Dependency Updates: Updated the @google-cloud/secret-manager dependency to ^6.1.0 and added @google-cloud/resource-manager ^6.2.0 to support the new tag-related functionalities.
  • Enhanced Test Cleanup: Modified secretmanager.test.js to ensure proper cleanup of resources, including newly created secrets, tag keys, and tag values, addressing previous issues where some resources were not properly deleted.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new samples for creating secrets with tags and binding tags to secrets, for both global and regional APIs. The changes are well-implemented and include corresponding tests and fixes for resource cleanup in the test suite. My review focuses on improving the structure of the new sample files for better readability and replacing a fixed-delay wait in the tests with a more robust polling mechanism to improve test reliability and performance.

@YashSaraf11 YashSaraf11 marked this pull request as ready for review July 14, 2025 05:07
@YashSaraf11 YashSaraf11 requested review from a team as code owners July 14, 2025 05:07
@snippet-bot
Copy link

snippet-bot bot commented Jul 14, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@YashSaraf11 YashSaraf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YashSaraf11 YashSaraf11 merged commit 68c79f9 into GoogleCloudPlatform:main Jul 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants