From 3d4001c34ff4c49d4b0a594918a405553d963699 Mon Sep 17 00:00:00 2001 From: Katie McLaughlin Date: Mon, 14 Jul 2025 15:01:34 +1000 Subject: [PATCH 1/2] ci: skip failing retail tests Addresses #4136 Unblocks many PRs --- .../interactive-tutorials/test/search-with-pagination.test.js | 3 ++- .../test/search-with-query-expansion-spec.test.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/retail/interactive-tutorials/test/search-with-pagination.test.js b/retail/interactive-tutorials/test/search-with-pagination.test.js index 2f9c64882d..38761ce68f 100644 --- a/retail/interactive-tutorials/test/search-with-pagination.test.js +++ b/retail/interactive-tutorials/test/search-with-pagination.test.js @@ -38,7 +38,8 @@ describe('Search with pagination', () => { assert.match(stdout, /Search start/); }); - it('should contain next page token', () => { + // https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 + it.skip('should contain next page token', () => { assert.match(stdout, /Next page token/); }); diff --git a/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js b/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js index 06d5a60c23..87cac2cd50 100644 --- a/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js +++ b/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js @@ -97,7 +97,8 @@ describe('Search with query expansion spec', () => { } }); - it('should contain expanded query', () => { + // https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 + it.skip('should contain expanded query', () => { const searchResponse = response[IResponseParams.ISearchResponse]; expect( searchResponse.queryExpansionInfo, From 0f110baed8eb14e3a5c669afccbf16223b49e996 Mon Sep 17 00:00:00 2001 From: Katie McLaughlin Date: Mon, 14 Jul 2025 15:05:14 +1000 Subject: [PATCH 2/2] Apply suggestions from robot code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- .../interactive-tutorials/test/search-with-pagination.test.js | 2 +- .../test/search-with-query-expansion-spec.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/retail/interactive-tutorials/test/search-with-pagination.test.js b/retail/interactive-tutorials/test/search-with-pagination.test.js index 38761ce68f..21905da02b 100644 --- a/retail/interactive-tutorials/test/search-with-pagination.test.js +++ b/retail/interactive-tutorials/test/search-with-pagination.test.js @@ -38,7 +38,7 @@ describe('Search with pagination', () => { assert.match(stdout, /Search start/); }); - // https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 + // TODO(#4136): Re-enable this test. See https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 it.skip('should contain next page token', () => { assert.match(stdout, /Next page token/); }); diff --git a/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js b/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js index 87cac2cd50..242022698c 100644 --- a/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js +++ b/retail/interactive-tutorials/test/search-with-query-expansion-spec.test.js @@ -97,7 +97,7 @@ describe('Search with query expansion spec', () => { } }); - // https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 + // TODO(#4136): Re-enable this test. See https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues/4136 it.skip('should contain expanded query', () => { const searchResponse = response[IResponseParams.ISearchResponse]; expect(