-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: update repository URL #4142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @faube, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a necessary fix by updating a repository URL in a package.json file. This change reflects the migration of content and history from a deprecated repository to a new, consolidated location, ensuring that the project correctly references its current source.
Highlights
- Repository URL Update: The
repository.urlfield within thepackage.jsonfile for therecaptcha_enterprise/demosite/appmodule has been updated. The old URL,https://github.com/googleapis/nodejs-recaptcha-enterprise.git, which is deprecated, has been replaced with the new URL,https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the repository URL in the package.json for the reCAPTCHA Enterprise demosite. My review focuses on the correctness of this metadata. I've pointed out a potential discrepancy between the PR description and the new URL, and also suggested an improvement to the repository field to make it compliant with monorepo best practices by adding a directory field.
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/googleapis/nodejs-recaptcha-enterprise.git" | ||
| "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a discrepancy between the PR description, which states the content was moved to google-cloud-node, and this change, which points to nodejs-docs-samples. Could you please confirm which repository is correct?
Additionally, since this package now resides in a subdirectory of a monorepo, it's a best practice to specify the directory field within the repository object. This helps tools like npm correctly locate the package.
Assuming nodejs-docs-samples is the correct repository, I'd suggest updating the repository object as follows:
"repository": {
"type": "git",
"url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples.git",
"directory": "recaptcha_enterprise/demosite/app"
},
The previous repo is deprecated. All of its content and history has been moved to google-cloud-node.